From: Songpeng Li <songpeng.li@intel.com>
To: edk2-devel@lists.01.org
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>
Subject: [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable.
Date: Mon, 14 Jan 2019 17:25:17 +0800 [thread overview]
Message-ID: <20190114092517.38448-3-songpeng.li@intel.com> (raw)
In-Reply-To: <20190114092517.38448-1-songpeng.li@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413
The global variable mAllDhcpServersAddress has never
been used, this patch is to clean it.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
---
NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 2 --
NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
index 9ace833b98f7..6506453c0dad 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
@@ -19,10 +19,8 @@
// Well-known multi-cast address defined in section-24.1 of rfc-3315
//
// ALL_DHCP_Relay_Agents_and_Servers address: FF02::1:2
-// ALL_DHCP_Servers address: FF05::1:3
//
EFI_IPv6_ADDRESS mAllDhcpRelayAndServersAddress = {{0xFF, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 2}};
-EFI_IPv6_ADDRESS mAllDhcpServersAddress = {{0xFF, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 3}};
EFI_DHCP6_PROTOCOL gDhcp6ProtocolTemplate = {
EfiDhcp6GetModeData,
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
index f21b79668a8b..e91f4da41451 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
@@ -68,7 +68,6 @@ typedef struct _DHCP6_INSTANCE DHCP6_INSTANCE;
#define DHCP6_SERVICE_FROM_THIS(Service) CR ((Service), DHCP6_SERVICE, ServiceBinding, DHCP6_SERVICE_SIGNATURE)
extern EFI_IPv6_ADDRESS mAllDhcpRelayAndServersAddress;
-extern EFI_IPv6_ADDRESS mAllDhcpServersAddress;
extern EFI_DHCP6_PROTOCOL gDhcp6ProtocolTemplate;
//
--
2.18.0.windows.1
next prev parent reply other threads:[~2019-01-14 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 9:25 [PATCH v1 0/2] Remove unused global variables in Songpeng Li
2019-01-14 9:25 ` [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables Songpeng Li
2019-01-14 11:14 ` Fu, Siyuan
2019-01-14 9:25 ` Songpeng Li [this message]
2019-01-14 11:14 ` [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable Fu, Siyuan
2019-01-15 1:29 ` [PATCH v1 0/2] Remove unused global variables in Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114092517.38448-3-songpeng.li@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox