From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 657BC211B5A3E for ; Mon, 14 Jan 2019 03:41:43 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id t6so22391905wrr.12 for ; Mon, 14 Jan 2019 03:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FDmUsnil8zyUzp6bWP7B8v84x2kO7pfVFCdx63jus3M=; b=PESPrrM97XOHWCe9FRZYFZwH4HL8Nkh8to2u7qqlAQ/AqqrK1NbjImFFIpqdj9PT8u yw5yGZTdcPudp8Tc8xTm+fx0bWKiwkNc3jjpWS0AtxfZWrshp3wS+O9YYBMEczpCbsVo YMCI9KgLk8Ys2rXMtKgHU4ujNk9IAvrIkl2a0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FDmUsnil8zyUzp6bWP7B8v84x2kO7pfVFCdx63jus3M=; b=Iz7ISF0boihpuDHzDKWaVdOvGUKGveLWJGEagcgpnbjYMifi/pTmkPw6B77hWSerbN 1C/lOfZQ+5V+bS4NAZ0n5z/EoCWUWKqYO6S3TUtsmwcmNFtaAkrdnYB7WGa5BVyQJWZv OvR222vgbLRz+0JqpNJYhFxnkqAq09xbSprAp23Sw9g5KaOP5y9k8g3HOuozjjHAwZlA W8lT/0hfUqJJ07IU0Qb9qWlghqTvUobU24biYyCsz1gqwITVED7XD4jUcurFUc0pzp+z Exhz+kSpYr4FQQpFQB4kxO7eIDs6vGDEPCsFm7Tu1nV0uv3oL7i9iSHz8O0pOUbp1KC/ GmXQ== X-Gm-Message-State: AJcUukegQGL9gNKBNWaQqTv6Lgmo1lbSlqEq4gtd+wE7CAUr0bgW9L+5 VtqE6nlZWk2hbyoi3K+rTMBmsQ== X-Google-Smtp-Source: ALg8bN7U3YOTO7JMZWM+bZGi6R5OILaV4H6bbnqyyeDnXtBuPqs7D0ImzaMfU7p3+Aj4Jiusv16NIg== X-Received: by 2002:adf:9b11:: with SMTP id b17mr24314842wrc.168.1547466100658; Mon, 14 Jan 2019 03:41:40 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q6sm11136167wmq.4.2019.01.14.03.41.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 03:41:39 -0800 (PST) Date: Mon, 14 Jan 2019 11:41:38 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, liming.gao@intel.com, bob.c.feng@intel.com Message-ID: <20190114114138.ttqlr5mfzh465pic@bivouac.eciton.net> References: <20190107065541.1854-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190107065541.1854-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 11:41:43 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote: > GCC for 32-bit ARM chokes on .aslc files when running with LTO > enabled. Since LTO has no benefit whatsoever here, just disable > it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Looks sensible. Reviewed-by: Leif Lindholm > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index f7eb87af14c2..e68cfd9a4997 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os > *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy > > *_GCC5_ARM_ARCHCC_FLAGS = -mthumb > -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto > *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS) > *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS) > *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS) > -- > 2.20.1 >