From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D2752117FD4C for ; Mon, 14 Jan 2019 14:11:08 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id m22so1232515wml.3 for ; Mon, 14 Jan 2019 14:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=997lNNi++wdbWvAmL6eH1mt29i7RjFzOjvqjaNqpQHo=; b=OFfgbLPxtRHolRtjOyaQG8h/iNx4I54kx2TnJUbjUiiFgkWaDkoS9YWRlA0Nc16UUX SI/NdYacQmj1COZRFicHHQPPOnvpHCJdGeTd4q2pcon5pizZBd3xBo4GpRjcW1+9eTQV GMWlO6uNN+/uhskg1EguZbta/TzK58oKO1Fu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=997lNNi++wdbWvAmL6eH1mt29i7RjFzOjvqjaNqpQHo=; b=DPgeS7N6/CF0b6fk5+QhQO+lAqDO45bzz2JNK1850RrEY9vXzAccLnhbrqalIMhfMx TbKzBjAyAekCfKSuRMu9GG0R9537gX6kJhMvagIkzuBCX0o/9C8q4xeIlyF1Jmolks/H vwsOZ9JXMOZ7sKtztIM2Ku72U7nRzeFgSkB8oOynjUm2vDEBJdWRLGp3b9aeXuMBKcsO 3EerYH9dBSxs5vAc8Mc9lM08GOTyWDZzfJ+dFt6omHTFWXIOhgVZTcTsANmc5Qm69cDQ QFZrjmZIaqPLVnVN/oEWtMA1aHnLWspFErXmW4igCUSKPiVPfo4cq4HXFXhHVWa+OSHb Fz7w== X-Gm-Message-State: AJcUukfVYFHdJmESOIWqO6xREuzTmh5BElXStqXfPi7+faYQiih0ReNV L4wRRICykHN9IdgRetWycooCxw== X-Google-Smtp-Source: ALg8bN4fYh4s0OdI+2Feu2EQVJTqI0lUdSERmScfVSzkMeoy3vhCaW31eCUrDUSbsrmmgur0/ElePg== X-Received: by 2002:a1c:67c2:: with SMTP id b185mr838456wmc.96.1547503866670; Mon, 14 Jan 2019 14:11:06 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a12sm68221580wrm.45.2019.01.14.14.11.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 14:11:05 -0800 (PST) Date: Mon, 14 Jan 2019 22:11:04 +0000 From: Leif Lindholm To: Star Zeng Cc: edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20190114221104.oudom6c7utyf6pb7@bivouac.eciton.net> References: <1547479196-40248-1-git-send-email-star.zeng@intel.com> <1547479196-40248-13-git-send-email-star.zeng@intel.com> MIME-Version: 1.0 In-Reply-To: <1547479196-40248-13-git-send-email-star.zeng@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH V2 12/15] BeagleBoardPkg: Use merged variable driver for emulated NV mode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 22:11:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Star, This set looks like a good cleanup. This patch also need an added resolution for SynchronizationLib. (MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf should be fine.) The same modification will also be needed in edk2-platforms for Platform/Hisilicon/HiKey and HiKey960. Regards, Leif On Mon, Jan 14, 2019 at 11:19:53PM +0800, Star Zeng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 > Merge EmuVariable and Real variable driver. > > The real variable driver has been updated to support emulated > variable NV mode and the EmuVariableRuntimeDxe will be removed > later, so use merged variable driver for emulated NV mode. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 13 +++++++++++-- > BeagleBoardPkg/BeagleBoardPkg.fdf | 4 ++-- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index 6dabfa905ae9..479b1504825a 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -2,7 +2,7 @@ > # Beagle board package. > # > # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -137,6 +137,10 @@ [LibraryClasses.common] > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > + AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > + TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > + VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > @@ -345,6 +349,11 @@ [PcdsFixedAtBuild.common] > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > > + # > + # Make VariableRuntimeDxe work at emulated non-volatile variable mode. > + # > + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -376,7 +385,7 @@ [Components.common] > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > - MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf > > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf > index 83d85fce4070..42d6bad0c73b 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf > @@ -1,7 +1,7 @@ > # FLASH layout file for Beagle board. > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -106,7 +106,7 @@ [FV.FvMain] > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > - INF MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > INF EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf > > INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > -- > 2.7.0.windows.1 >