From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B35C621BADAB2 for ; Mon, 14 Jan 2019 14:44:20 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id d15so1348465wmb.3 for ; Mon, 14 Jan 2019 14:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ErgQ2BLCrffmmcQPamWl5HIwheJjEXDafr0Xy9nUh4Y=; b=FnM58TRo9nuspGxO32JBmLPbfFaQTYjD/JKqgz4eqLV0sGpopvbJEwrnd5t+Rbd/XW 50bkXJaeMgTmIFxtyVrOlbwpliZ3zstZQAKAfAGLwBEJqGp6zXanYnoyO+nwiNc+Ujmb TIBJcSifCO+MRQUQ3RqA4YZTVVKI/0gphwxz0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ErgQ2BLCrffmmcQPamWl5HIwheJjEXDafr0Xy9nUh4Y=; b=NPtvPgkfeMCQ7VwpHkoWQGaSKO6Zd/tjvNkg8B4K6/pcIgRjDee3fdo0OA7fL+y4M+ v+oYYJ3ccFNvsBErmDYLUKu40W45GwxmihU07EDbs10SlL8XagRh1Iiqc0IsW9fHUNdP 1XWpLE36QVLGcFS9EqEvZoX4Og/u6/fxU0UAF/B+f3iYJuuswoeI0GsdiUub5i9ntXRa gh/LVD5Znuz7Ulisi/4GWBYvhHXbYuw4RDXxNZyURwCjqCu+Sd6JahWUV8g4XBLzGk2I 8+Pu4u/fsGOnC693oa0vDjhmsbP4Qd0XroVGNSBuEsbYbuYVCJ2R7+gTEYVyvVg5T3xB j2sw== X-Gm-Message-State: AJcUukeegq/cAhjI6GWBMFVR2lJMkt5ZmEIgqzs5a0NyM5ZybSxOaAHD GmekSI9KfPd/yhuKw386hJ7l8w== X-Google-Smtp-Source: ALg8bN6KXMWVWXFLhksEaLG1grKLRz1djmQjZGhdRn/TmxX+9LDWgUeq1FUzCLjPKGpUs3aiELXkOQ== X-Received: by 2002:a1c:3d44:: with SMTP id k65mr954607wma.76.1547505859239; Mon, 14 Jan 2019 14:44:19 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p6sm88206786wrx.50.2019.01.14.14.44.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 14:44:18 -0800 (PST) Date: Mon, 14 Jan 2019 22:44:17 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Message-ID: <20190114224417.hoazuf6h4obv4xpy@bivouac.eciton.net> References: <1547084679-29597-1-git-send-email-mw@semihalf.com> <1547084679-29597-6-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1547084679-29597-6-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 05/12] Marvell/Armada80x0Db: Extend board description library with GPIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 22:44:22 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 10, 2019 at 02:44:32AM +0100, Marcin Wojtas wrote: > This patch implements ArmadaBoarDescLib library for > Armada80x0Db comunity board and introduces ArmadaBoardGpioGet > routine with per-board GPIO expander description. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf | 1 + > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 31 ++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf > index 2d39d96..786b7f0 100644 > --- a/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf > @@ -25,6 +25,7 @@ > Armada80x0DbBoardDescLib.c > > [Packages] > + EmbeddedPkg/EmbeddedPkg.dec > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Silicon/Marvell/Marvell.dec > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c > index feb69ad..f6e3675 100644 > --- a/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c > @@ -21,6 +21,37 @@ > #include > #include > > +#include > + > +// > +// GPIO Expanders > +// > +STATIC MV_GPIO_EXPANDER mGpioExpanders[] = { > + { > + 8, /* PCA9555 */ Same as for 4/12. > + 0x21, > + 0x0, > + }, > + { > + 8, /* PCA9555 */ And again. Please re-jig such that the enum appears in time to be used by this and preceding patches, then resubmit affected patches. / Leif > + 0x25, > + 0x0, > + }, > +}; > + > +EFI_STATUS > +EFIAPI > +ArmadaBoardGpioExpanderGet ( > + IN OUT MV_GPIO_EXPANDER **GpioExpanders, > + IN OUT UINTN *GpioExpanderCount > + ) > +{ > + *GpioExpanderCount = ARRAY_SIZE (mGpioExpanders); > + *GpioExpanders = mGpioExpanders; > + > + return EFI_SUCCESS; > +} > + > // > // Order of devices in SdMmcDescTemplate has to be in par with ArmadaSoCDescLib > // > -- > 2.7.4 >