From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 32485211B5098 for ; Mon, 14 Jan 2019 15:47:00 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id r10so906835wrs.10 for ; Mon, 14 Jan 2019 15:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Os2k9JnZbS48vP2Vla2tsb88X++SfoMrOm2qE2ybqiQ=; b=GAKt1A/xsqbV8ORvnE7mT2DV4Qk4MXhgdQto3COGFbN6iXtl8wQJR23XDFEGbwjd1u +zHsdH8+M+PSN/eC9+d4u0Ih3yn/19YYK1+HA5XnmKrmxFht/hG5qAdzjPdTgBGE4iO1 TXv0asuKjJGc0WEqo6i4DSH2VYwhDtDoMRK8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Os2k9JnZbS48vP2Vla2tsb88X++SfoMrOm2qE2ybqiQ=; b=DnGZllpk4nZS4ECHuVdFNUtkf6ltAbfhVSCwP9S7Ac5aA5V5/5S0vcw+0KCHMBBVhS tNeOqiaLNKx8sgVvsNux883OzVfZUZqJD+SrINjkwBkx+696NZaGGvTGx2Q6ih5fEz6j w4Ha1hRUyC7wRWPrEuSVFVOJA++YySg1/60/+vCh/hl9nS6LZq5qPaxqWkkgblE5R29Z dXNrmYCoMKkAOiJNLWemq3BtN7WQ6NZF3Ia9XUEsw5RN3JClnZvEKdoesXSWV9n72nQ2 tYCEO9wJyrSzcYbEUutNQF5idJjuEcnz4+U30NFuwRwhePS7RH6d1mX1LJrOPEkJQ+jE 35Vg== X-Gm-Message-State: AJcUukcuC6eZ0XJ6GwbKaJWy3YkcpCcv3fvMV1XFjjuyTRMLGWVmN0d0 MTmox7i/O/TW1mhkj/YUk839Ng== X-Google-Smtp-Source: ALg8bN670blefeudwQjMKTZ/23LMe99HGCYQqahlTWywiy4iko8Oyvay6N9T4iOce6yssh88nCZ+Aw== X-Received: by 2002:a5d:4512:: with SMTP id s18mr723417wrq.182.1547509618683; Mon, 14 Jan 2019 15:46:58 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p5sm18230751wmh.16.2019.01.14.15.46.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 15:46:57 -0800 (PST) Date: Mon, 14 Jan 2019 23:46:56 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Message-ID: <20190114234656.7k7nqpelan3ldu6h@bivouac.eciton.net> References: <1547084679-29597-1-git-send-email-mw@semihalf.com> <1547084679-29597-4-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1547084679-29597-4-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 03/12] SolidRun/Armada80x0McBin: Extend board description library with GPIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 23:47:00 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 10, 2019 at 02:44:30AM +0100, Marcin Wojtas wrote: > This patch implements ArmadaBoarDescLib library for > Armada80x0McBin comunity board and introduces ArmadaBoardGpioGet > routine with per-board GPIO expander description. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf | 1 + > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf > index 63a4f66..43e4b9e 100644 > --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf > @@ -25,6 +25,7 @@ > Armada80x0McBinBoardDescLib.c > > [Packages] > + EmbeddedPkg/EmbeddedPkg.dec > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Silicon/Marvell/Marvell.dec > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c > index d52adfc..32596ad 100644 > --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c > @@ -22,6 +22,23 @@ > #include > > // > +// GPIO Expander > +// > +EFI_STATUS > +EFIAPI > +ArmadaBoardGpioExpanderGet ( > + IN OUT MV_GPIO_EXPANDER **GpioExpanders, > + IN OUT UINTN *GpioExpanderCount > + ) > +{ > + /* No GPIO expanders on board */ > + *GpioExpanders = NULL; > + *GpioExpanderCount = 0; > + > + return EFI_SUCCESS; > +} > + > +// > // Order of devices in SdMmcDescTemplate has to be in par with ArmadaSoCDescLib > // > STATIC > -- > 2.7.4 >