From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, lersek@redhat.com,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message
Date: Tue, 15 Jan 2019 09:23:40 +0100 [thread overview]
Message-ID: <20190115082345.3711-1-ard.biesheuvel@linaro.org> (raw)
When running with a graphical console, no message whatsoever is printed
when the systems hits an unexpected exception and hangs, because even
the minimal 'exception occurred' message is only sent to the serial port.
So let's fix that, by updating DefaultExceptionHandlerLib to take the
availability of a console into account. (#5)
This requires some preparatory decruftication so that we can safely refer
to the system table and console (#1 .. #4).
Changes since v1:
- split off ArmVirtPkg patch (#3)
- always send minimal error message to the serial port before attempting to
send it to console->stdout as well (which is more likely to fail) (#5)
- add Leif's R-b to the series
Ard Biesheuvel (5):
ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling
ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context
ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase
ArmPkg/DefaultExceptionHandlerLib: drop BASE variant
ArmPkg/DefaultExceptionHandlerLib: use console if available
ArmPkg/ArmPkg.dsc | 1 -
.../AArch64/DebugAgentException.S | 96 ------
.../Arm/DebugAgentException.S | 277 ------------------
.../Arm/DebugAgentException.asm | 273 -----------------
.../DebugAgentSymbolsBaseLib.c | 7 -
.../DebugAgentSymbolsBaseLib.inf | 9 -
.../AArch64/DefaultExceptionHandler.c | 12 +-
.../Arm/DefaultExceptionHandler.c | 7 +-
.../DefaultExceptionHandlerBase.c | 35 ---
.../DefaultExceptionHandlerLib.inf | 5 +-
.../DefaultExceptionHandlerLibBase.inf | 45 ---
ArmVirtPkg/ArmVirt.dsc.inc | 1 -
12 files changed, 19 insertions(+), 749 deletions(-)
delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S
delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S
delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm
delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c
delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
--
2.17.1
next reply other threads:[~2019-01-15 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 8:23 Ard Biesheuvel [this message]
2019-01-15 8:23 ` [PATCH v2 1/5] ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling Ard Biesheuvel
2019-01-15 8:23 ` [PATCH v2 2/5] ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context Ard Biesheuvel
2019-01-15 8:23 ` [PATCH v2 3/5] ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase Ard Biesheuvel
2019-01-15 10:12 ` Laszlo Ersek
2019-01-15 8:23 ` [PATCH v2 4/5] ArmPkg/DefaultExceptionHandlerLib: drop BASE variant Ard Biesheuvel
2019-01-15 8:23 ` [PATCH v2 5/5] ArmPkg/DefaultExceptionHandlerLib: use console if available Ard Biesheuvel
2019-01-15 10:09 ` Laszlo Ersek
2019-01-15 11:14 ` Ard Biesheuvel
2019-01-16 20:36 ` [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message Ard Biesheuvel
2019-01-17 11:07 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115082345.3711-1-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox