From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F3457211B5A57 for ; Tue, 15 Jan 2019 02:04:36 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id g67so2530157wmd.2 for ; Tue, 15 Jan 2019 02:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kBHhva0foK0tl9ALSkVDxX1vF6khbHNtXLnc1dHNXDk=; b=K4KWtNApV7KE3gYlUmbMvE+Ci/4Pn1CZL3J+0+UZFGhXefWAXWnRTQ+weCqi1TOd2y z/bauwQn2lrRjprCjRjSo0S9wCz0T1U+pidwVSzItAF3IWW68b+Zjlhxtqa+z5FyQPg9 Hnnwiw1T9po33KXgVzXoDS6u1YhhLU98r61P4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kBHhva0foK0tl9ALSkVDxX1vF6khbHNtXLnc1dHNXDk=; b=gRg7eQimoGPgZMqm5IQaUEFS0fRg6ZX/A0VVdBfBmI6OKBYHpZEqfX1yugyDX1OjNm XZGiTUzJ91EsMiTwe5oPum/w5T1VCeBmdfxfZvOnX+hlQZIA4A31VWI+Cc5C5y5AvfzM Nytk8IlkgsA3yZ2ehR2zbgrEOmuJM7htQTELeOoQq7UrCIPa6937J7UNK8lSDx2C+aOa pSax5edfJx7Xd8cD1u9EYHvsYH1qswpBW8vT+J4pmCGI979Bi3YfrC2yiZ7c+j3X+jKP YWreLQL6LHFmP3Rvhcg050E58iDeW76/npXBtLpvmKgCKmpkV5QQC4pfPQZHe4RrNy3N jfxw== X-Gm-Message-State: AJcUukeUbpwvh+thSoMrrwsUm+k0YMZm4Bprm38q/LMah4GXr4Rwp78k DCDx4PUNiVKnngQHKx6isFtlSA== X-Google-Smtp-Source: ALg8bN59Cra/T0FLFjntccLCh1C6KHLWe8B6HOkebY/3sNT6F1A7oCCfdyuDQv81p2mMsK+GHGLShw== X-Received: by 2002:a1c:4681:: with SMTP id t123mr2666716wma.24.1547546675321; Tue, 15 Jan 2019 02:04:35 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c202sm39171040wmd.40.2019.01.15.02.04.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 02:04:34 -0800 (PST) Date: Tue, 15 Jan 2019 10:04:33 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Message-ID: <20190115100433.5wjsy6c6etgltscr@bivouac.eciton.net> References: <1547084679-29597-1-git-send-email-mw@semihalf.com> <1547084679-29597-9-git-send-email-mw@semihalf.com> <20190114233235.5tlm7vqiy677wag4@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 10:04:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 15, 2019 at 07:19:04AM +0100, Marcin Wojtas wrote: > > > + if (MmioRead32 (BaseAddress + MV_GPIO_OUT_EN_REG) & (1 << GpioPin)) { > > > + *Mode = GPIO_MODE_INPUT; > > > + } else { > > > + if (MmioRead32 (BaseAddress + MV_GPIO_DATA_IN_REG) & (1 << GpioPin)) { > > > + *Mode = GPIO_MODE_OUTPUT_1; > > > + } else { > > > + *Mode = GPIO_MODE_OUTPUT_0; > > > > Ah, right, it's the change to EMBEDDED_GPIO that means we have two > > output modes to return instead of just input or output. > > Could I just ask that you're a bit more explicit about such things in > > the cover letter? Would have saved me a couple of minutes of head > > scratching. > > Well, in the cover letter I wrote: > "The biggest change is dropping custom GPIO protocol and start using > the generic EMBEDDED_GPIO with all its types." > > And in the commit log of both drivers: > "The new driver implements a generic EMBEDDED_GPIO protocol." > > Wasn't it explicit enough? :) I mean, it's fine - you've technically given all the information needed to deduce that. But it does sort of imply that the reader knows all EDK2 interfaces by heart. And I'm not quite there. / Leif