From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9493C211B76AE for ; Tue, 15 Jan 2019 03:35:47 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id u4so2582996wrp.3 for ; Tue, 15 Jan 2019 03:35:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1ii5yoym1P2xjDVY8hNwjV/6GoTmKmnGlbQ76GoYbb4=; b=QnBuON4lJ31aIwtIvurLb0eX4RDgDb+jG9C+I7kgwBZP1Z+4phJ0B8xGrPQbOVm8C7 ow2k/0TPsSYyohjH4bNh9B7nNqyqh0Fp+ATEUsHH9rLhHi2DS+/cMxthg4C4hacDRvwu qART+JavdLPhWxQuIim/KjwkUAs8vLdIimJAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1ii5yoym1P2xjDVY8hNwjV/6GoTmKmnGlbQ76GoYbb4=; b=m1NzJI5Hf9qtcHo/YoCyrM5Xl+1iQeb+kbML1aBPXVoYIOsj3idutLS1/mTA9Sbi66 12oX9ZCp0KARPsJEr/UDM2Bb+qfHA3EMWuzgdgSB2EGfxEA5669GFPn39ZWeMRnK5Mit OKhQ5nJxmzdnmNT5jLzqKhoplpjXpF16q8eG3uRssXxM/XGdHzEz/JNneLGyOdrCyvJV 9F8js65X12wj8dk0L1tBkUKNNeYEeGBr4upShFC3D3SKuvZT+zV8B9jbuDZ0pZsVTdzl EjKqzs9AgdhlPyNPeC1k+5a9pqlvqPzESKZiqGmWNIRaHPNJjK4Y+OJHZQM/OcBIofSr VCZQ== X-Gm-Message-State: AJcUukdmPpBQ1EnuuqvLsVslg5KkRVN1sJoMRSjnAB1NZl0WcLbL6Ja0 VIA4g93rJ8yRvrG/R4z/fZKNzA== X-Google-Smtp-Source: ALg8bN6TOR5qU4HtEAozxNh8vq2PQMRNrj/eshZTNAB0I6v72jXC8myT7pi4aGzNOMnwynoPsH99Og== X-Received: by 2002:a5d:5089:: with SMTP id a9mr2791313wrt.327.1547552145393; Tue, 15 Jan 2019 03:35:45 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a1sm67047236wrw.76.2019.01.15.03.35.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 03:35:44 -0800 (PST) Date: Tue, 15 Jan 2019 11:35:43 +0000 From: Leif Lindholm To: Star Zeng Cc: edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20190115113542.s2f4elkkd46gvlhy@bivouac.eciton.net> References: <1547548179-42552-1-git-send-email-star.zeng@intel.com> <1547548179-42552-15-git-send-email-star.zeng@intel.com> MIME-Version: 1.0 In-Reply-To: <1547548179-42552-15-git-send-email-star.zeng@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH V3 14/17] BeagleBoardPkg: Use merged variable driver for emulated NV mode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 11:35:48 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 15, 2019 at 06:29:36PM +0800, Star Zeng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 > Merge EmuVariable and Real variable driver. > > The real variable driver has been updated to support emulated > variable NV mode and the EmuVariableRuntimeDxe will be removed > later, so use merged variable driver for emulated NV mode. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng Reviewed-by: Leif Lindholm > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 14 ++++++++++++-- > BeagleBoardPkg/BeagleBoardPkg.fdf | 4 ++-- > 2 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index 6dabfa905ae9..e0fee3692fd1 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -2,7 +2,7 @@ > # Beagle board package. > # > # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -137,6 +137,11 @@ [LibraryClasses.common] > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > + SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > + AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > + TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > + VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > @@ -345,6 +350,11 @@ [PcdsFixedAtBuild.common] > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > > + # > + # Make VariableRuntimeDxe work at emulated non-volatile variable mode. > + # > + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -376,7 +386,7 @@ [Components.common] > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > - MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf > > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf > index 83d85fce4070..42d6bad0c73b 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf > @@ -1,7 +1,7 @@ > # FLASH layout file for Beagle board. > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -106,7 +106,7 @@ [FV.FvMain] > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > - INF MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf > + INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > INF EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf > > INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > -- > 2.7.0.windows.1 >