From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A6B8C211AF9F4 for ; Wed, 16 Jan 2019 12:18:01 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id y139so3401436wmc.5 for ; Wed, 16 Jan 2019 12:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vYujqftS8tVuOYFHaQQFMRuvXIpgT6rMOb3lLbaT0CM=; b=UcZS4PQXaIVIxH8/E/R+HrM1BeHRKlVfL0dVLxLAbkBucAsPdbYWqjhk08NmTeAmiP JHlIrq+WxxA6HCOp2SMAZWilGkAJb3PFs7xjpWMcWXdTrTDX/d2BXfoMb3sikzB3Wnon 4cum+BYHiIexoFfgFLszb3aubxFiqUBWKYCl4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vYujqftS8tVuOYFHaQQFMRuvXIpgT6rMOb3lLbaT0CM=; b=VlE775qN6uguddtao7Yn6jKEVgs0afFlHfZ8OmT48JQhKdtrvrPQLopnDi1UODILEI Jc4D0cL6B+VtBHIz1gzA/4Z3w2zIr77P/Z//xc88QQznzr7hyltDL6ISKfV5imieZTl9 Cf/3MhazAg6mcmBDNy5QFPvDAzuYFYRkGS0RxgNuO0oCNvt1HXPLsw695bv2OeHwarpN oReQIHhSUJ92Mk83NmC79vWfF3RjHK7oKeZUdrd2wGeej6yOWay9dLkuDkTmAEvmuCXf uvs2CSBWGPa0FUOGave7PhPMhCf13nZ+W9Ydj2TTP9FCsEreBZ/IaE+zfsN4KqbCQzhd twcw== X-Gm-Message-State: AJcUukfXN+SYgS64xC1zI239CiPodXwGLJ+D7JxKDIaAitnrfozbhvP0 4Rel38sJXgaRvWmo+6dfiWyzu803NvQ= X-Google-Smtp-Source: ALg8bN60KkA60UAwqqItFmvNwPopHjmX/Q1hdFnRB70LKalpUe7HC6fokaItuC+tvwAHAP/4eQxr9g== X-Received: by 2002:a1c:2d4b:: with SMTP id t72mr8345481wmt.99.1547669880048; Wed, 16 Jan 2019 12:18:00 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w80sm49017334wme.38.2019.01.16.12.17.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 12:17:59 -0800 (PST) Date: Wed, 16 Jan 2019 20:17:57 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20190116201757.6563lz5jb76m3nqg@bivouac.eciton.net> References: <20190102130044.32453-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190102130044.32453-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg/NorFlashInfoLib: convert to BASE library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 20:18:02 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 02, 2019 at 02:00:44PM +0100, Ard Biesheuvel wrote: > The library's MODULE_TYPE and the module type restrictions it > defines are needlessly strict. Just change the library to BASE > type and drop the restrictions entirely. Also, drop a bogus > library dependency on DxeServicesLib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > index b4b33247fa52..ee207ae7e9d7 100644 > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > @@ -16,9 +16,9 @@ [Defines] > INF_VERSION = 0x00010019 > BASE_NAME = NorFlashInfoLib > FILE_GUID = 6b639c7e-9b53-4e9f-89a3-2e711729709c > - MODULE_TYPE = DXE_DRIVER > + MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = NorFlashInfoLib|DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION > + LIBRARY_CLASS = NorFlashInfoLib > > [Sources] > NorFlashInfoLib.c > @@ -30,5 +30,4 @@ [Packages] > [LibraryClasses] > BaseLib > DebugLib > - DxeServicesLib > MemoryAllocationLib > -- > 2.19.2 >