From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 595B02194D3AE for ; Thu, 17 Jan 2019 01:36:15 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id r24so581770wmh.0 for ; Thu, 17 Jan 2019 01:36:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PRh8RDwaZ82K4p6UkVXePUQ/zJperUTDUhFKnl0gp/4=; b=Q7uDyMNo01TOE9oj2+9hYa/tREVexn12GbZKRLXxzN421WvXawvtNnQSGmwWiFjKjD bxGKVHFp5hL/8T3dqrEEcAQiL/ecZzdyRrb+dspk0JrusR8YKz0ADD1B4rW42E67v8tX DZoxOL9ye5t7/DFw6KMd0C1YomvXH0AVlr3rY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PRh8RDwaZ82K4p6UkVXePUQ/zJperUTDUhFKnl0gp/4=; b=CAYDJuLfDKRNETxr6+R60OiHul+bzFjMLxLTHoiLTUI5uRfAeHWIAk4MjjxiOoQwY6 K1WTHwm/a6dL61XSurK5jNpLa/m3ozLiWzbvEav8kjQmrIVTYBIX9tQ3h5KkwS5Nc0L+ jSxwd25BJkco+C5Pe6wHAcu8Hd3FnJKeQtP4mIE4/gnyY+ybrtUY4/bFtwV9mA8sn12F d8YAkfHg2HgOhPdAom21zw5Ozn7DgETzAODZCM80wWMKT9fKWGNz7888pBSmh7q34KLz MrAJeLhcYFS2j0+/5u5mupwEeN6i0IZqskElZw7i/mAtS+BJG50HM66os2uRrt/kj8FU T5uA== X-Gm-Message-State: AJcUukfj4W+S2yy3m6m69NrpXgqO+RP0b6E9ETf09nXdh46GKi04nHKL 1tgjEf2x5oMhGOAkZNAntspfQA== X-Google-Smtp-Source: ALg8bN6DthtmuNzA0VEvrdDLmeMU3wNuKdoXF1psjkQrAO9tQ61Y+R6F6q4gQH4ndxFOiQCOwAs++A== X-Received: by 2002:a1c:2856:: with SMTP id o83mr11727937wmo.45.1547717774099; Thu, 17 Jan 2019 01:36:14 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h2sm87991994wrv.87.2019.01.17.01.36.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 01:36:13 -0800 (PST) Date: Thu, 17 Jan 2019 09:36:11 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20190117093611.yefkrgbl4wpbx4vf@bivouac.eciton.net> References: <20190116205059.3488-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190116205059.3488-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 09:36:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote: > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console > if available") added calls to AsciiPrint() to the default exception > handler code, but the ARM version did not include UefiLib.h yet > (even though the .INF declares it unconditionally), resulting in > build breakage. So add the missing include. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > index 2e0cfb2d4e03..476ec2061084 100644 > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > #include > > -- > 2.17.1 >