From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82B0321B02822 for ; Thu, 17 Jan 2019 01:50:19 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id c14so10284264wrr.0 for ; Thu, 17 Jan 2019 01:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PXmOhqv+Cc3HINHQbW4U6H6m1hntxXZn6QHvhFlNauY=; b=BfeiKHsEwTduysAHVaVAo0KwPhJiQZUOrEMylXBesy6TUJVIImT/eQqWC1LfoCo4D8 VERac1aeoT793gS46Xzr/BdG2+etQLnNpCOOWu46UpsBm6K9tVVwJ2bF/DxJEhwezYL6 czqm4+3MKYnpIEK361uk3uKQQQov++FNY86r0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PXmOhqv+Cc3HINHQbW4U6H6m1hntxXZn6QHvhFlNauY=; b=nALnKnN6Zon6Exun5rEqB/vF+sWWBTOE4PdAcGCSxHK0U+VTaDfW9oI7kQPxw5CsJS cN+CAkUg7YcQFmaCKhLW2pq9BiQZSIbC4l88sLGdQ6mj/oXcBLgEBcHYE7FbXaoWI63Z i6w37qE0yJw2zhrwoxiXGlj8DsAIG9mIVSHogTj56PbckS5E0Q4tVNu3bopbsnz/N0Jv KJUrN3HOA4Boz4FBGKbY4XIYwO+ce1vaeEwZYu6fmMMNfj68izoa80OFidPLV6D5mGxP /rYX0PhbsP+1JUMSFyZlto9ZDwjmRJdcLPlwnBqjMmYntjsytRGEbPPbXUTtKj5WKPDb 4+5g== X-Gm-Message-State: AJcUukeLQeRool08VbHzkV1r9rLbDCjZ2h+GUNV1UaN5kEf75oCHsk+0 DgMlt03aiYQ/Zu6rQT61DkZdNg== X-Google-Smtp-Source: ALg8bN47bc8weEK1NywJSNstkkjtK+R06jMyIeYqLBMoOs/953FXGZPxSV49bZrtapUjTNk0Fn7GMA== X-Received: by 2002:adf:81c6:: with SMTP id 64mr11734068wra.186.1547718617715; Thu, 17 Jan 2019 01:50:17 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x15sm86535018wrs.27.2019.01.17.01.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 01:50:16 -0800 (PST) Date: Thu, 17 Jan 2019 09:50:15 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Masahisa Kojima Message-ID: <20190117095015.mtmoazzmvfrkvz6p@bivouac.eciton.net> References: <20190104144336.8941-1-ard.biesheuvel@linaro.org> <20190104144336.8941-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190104144336.8941-2-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 1/7] Silicon/SynQuacer/Fip006Dxe: drop block I/O and disk I/O routines X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 09:50:19 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 04, 2019 at 03:43:30PM +0100, Ard Biesheuvel wrote: > The FIP006 NOR flash driver contains implementations of the block I/O > and disk I/O protocols, but never exposes them to other drivers (i.e., > it never installs the protocol interfaces). So let's drop this code > altogether: the NOR flash is for code and variables, not for arbitrary > files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Feel free to push this one in isolation - it's a useful improvement anyway, may prevent someone from getting unfortunate ideas.... > --- > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf | 3 - > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashBlockIoDxe.c | 138 ------------ > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c | 229 ++------------------ > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h | 51 +---- > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c | 40 ++-- > 5 files changed, 37 insertions(+), 424 deletions(-)