From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C91B421962301 for ; Thu, 17 Jan 2019 03:05:00 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id q18so10480416wrx.9 for ; Thu, 17 Jan 2019 03:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=emZgLWJ8zX4xGcdfytP6nVLUEjbVj2cgiPU089Uw35A=; b=JuanKb6IMp5GjZeH1h6IObvOp5AqU9ooZZnprpvYtCimsUMUzCZqiOXJNEgC3Nsn3B R5O38yAc8MuW+8tpXjLnyTqy+uTvK+Nd++6xNUxGeWKocSsVVa752z2rgqOdFqCyOwRf 3r7QmdVIZyLwUgcphQ/IZeH81UmAtaNXFrx+Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=emZgLWJ8zX4xGcdfytP6nVLUEjbVj2cgiPU089Uw35A=; b=H/dD7IA/0V8vTR8FClnCCuybHm+064rxhUtdJWAYW2k4/33rZ3CWobpTKE98JAt5h+ XR+IwKWPipG0PFhgJlKZAEZLkyOfKMiq4VS4uJG/eBbp+thsT7Agv+5+WUHnG3F/hLgX xnrbYHBg5JME5YXVmiloOpY2Cnj4xqAyjtQO2pIT+m5niU+iv7xLsdEVpsYOEpZ/zCYA mk4Q//tz7+Ibd7TrydVArahrAwlOi3+JN+WgvwE7pZft0p0si395ipkc3cznT0eUxqwf I9aVQnLD7KBnloZVpNeAXl/qJuiUU+G/KlYYtZWTqLea98ATNOutjFP++WaT7XYwr6F4 +DQQ== X-Gm-Message-State: AJcUukeAcvx6SbAbyQt26tsMSz55YfarV0VGq0oEW74mFgpDB+EQstkp XRJ4PbFRSvL1ShnbLwQOLl0BYB6hWaU= X-Google-Smtp-Source: ALg8bN421MFN+qzhAR3BSm8FOcyMNSsMsf2oaQwpmFGdOHBJxfUZy1/vCuj5szfMy/d8mnhN91ifyg== X-Received: by 2002:adf:e846:: with SMTP id d6mr11811637wrn.72.1547723099139; Thu, 17 Jan 2019 03:04:59 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a62sm30574847wmf.47.2019.01.17.03.04.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 03:04:58 -0800 (PST) Date: Thu, 17 Jan 2019 11:04:56 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Masahisa Kojima Message-ID: <20190117110456.z22z2udhnbza3liy@bivouac.eciton.net> References: <20190104144336.8941-1-ard.biesheuvel@linaro.org> <20190104144336.8941-7-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190104144336.8941-7-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 6/7] Platform/DeveloperBox: add .DSC/.FDF description of MM components X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 11:05:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 04, 2019 at 03:43:35PM +0100, Ard Biesheuvel wrote: > Create a pair of .DSC/.FDF files that describe the components and > the firmware volumes and flash device that will be dispatched into > a secure partition in the secure world to control the UEFI secure > variable store. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 5 +- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 7 +- > Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc | 103 +++++++++++++ > Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 161 ++++++++++++++++++++ > 4 files changed, 270 insertions(+), 6 deletions(-) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 56787a744157..666bd2716336 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -250,10 +250,7 @@ [Components.common] > # > # Variable services > # > - Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf { > - > - NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf > - } > + Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > index 56adc21d5caf..87b2094cb356 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > @@ -125,6 +125,7 @@ [LibraryClasses.common] > PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > + NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf > > ################################################################################ > # > @@ -294,8 +295,10 @@ [PcdsFixedAtBuild.common] > !endif > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision|$(BUILD_NUMBER) > > - gArmTokenSpaceGuid.PcdMmBufferBase|0xFFC00000 > - gArmTokenSpaceGuid.PcdMmBufferSize|0x00200000 > + gEfiSecurityPkgTokenSpaceGuid.PcdUserPhysicalPresence|TRUE So, I can see why you add this hard-wired for the purpose of testing. But please, add a *very* conspicuous, and strongly worded, comment statement preceding it. > + > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > > [PcdsPatchableInModule] > gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|0