public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, Masahisa Kojima <masahisa.kojima@linaro.org>
Subject: Re: [PATCH edk2-platforms 0/7] Silicon/SynQuacer: implement SMM based secure boot
Date: Thu, 17 Jan 2019 11:14:22 +0000	[thread overview]
Message-ID: <20190117111422.yuwqcz6ogoah462k@bivouac.eciton.net> (raw)
In-Reply-To: <20190104144336.8941-1-ard.biesheuvel@linaro.org>

On Fri, Jan 04, 2019 at 03:43:29PM +0100, Ard Biesheuvel wrote:
> Wire up the various pieces so that the authenticated variable store
> runs entirely in standalone MM context residing in a secure partition.
> 
> This primarily involves refactoring the platform's NOR flash driver so
> we can build a version that can work in the standalone MM context.
> Beyond that, it is just a matter of enabling all the boilerplate in
> the .DSC and .FDF files.
> 
> Note that the resulting standalone MM firmware volume needs to be
> wrapped in a FIP, which is not part of the build sequence.
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Masahisa Kojima <masahisa.kojima@linaro.org>
> 
> Ard Biesheuvel (7):
>   Silicon/SynQuacer/Fip006Dxe: drop block I/O and disk I/O routines
>   Silicon/SynQuacer/Fip006Dxe: factor out DXE specific pieces
>   Silicon/SynQuacer/Fip006Dxe: implement standalone MM variant
>   Silicon/SynQuacer/Fip006Dxe: use proper accessor for unaligned access
>   Platform/DeveloperBox: create shared .DSC include file
>   Platform/DeveloperBox: add .DSC/.FDF description of MM components
>   Platform/DeveloperBox: add MM based UEFI secure boot support

For the patches I haven't commented on individually:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  .../Socionext/DeveloperBox/DeveloperBox.dsc   |  304 +---
>  .../DeveloperBox/DeveloperBox.dsc.inc         |  315 ++++
>  .../Socionext/DeveloperBox/DeveloperBox.fdf   |   13 +
>  .../Socionext/DeveloperBox/DeveloperBoxMm.dsc |  103 ++
>  .../Socionext/DeveloperBox/DeveloperBoxMm.fdf |  161 ++
>  .../SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf |    9 +-
>  .../Drivers/Fip006Dxe/Fip006StandaloneMm.inf  |   71 +
>  .../SynQuacer/Drivers/Fip006Dxe/NorFlash.c    | 1006 +++++++++++++
>  .../Fip006Dxe/{NorFlashDxe.h => NorFlash.h}   |   93 +-
>  .../Drivers/Fip006Dxe/NorFlashBlockIoDxe.c    |  138 --
>  .../SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c | 1341 ++---------------
>  .../{NorFlashFvbDxe.c => NorFlashFvb.c}       |  197 +--
>  .../SynQuacer/Drivers/Fip006Dxe/NorFlashSmm.c |  182 +++
>  13 files changed, 2076 insertions(+), 1857 deletions(-)
>  create mode 100644 Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>  create mode 100644 Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc
>  create mode 100644 Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf
>  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006StandaloneMm.inf
>  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.c
>  rename Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/{NorFlashDxe.h => NorFlash.h} (85%)
>  delete mode 100644 Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashBlockIoDxe.c
>  rename Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/{NorFlashFvbDxe.c => NorFlashFvb.c} (76%)
>  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashSmm.c
> 
> -- 
> 2.17.1
> 


  parent reply	other threads:[~2019-01-17 11:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 14:43 [PATCH edk2-platforms 0/7] Silicon/SynQuacer: implement SMM based secure boot Ard Biesheuvel
2019-01-04 14:43 ` [PATCH edk2-platforms 1/7] Silicon/SynQuacer/Fip006Dxe: drop block I/O and disk I/O routines Ard Biesheuvel
2019-01-17  9:50   ` Leif Lindholm
2019-01-17 10:59     ` Ard Biesheuvel
2019-01-04 14:43 ` [PATCH edk2-platforms 2/7] Silicon/SynQuacer/Fip006Dxe: factor out DXE specific pieces Ard Biesheuvel
2019-01-17 10:10   ` Leif Lindholm
2019-01-17 11:27     ` Ard Biesheuvel
2019-01-21 16:16       ` Ard Biesheuvel
2019-01-21 16:46         ` Leif Lindholm
2019-01-21 16:47           ` Ard Biesheuvel
2019-01-21 16:53             ` Leif Lindholm
2019-01-04 14:43 ` [PATCH edk2-platforms 3/7] Silicon/SynQuacer/Fip006Dxe: implement standalone MM variant Ard Biesheuvel
2019-01-04 14:43 ` [PATCH edk2-platforms 4/7] Silicon/SynQuacer/Fip006Dxe: use proper accessor for unaligned access Ard Biesheuvel
2019-01-04 14:43 ` [PATCH edk2-platforms 5/7] Platform/DeveloperBox: create shared .DSC include file Ard Biesheuvel
2019-01-04 14:43 ` [PATCH edk2-platforms 6/7] Platform/DeveloperBox: add .DSC/.FDF description of MM components Ard Biesheuvel
2019-01-17 11:04   ` Leif Lindholm
2019-01-17 11:10     ` Ard Biesheuvel
2019-01-17 12:08       ` Leif Lindholm
2019-01-17 12:18         ` Ard Biesheuvel
2019-01-21 16:57           ` Ard Biesheuvel
2019-01-21 17:03             ` Leif Lindholm
2019-01-04 14:43 ` [PATCH edk2-platforms 7/7] Platform/DeveloperBox: add MM based UEFI secure boot support Ard Biesheuvel
2019-01-17 11:14 ` Leif Lindholm [this message]
2019-01-21 17:40   ` [PATCH edk2-platforms 0/7] Silicon/SynQuacer: implement SMM based secure boot Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117111422.yuwqcz6ogoah462k@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox