From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 57DC021962301 for ; Thu, 17 Jan 2019 03:50:34 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id b11so755978wmj.1 for ; Thu, 17 Jan 2019 03:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q8DIra/LJc5HbUgmHQ4rqW3ugb7kDkt6FoBzlLOx9HQ=; b=URFrW+SUgSOM0tOxDxFeQnQBKvVznZlpIsiwuynWubppIsMpnD2L7+Nz4nAKfYxr25 T9Ub1XAfkl6caLfTozLoQiFAWJcb+MUIRcqnRvdfxNeLZr/hGZ/xVxYYHNoRpzJArcg5 y4CJ6y8iFMRfOYXCygbCsmI3LhtXkN3hjeq/U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q8DIra/LJc5HbUgmHQ4rqW3ugb7kDkt6FoBzlLOx9HQ=; b=I96FNwhuPkpVP/o1zhor75WvW/84O3NdxrhZdj2BC2AzACS3bnp7/YRQVhcBpaGEzD +zbVuKALisE/T90oAfhneqfULb/gi3FTS46OsNt83HDIc/UMzNAvBsW6c3/zJwlQOCn6 tKhQiIwue1l+pMsmmcHYiSiX9cOHGFF7suqwJr7MIXVFrpls0BrNAgebd6GTA5YUA4Di Pql5NAr/9X/2iiugvlHQSa+bvjiWNgFeWIBG3imNzzXwDdNOxby4vc+nN0B5j5kxqAkN rudz1LyzKS/LSdby8SQ1K4k+RCFfIg8702OSmkx/RnpGBLv4/9QkX7ue+QPrYEtOfj7A GLGQ== X-Gm-Message-State: AJcUukdqqrSOoMB3YC0CEnMLrxb1thqV5ZY+LuCYsczLea/mRNDs3ow3 4Q3b5BUApn3TdqloqcwReziKbg== X-Google-Smtp-Source: ALg8bN4iLudIDgH0Ph/eTgpU/6qheVtVQ6RKWwYSDlO/kN4Rkm0Q/xfUmoQh4IQUOahjza/sPKwZrA== X-Received: by 2002:a1c:e383:: with SMTP id a125mr2974620wmh.1.1547725833414; Thu, 17 Jan 2019 03:50:33 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j124sm27103788wmb.48.2019.01.17.03.50.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 03:50:32 -0800 (PST) Date: Thu, 17 Jan 2019 11:50:25 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Message-ID: <20190117115025.na2m5osctpqikmt5@bivouac.eciton.net> References: <1547723715-4562-1-git-send-email-mw@semihalf.com> <1547723715-4562-8-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1547723715-4562-8-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v3 07/12] Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 11:50:35 -0000 X-List-Received-Date: Thu, 17 Jan 2019 11:50:35 -0000 X-List-Received-Date: Thu, 17 Jan 2019 11:50:35 -0000 X-List-Received-Date: Thu, 17 Jan 2019 11:50:35 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 17, 2019 at 12:15:10PM +0100, Marcin Wojtas wrote: > Introduce new callback that can provide information > about GPIO SoC controllers, as well as on-board > I2C IO expanders. According ArmadaSoCDescLib > ArmadaBoardDescLib routines are used for > obtaining required data. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Silicon/Marvell/Include/Protocol/BoardDesc.h | 8 ++++ > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 50 ++++++++++++++++++++ > 2 files changed, 58 insertions(+) > > diff --git a/Silicon/Marvell/Include/Protocol/BoardDesc.h b/Silicon/Marvell/Include/Protocol/BoardDesc.h > index 1d57a16..02905ea 100644 > --- a/Silicon/Marvell/Include/Protocol/BoardDesc.h > +++ b/Silicon/Marvell/Include/Protocol/BoardDesc.h > @@ -50,6 +50,13 @@ EFI_STATUS > > typedef > EFI_STATUS > +(EFIAPI *MV_BOARD_GPIO_DESCRIPTION_GET) ( > + IN MARVELL_BOARD_DESC_PROTOCOL *This, > + IN OUT MV_BOARD_GPIO_DESCRIPTION **GpioDescription > + ); > + > +typedef > +EFI_STATUS > (EFIAPI *MV_BOARD_DESC_I2C_GET) ( > IN MARVELL_BOARD_DESC_PROTOCOL *This, > IN OUT MV_BOARD_I2C_DESC **I2cDesc > @@ -113,6 +120,7 @@ struct _MARVELL_BOARD_DESC_PROTOCOL { > MV_BOARD_DESC_UTMI_GET BoardDescUtmiGet; > MV_BOARD_DESC_XHCI_GET BoardDescXhciGet; > MV_BOARD_DESC_FREE BoardDescFree; > + MV_BOARD_GPIO_DESCRIPTION_GET GpioDescriptionGet; > }; > > #endif // __MARVELL_BOARD_DESC_PROTOCOL_H__ > diff --git a/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c b/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > index f71bfc4..973c362 100644 > --- a/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > +++ b/Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > @@ -35,6 +35,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > MV_BOARD_DESC *mBoardDescInstance; > > +STATIC MV_BOARD_GPIO_DESCRIPTION *mGpioDescription; > + > STATIC > EFI_STATUS > MvBoardDescComPhyGet ( > @@ -100,6 +102,53 @@ MvBoardDescComPhyGet ( > > STATIC > EFI_STATUS > +MvBoardGpioDescriptionGet ( > + IN MARVELL_BOARD_DESC_PROTOCOL *This, > + IN OUT MV_BOARD_GPIO_DESCRIPTION **GpioDescription > + ) > +{ > + UINTN SoCGpioCount, GpioExpanderCount; > + MV_GPIO_EXPANDER *GpioExpanders; > + GPIO_CONTROLLER *SoCGpio; > + EFI_STATUS Status; > + > + /* Use existing structure if already created. */ > + if (mGpioDescription != NULL) { > + *GpioDescription = mGpioDescription; > + return EFI_SUCCESS; > + } > + > + /* Get SoC data about all available GPIO controllers. */ > + Status = ArmadaSoCGpioGet (&SoCGpio, &SoCGpioCount); > + if (EFI_ERROR (Status)) { > + return Status; > + } > + > + /* Get per-board information about all available GPIO expanders. */ > + Status = ArmadaBoardGpioExpanderGet (&GpioExpanders, &GpioExpanderCount); > + if (EFI_ERROR (Status)) { > + return Status; > + } > + > + /* Allocate and fill board description. */ > + mGpioDescription = AllocateZeroPool (sizeof (MV_BOARD_GPIO_DESCRIPTION)); > + if (mGpioDescription == NULL) { > + DEBUG ((DEBUG_ERROR, "%a: Cannot allocate memory\n", __FUNCTION__)); > + return EFI_OUT_OF_RESOURCES; > + } > + > + mGpioDescription->SoCGpio = SoCGpio; > + mGpioDescription->GpioDeviceCount = SoCGpioCount; > + mGpioDescription->GpioExpanders = GpioExpanders; > + mGpioDescription->GpioExpanderCount = GpioExpanderCount; > + > + *GpioDescription = mGpioDescription; > + > + return EFI_SUCCESS; > +} > + > +STATIC > +EFI_STATUS > MvBoardDescI2cGet ( > IN MARVELL_BOARD_DESC_PROTOCOL *This, > IN OUT MV_BOARD_I2C_DESC **I2cDesc > @@ -571,6 +620,7 @@ MvBoardDescInitProtocol ( > BoardDescProtocol->BoardDescUtmiGet = MvBoardDescUtmiGet; > BoardDescProtocol->BoardDescXhciGet = MvBoardDescXhciGet; > BoardDescProtocol->BoardDescFree = MvBoardDescFree; > + BoardDescProtocol->GpioDescriptionGet = MvBoardGpioDescriptionGet; > > return EFI_SUCCESS; > } > -- > 2.7.4 >