From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C7FE8211B7361 for ; Thu, 17 Jan 2019 04:04:00 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id b11so799902wmj.1 for ; Thu, 17 Jan 2019 04:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iGsPhbAoCIeeJXEPgyY95dkoXoeh3CZohsdztSleeN0=; b=ISx2yWPJtErR+vxG3y6pqgQDI2cRYvxNQL8r5bEZoTn8+unh17Mgn/XtLAbfZxAple YZib3xTc8SJtLl2i01DmVlN3YETot4AhXQuB5JDJ4lyDVvz00sq44VdTJ9LzOKeC32gw culAywryoY+OjR61nBZOtH3SoDKkpW0+9obkE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iGsPhbAoCIeeJXEPgyY95dkoXoeh3CZohsdztSleeN0=; b=t5SwiMgaqfjFEEPun3nF60mT3rPV9UbuZdGUq8jvMcXHXRsxzMalxoD/Z95kjb6/+Q JFI3tXngdQuvqhSBTw4sj3a/8dWaVCwmHNQGvQBquXwPpLl7uxpsEO432zDzMYJvE5vT qV8LOLrptD9qXF1hqFMUqx3467+63XwxKwVV7x3dsywAOs1CB2UyS8zvEvpzdJmjxIf1 +Bk6Z3dZ4JOxaTxJec2HJUOjQIyxUKc25VUxoHPoIqRnX7Zt025TN1aMJnJ4MrlxmF+o O3S2kbGp1LrfoSSKYYO5ilj9vMUAkbiCp1RnEZJXJlNRSDiVy+thNaTs/E5UUDWiQBrr 80qA== X-Gm-Message-State: AJcUukdEq54eRsamOvBSKhTv27u4Geh3xbPPLuvaDHWOaCLv0Pgwm8qU pc4YNVTnta3ITNl74H95rVgBlg== X-Google-Smtp-Source: ALg8bN50Hf+s7dLt7Fs4i8fuCSiIc8bH0Ibvqd2pDFxjIiVGQEhb9WuxdizVxnqUEnKzN6oYW5W7KQ== X-Received: by 2002:a1c:19c2:: with SMTP id 185mr11846994wmz.8.1547726639062; Thu, 17 Jan 2019 04:03:59 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r77sm50157306wmd.22.2019.01.17.04.03.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 04:03:58 -0800 (PST) Date: Thu, 17 Jan 2019 12:03:56 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Message-ID: <20190117120356.wabcsghw2tfu5qra@bivouac.eciton.net> References: <1547723715-4562-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1547723715-4562-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v3 00/12] Armada 7k8k GPIO support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 12:04:01 -0000 X-List-Received-Date: Thu, 17 Jan 2019 12:04:01 -0000 X-List-Received-Date: Thu, 17 Jan 2019 12:04:01 -0000 X-List-Received-Date: Thu, 17 Jan 2019 12:04:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline So, I was about to say that apart from the "class" to be deleted from 3/12 subject line, things were fine so I was going to fix that locally and push. However. 3/12 is missing the Contributed-under tag. Can you please separately confirm that it is intended to be contributed under TianoCore Contribution Agreement 1.1? / Leif On Thu, Jan 17, 2019 at 12:15:03PM +0100, Marcin Wojtas wrote: > Hi, > > I submit v3 of the GPIO patchset for the Marvell SoCs. > The changes are not significant and they address all the comments > from the previous version. Please find the details in the changelog > below. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/gpio-upstream-r20190117 > > I am looking forward to your feedback. > > Best regards, > Marcin > > Changelog: > v2->v3: > * 1,2,4,12/12 > - Add Leif's RB > > * 3/12 > - Change MvGpio.h to be library header (Library/MvGpioLib.h) > - Introduce MvGpioLib library > - Add PCA_ID enums in this patch (instead from PCA9xxx addition) > > * 5,6/12 > - Use PCA_ID enum from the beginning > > * 7/12 > - Use static global variable and allocate it only only once > - s/I2C/GPIO/ > > * 8/12 > - Simplify error path after changing approach to not freeing > already allocated GpioDescription in MvBoardDescDxe > - Change signature to non-generic > > * 10/12 > - Simplify error path after changing approach to not freeing > already allocated GpioDescription in MvBoardDescDxe > - No need to update PCA_ID in this patch > > v1->v2: > * All > - rebase on top of the master branch and Xenon changes > > * 1/12 > - s/AP/AP806/ in order to avoid confusion > - drop desc/DESC usage and improve variables naming > - use GPIO_CONTROLLER from EmbeddedGpio.h instead of custom MV_SOC_GPIO > - update commit message > > * 2,3,4,5/12 > - drop desc/DESC usage and improve variables naming > - drop reference to I2c and use GpioExpander > - improve commit logs > > * 6/12 > - drop desc/DESC usage and improve variables naming > - drop reference to I2c and use GpioExpander > - remove global variable - same as for other interfaces the consumer > is responsible for avoiding memory leak > > * 7/12 > - use MV_GPIO_ prefix > - switch to EMBEDDED_GPIO > - remove custom Marvell GPIO Protocol and types > - add subroutine to MvGpioGetProtocol and more coments to clarify the code > - add driver types and related enums in other commits > > * 8/12 > - extend error path in the entry point, rename variables > - use MV_GPIO_ prefix > - switch to EMBEDDED_GPIO > - remove custom Marvell GPIO Protocol and types > - replace '!!' expression for obtaining pin state > - remove BIT() macro > - use generic mDevicePathTemplate name > - put validate function under '#if !defined(MDEPKG_NDEBUG)' and > call from inside ASSERT_EFI_ERROR, add comment > - update commit message > - add common enum for describing controllers > - change authorship > > - 9/12 > - Add Leif's RB > > * 10/12 > - same modifications as 8/12 > - use I2C flags directly and remove PCA95XX_OPERATION enum > - add common enum for describing controllers > > * 11/12 > - Add Leif's RB > > * 12/12 > - Add local headers > - Make STATIC names more generic > - s/GetInitializerForType/NonDiscoverableDeviceInitializerGet/ > - Use global enum for McBin GPIO controller > > > Marcin Wojtas (12): > Marvell/Library: ArmadaSoCDescLib: Add GPIO information > Marvell/Library: ArmadaBoardDescLib: Add GPIO information > Marvell/Library: Introduce MvGpioLib class > SolidRun/Armada80x0McBin: Extend board description library with GPIO > Marvell/Armada70x0Db: Extend board description library with GPIO > Marvell/Armada80x0Db: Extend board description library with GPIO > Marvell/Drivers: MvBoardDesc: Extend protocol with GPIO support > Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver > Marvell/Drivers: I2c: Use common header for macros > Marvell/Drivers: MvPca95xxDxe: Introduce GPIO expander driver > Marvell/Armada7k8k: Enable GPIO drivers compilation > Marvell/Armada7k8k: Introduce NonDiscoverable device init routines > > Silicon/Marvell/Marvell.dec | 2 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 + > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 7 +- > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 + > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 3 + > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.inf | 1 + > Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.inf | 49 ++ > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf | 1 + > Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.inf | 50 ++ > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf | 1 + > Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.inf | 50 ++ > Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.inf | 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 1 + > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1 + > Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.inf | 44 ++ > Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.inf | 45 ++ > Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf | 1 + > Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.inf | 1 + > Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.inf | 1 + > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonDxe.inf | 1 + > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 1 + > Silicon/Marvell/Library/IcuLib/IcuLib.inf | 1 + > Silicon/Marvell/Library/MvGpioLib/MvGpioLib.inf | 32 + > Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 1 + > Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.h | 23 + > Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.h | 28 + > Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.h | 20 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 10 + > Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.h | 49 ++ > Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.h | 65 ++ > Silicon/Marvell/Drivers/I2c/MvEepromDxe/MvEepromDxe.h | 10 - > Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.h | 17 +- > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 23 + > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 12 + > Silicon/Marvell/Include/Library/MvGpioLib.h | 68 +++ > Silicon/Marvell/Include/Library/NonDiscoverableInitLib.h | 28 + > Silicon/Marvell/Include/Protocol/BoardDesc.h | 8 + > Silicon/Marvell/Include/Protocol/MvI2c.h | 31 + > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c | 24 + > Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 96 +++ > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 30 + > Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 106 ++++ > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 17 + > Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 71 +++ > Silicon/Marvell/Applications/EepromCmd/EepromCmd.c | 5 +- > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 39 ++ > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 50 ++ > Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.c | 353 +++++++++++ > Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.c | 645 ++++++++++++++++++++ > Silicon/Marvell/Drivers/I2c/MvEepromDxe/MvEepromDxe.c | 3 +- > Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 4 +- > Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c | 13 +- > Silicon/Marvell/Library/MvGpioLib/MvGpioLib.c | 132 ++++ > Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf.inc | 2 + > Platform/Marvell/Armada80x0Db/Armada80x0Db.fdf.inc | 2 + > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.fdf.inc | 2 + > 56 files changed, 2249 insertions(+), 38 deletions(-) > create mode 100644 Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.inf > create mode 100644 Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.inf > create mode 100644 Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.inf > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.inf > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.inf > create mode 100644 Silicon/Marvell/Library/MvGpioLib/MvGpioLib.inf > create mode 100644 Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.h > create mode 100644 Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.h > create mode 100644 Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.h > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.h > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.h > create mode 100644 Silicon/Marvell/Include/Library/MvGpioLib.h > create mode 100644 Silicon/Marvell/Include/Library/NonDiscoverableInitLib.h > create mode 100644 Silicon/Marvell/Include/Protocol/MvI2c.h > create mode 100644 Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c > create mode 100644 Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c > create mode 100644 Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.c > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvGpioDxe/MvGpioDxe.c > create mode 100644 Silicon/Marvell/Drivers/Gpio/MvPca95xxDxe/MvPca95xxDxe.c > create mode 100644 Silicon/Marvell/Library/MvGpioLib/MvGpioLib.c > > -- > 2.7.4 >