From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC37521959CB2 for ; Mon, 21 Jan 2019 07:44:18 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id n190so11284149wmd.0 for ; Mon, 21 Jan 2019 07:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=/qnn+4EhFT9KYQ9KH0A/MXCVadigvSsJRDxW7/d/O9I=; b=JIr7ydtN7PRxzRyDYIxZXS49a4SoZVRvzapIPN1wnc0BN4+6FlyqRV4m4r3gakUvTS wvLzT1iPohLGG1LOr4dR++6wjR6HB5qQDMZjj8ffYwxoEuNLvBdfH0BFD40fIZpeg/iL 3jmkWp7M9cQvHDErwnYyq2tIDDoKjZYUmPDvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=/qnn+4EhFT9KYQ9KH0A/MXCVadigvSsJRDxW7/d/O9I=; b=OTfixrWnCJ7BAylL1u170/l3F0ND6Pe8kJGLV8bSy0pNeq49+XdV9eXzk719Z6iorK tG+oc3JGz0N72n7E/QqtWC018VDr72OkkKvDzdn31mHlbgFKiET0AgMi7qSM3bv/2Lz0 I5YQJ/6aisrIEq7Cjl40dMT9anRXlSaz2UKMRTSPphKNS1ClyxmqMM7jpMxaFyuI/Z64 L1SoXhq1ujDcDQDevT0baPDsb1i1MBwigenW5lR8LwNh5qoPQ4Lbc5W6koZXSk079HYV 5v2UWgYenRH/u3h2w11K9gNziDZfS8cdgmeZrn0psMsWPT05G0zGnabA8ZUJ/1T4g9mO H68g== X-Gm-Message-State: AJcUukcssMfaAHyecnLapo9eVA4BA0z8E+zBPYeQVWtHsq7Mp7gkm/sI CgGaRKyBfAE0oPXGsOkd/FAmGQ== X-Google-Smtp-Source: ALg8bN54wlP3dhkSWvxMZR+2Il2ZN71p2GKbAOBOiiqdQlypbM0G/3CSoW4sxYkxaLZLPpX64VAIbg== X-Received: by 2002:a1c:a70a:: with SMTP id q10mr23719598wme.58.1548085456738; Mon, 21 Jan 2019 07:44:16 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s1sm137375606wro.9.2019.01.21.07.44.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 07:44:15 -0800 (PST) Date: Mon, 21 Jan 2019 15:44:14 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Message-ID: <20190121154414.iqf24jywnkmyfiey@bivouac.eciton.net> References: <1548067931-18618-1-git-send-email-mw@semihalf.com> <1548067931-18618-2-git-send-email-mw@semihalf.com> <20190121112609.ahwajugww4426avx@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 1/3] Marvell: Armada7k8k: Shift PEI stack base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 X-List-Received-Date: Mon, 21 Jan 2019 15:44:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jan 21, 2019 at 04:34:39PM +0100, Marcin Wojtas wrote: > Hi Leif, > > > pon., 21 sty 2019 o 12:26 Leif Lindholm napisał(a): > > > > On Mon, Jan 21, 2019 at 11:52:09AM +0100, Marcin Wojtas wrote: > > > Recent changes in the ARM-TF configure its runtime serices region > > > as protected, hence the hitherto PEI stack base address (0x41F0000) > > > violated it. > > > > > > In order to fix this, extend the region which is non-accessible > > > by the OS to cover both the ARM-TF (0x4000000 - 0x4200000) and OPTEE > > > (0x4400000 - 0x5400000) within a single area and set the PEI stack > > > > What is the single area? > > The single region is set to: > 0x4000000 - 0x5400000 > > PEI stack base is shifted right below the OPTEE region, i.e. to: > 0x43F0000 > > Do you wish to add above to the commit message as well? Yes please. Best Regards, Leif > Best regards, > Marcin > > > > > > base address between both images. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Marcin Wojtas > > > --- > > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > > index eafcd6e..c8c597f 100644 > > > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > > @@ -376,12 +376,12 @@ > > > > > > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|36 > > > > > > - gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x41F0000 > > > + gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x43F0000 > > > gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x10000 > > > > > > # Secure region reservation > > > gMarvellTokenSpaceGuid.PcdSecureRegionBase|0x4000000 > > > - gMarvellTokenSpaceGuid.PcdSecureRegionSize|0x0200000 > > > + gMarvellTokenSpaceGuid.PcdSecureRegionSize|0x1400000 > > > > > > # TRNG > > > gMarvellTokenSpaceGuid.PcdEip76TrngBaseAddress|0xF2760000 > > > -- > > > 2.7.4 > > >