From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 91312211B737C for ; Mon, 21 Jan 2019 08:46:45 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id p4so24174414wrt.7 for ; Mon, 21 Jan 2019 08:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2UxgLz2IbKQ3fM99sz+oOZMF2k5hNmgEK9YRkHTag6Q=; b=fFRyV7IzohlPVTe/rVvCb0Scb5aeXR4tCFndG5PwO+PjKjsdrJ2F9noly+45WG1zJj x4p5YIrV+AXeyVnkyQ4FRmEUIhlOsB7fLw60RnVtXq1K9dRJ6E1qbWsyjfaHdgnyN8HP 7i48+ytH3MS8C16HExohZ3lOiAcrtnb8FY3rs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2UxgLz2IbKQ3fM99sz+oOZMF2k5hNmgEK9YRkHTag6Q=; b=Q9/KEqzDcJPm3MdIdgdD9JycJ3duBmP5W4tjuwkR2+IsCLd7scNZOrQoO4pqw7z+Gx hZy/Nb0UapUvl8ZRedbYhvm55FBxgu5QgHnNmwGbMmN4uYKhrc+H6aZHbYaruXvTYC9y 3ZMFcN4wNxVTZxhpqlPzUsnUb3zRDEjYzh4afW3Hw4QH+p1GKVge2QI7iuL3sopcMJsx O+WkVdN8M4tdxIq4BlUCUinZ9rJZTsjo42AZac2RWlSO/C2pAqZ2sd4rKoxSQRQiAAwO ur4WusaSwHforqGG8JeDV/hX7Xd6wKFt+RKyfhSsKaeMfrOyoLF1DipdTbeIt69Chvdh TYWA== X-Gm-Message-State: AJcUukfM2HGW1Tpt7rUZk6B1umuVbDyoKAyX4n55UIz3/RS7BjAuOpu5 UC7QJKftMTJhQEsbnXydQ26AwA== X-Google-Smtp-Source: ALg8bN5/ZjV2OV5KDT3kM1tEEiZR2XKoZE6fQphMBCLVGnZlHQ2fttg7N3j0sVHlc34ZXipAFcPebg== X-Received: by 2002:a5d:448f:: with SMTP id j15mr26973489wrq.108.1548089203942; Mon, 21 Jan 2019 08:46:43 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u204sm80447729wmu.30.2019.01.21.08.46.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 08:46:43 -0800 (PST) Date: Mon, 21 Jan 2019 16:46:41 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Masahisa Kojima Message-ID: <20190121164641.5ig75gmrgw4rjnbe@bivouac.eciton.net> References: <20190104144336.8941-1-ard.biesheuvel@linaro.org> <20190104144336.8941-3-ard.biesheuvel@linaro.org> <20190117101000.hsesfat7kcie7yuu@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 2/7] Silicon/SynQuacer/Fip006Dxe: factor out DXE specific pieces X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 16:46:45 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 21, 2019 at 05:16:09PM +0100, Ard Biesheuvel wrote: > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > similarity index 88% > > > > rename from Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h > > > > rename to Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > index 20e74b0320ce..61b8e6a08fa0 100644 > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h > > > > +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > @@ -27,11 +27,9 @@ > > > > #include > > > > > > > > #include > > > > -#include > > > > #include > > > > +#include > > > > > > Why add this include? > > > I'm not going to ask to move out the existing headers not actually > > > used by this file, but could we avoid adding new ones? > > > > > > https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/v/release/2.20/5_source_files/53_include_files.html#534-include-files-may-include-only-those-headers-that-it-directly-depends-upon > > > is actually a rule I agree with. > > > > > > But also, aren't all of the users of this file already manually > > > including this one? > > > > > > > Fair enough. I will drop the include here, and add it to whichever > > source file requires it afterwards. > > > > That include turns out to be entirely redundant, so I will just drop it. Works for me. > > > > #include > > > > -#include > > > > -#include > > > > > > > > #include "Fip006Reg.h" > > > > > > > > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > index e52ab52d8cf7..6c07799b22d8 100644 > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > @@ -15,15 +15,16 @@ > > > > **/ > > > > > > > > #include > > > > +#include > > > > +#include > > > > #include > > > > > > At least this one does. > > > > > > > #include > > > > #include > > > > #include > > > > #include > > > > +#include > > > > > > > > -#include "NorFlashDxe.h" > > > > - > > > > -STATIC EFI_EVENT mNorFlashVirtualAddrChangeEvent; > > > > +#include "NorFlash.h"