From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EB49211B76A2 for ; Mon, 21 Jan 2019 08:53:20 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id 96so24245665wrb.2 for ; Mon, 21 Jan 2019 08:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3L/5CKePDhukUyDarqKff20xW1sxLF5UC/KD/tajYWQ=; b=EXPGFU3LI6PagTYKXgn3KJNWdIlTVq0w9IWTFGtaGhiC+2HPrUi7Q9NZ3cXlGy/GEF ZWmbmlYE0a9pFlPYzsT45s0whiq7onNgGvO9Dny04gUGYWXUB+NGgTcXzsX/y+PgKmGc az7QSJSMq8Ogho09SWcIez8aw7hCxwNjZgJqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3L/5CKePDhukUyDarqKff20xW1sxLF5UC/KD/tajYWQ=; b=jVA75rOx87NQreFXKfL58L4IwBUbYUuNoulT4J+cl3sbLnIugnpI7kxAEw4EMoael2 jJRvU08cs6zLnivSvIl+1vqJ/SxrpcKFvSuGLLXy9aFIQjHIprMqgB74HBEO9+473N/L BNyDCSIkiKZXhoB/ZWJF0kB3HWBJOwq51cKAQIzVV6Gc3iY4lLBEM8U/uTyM5PXZAWN3 yCphQR/IsytRYLPUutASRMCS61sFuto6LljAWILfUCrwp/m/Cl/OC9cdLNZq+lKLpnKk WuPih+BJo1JGp/0mlpA5HosqSO65Hk7uLFMaSv9Awnk+Qm2oy+eZ4LVbcZh9+TaKgCrP TGcw== X-Gm-Message-State: AJcUukfLdq3KdnpUwQa84hp3kYLLxBRvmr3VqGNLH0Yd7ROBS/bZHzZj I0aZ3c8foNXlLc1tea7rutNVEQ== X-Google-Smtp-Source: ALg8bN7quX/SGEqS7mKBRbyuCeppDyZ0eSTOy8i8kOeKLEdtbUGgquSUOw18fJI57b09cXUGWLwWtw== X-Received: by 2002:adf:f052:: with SMTP id t18mr30237358wro.112.1548089598619; Mon, 21 Jan 2019 08:53:18 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q9sm150423416wrp.0.2019.01.21.08.53.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 08:53:17 -0800 (PST) Date: Mon, 21 Jan 2019 16:53:16 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Masahisa Kojima Message-ID: <20190121165316.k6spjtbrtdtdhtkp@bivouac.eciton.net> References: <20190104144336.8941-1-ard.biesheuvel@linaro.org> <20190104144336.8941-3-ard.biesheuvel@linaro.org> <20190117101000.hsesfat7kcie7yuu@bivouac.eciton.net> <20190121164641.5ig75gmrgw4rjnbe@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 2/7] Silicon/SynQuacer/Fip006Dxe: factor out DXE specific pieces X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 16:53:20 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 21, 2019 at 05:47:10PM +0100, Ard Biesheuvel wrote: > On Mon, 21 Jan 2019 at 17:46, Leif Lindholm wrote: > > > > On Mon, Jan 21, 2019 at 05:16:09PM +0100, Ard Biesheuvel wrote: > > > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > > > similarity index 88% > > > > > > rename from Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h > > > > > > rename to Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > > > index 20e74b0320ce..61b8e6a08fa0 100644 > > > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h > > > > > > +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > > > @@ -27,11 +27,9 @@ > > > > > > #include > > > > > > > > > > > > #include > > > > > > -#include > > > > > > #include > > > > > > +#include > > > > > > > > > > Why add this include? > > > > > I'm not going to ask to move out the existing headers not actually > > > > > used by this file, but could we avoid adding new ones? > > > > > > > > > > https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/v/release/2.20/5_source_files/53_include_files.html#534-include-files-may-include-only-those-headers-that-it-directly-depends-upon > > > > > is actually a rule I agree with. > > > > > > > > > > But also, aren't all of the users of this file already manually > > > > > including this one? > > > > > > > > > > > > > Fair enough. I will drop the include here, and add it to whichever > > > > source file requires it afterwards. > > > > > > > > > > That include turns out to be entirely redundant, so I will just drop it. > > > > Works for me. > > > > Wonderful. Can I take that as an ack? Whoops. Yes. Acked-by: Leif Lindholm > > > > > > #include > > > > > > -#include > > > > > > -#include > > > > > > > > > > > > #include "Fip006Reg.h" > > > > > > > > > > > > > > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > > > index e52ab52d8cf7..6c07799b22d8 100644 > > > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > > > +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > > > @@ -15,15 +15,16 @@ > > > > > > **/ > > > > > > > > > > > > #include > > > > > > +#include > > > > > > +#include > > > > > > #include > > > > > > > > > > At least this one does. > > > > > > > > > > > #include > > > > > > #include > > > > > > #include > > > > > > #include > > > > > > +#include > > > > > > > > > > > > -#include "NorFlashDxe.h" > > > > > > - > > > > > > -STATIC EFI_EVENT mNorFlashVirtualAddrChangeEvent; > > > > > > +#include "NorFlash.h"