Re: [PATCH] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

[Leif Lindholm <leif.lindholm@linaro.org>]

Well, if we don't hear back, I can just commit it anyway before the
end of the week. One question/comment inline below:

On Tue, Jan 22, 2019 at 04:29:50AM +0000, Meenakshi Aggarwal wrote:
> Hi Jun, Haojian,
> 
> Please review the patch.
> 
> Thanks,
> Meenakshi
> 
> > -----Original Message-----
> > From: Leif Lindholm <leif.lindholm@linaro.org>
> > Sent: Thursday, January 17, 2019 4:54 PM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: ard.biesheuvel@linaro.org; edk2-devel@lists.01.org; Jun Nie
> > <jun.nie@linaro.org>; Haojian Zhuang <haojian.zhuang@linaro.org>
> > Subject: Re: [PATCH] SD/eMMC : Fix Command Argument for SD/eMMC R/W
> > operation.
> > 
> > Jun, Haojian - any comments?
> > 
> > On Wed, Jan 16, 2019 at 06:51:36PM +0530, Meenakshi Aggarwal wrote:
> > > Issue : SD read failure for high capacity cards e.g. 64 GB i Reason :
> > > Command argument value exceeds 32 bit for block number 0x3787FFF and
> > > cant be fit into 32 bit wide SD host controller register.
> > >
> > > Fix :
> > > AccessMode bits [29:30] of OCR is a valid definition to calculate data
> > > address for eMMC cards.
> > >
> > > For SD cards, data address is calculated on the basis of card capacity
> > > status bit[30] of OCR.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > > ---
> > >  EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 19 ++++++++++++++-----
> > >  1 file changed, 14 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> > > b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> > > index a2b9232..625a59e 100644
> > > --- a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> > > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> > > @@ -148,12 +148,21 @@ MmcTransferBlock (
> > >    MmcHostInstance = MMC_HOST_INSTANCE_FROM_BLOCK_IO_THIS (This);
> > >    MmcHost = MmcHostInstance->MmcHost;
> > >
> > > -  //Set command argument based on the card access mode (Byte mode or
> > > Block mode)
> > > -  if ((MmcHostInstance->CardInfo.OCRData.AccessMode &
> > MMC_OCR_ACCESS_MASK) ==
> > > -      MMC_OCR_ACCESS_SECTOR) {
> > > -    CmdArg = Lba;
> > > +  if (MmcHostInstance->CardInfo.CardType != EMMC_CARD) {
> > > +    //Set command argument based on the card capacity (SDSC or SDXC/SDHC)
> > > +    if (MmcHostInstance->CardInfo.OCRData.AccessMode & BIT1) {

What is BIT1? Can we add a #define for it?
(The comment _nearly_ but not quite explains it to me.)

/
    Leif

> > > +      CmdArg = Lba;
> > > +    } else {
> > > +      CmdArg = Lba * This->Media->BlockSize;
> > > +    }
> > >    } else {
> > > -    CmdArg = Lba * This->Media->BlockSize;
> > > +    //Set command argument based on the card access mode (Byte mode or
> > Block mode)
> > > +    if ((MmcHostInstance->CardInfo.OCRData.AccessMode &
> > MMC_OCR_ACCESS_MASK) ==
> > > +        MMC_OCR_ACCESS_SECTOR) {
> > > +      CmdArg = Lba;
> > > +    } else {
> > > +      CmdArg = Lba * This->Media->BlockSize;
> > > +    }
> > >    }
> > >
> > >    Status = MmcHost->SendCommand (MmcHost, Cmd, CmdArg);
> > > --
> > > 1.9.1
> > >