From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::535; helo=mail-pg1-x535.google.com; envelope-from=vladimir.olovyannikov@broadcom.com; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 469D6211B85C2 for ; Wed, 23 Jan 2019 10:27:36 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id n2so1446372pgm.3 for ; Wed, 23 Jan 2019 10:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yANljEzAdb5NtGVlG297dRWGANxlgOkq07gFs33D394=; b=Hcebc94Z+lnE5kGG5LcOZe5NKBnYigyvI8uZNBFCllri4C+juigQT0DwnVWLQdcKSC FD2ZAB/plOAWbITjc4V19w8SnzAaj1gbOxuoJRTcaaaKXr2O6S5TAarnPnB5FOQN2tj1 wdFS/vyNHOP7t4CVXPmq3DwxfsC3rijH2keUs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yANljEzAdb5NtGVlG297dRWGANxlgOkq07gFs33D394=; b=PQpXRrDX1VMr9syoxvWRqzTJEQQGcapMt+0V7g5PUBlDVcHt36/FQFHYO/3tO0ocND 5krr7mwyIFhectsiYHbgbKevaNXRSNAWs7/DDAnrMM9t7gEaCofxea8X1YwevHylfqzV XjN/OgXgWMsQCmXEympKP9Bt82rCB7bYm1RWm33f2XucZSH11lKVVNyX7jVD57Q3ady9 RyssRNBR3BVH8KIsjqZkRTYg8I1k6OF0rmEEoQUSDnRhOiQdUlNPLBko4vQ1oTnU7AEI kjw0/9OZ17Dpr1J5TXmT1QxPbvcNVrgoKNYTPGoVeexwfbZ4Kiz7JrD9yQ5zU9Uo4Xii k97A== X-Gm-Message-State: AJcUukeZkiASICXEPhkLh5CGfiK3kKhjsxYSfcmofl/p7BESfhxC2siy Evjo9SCpkgFR3KS/w6vHx5hRRw== X-Google-Smtp-Source: ALg8bN77DZVI4MAyADILQs8EzYMsde3cfnpfouthQfWUsyupWicbHSJhKI19K0Ck37pKv29fceFfAw== X-Received: by 2002:a65:65c9:: with SMTP id y9mr3024020pgv.438.1548268055598; Wed, 23 Jan 2019 10:27:35 -0800 (PST) Received: from LBRMN-LNXUB114.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id v5sm40192903pgn.5.2019.01.23.10.27.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Jan 2019 10:27:34 -0800 (PST) From: Vladimir Olovyannikov To: Jaben Carsey , Ray Ni , edk2-devel@lists.01.org Cc: Vladimir Olovyannikov Date: Wed, 23 Jan 2019 10:26:15 -0800 Message-Id: <20190123182615.3184-1-vladimir.olovyannikov@broadcom.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [PATCH] ShellPkg/TftpDynamicCommand: Return proper status X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 18:27:36 -0000 Content-Transfer-Encoding: 8bit Tftp command always returned "SHELL_NOT_FOUND" which is treated as an error by callers. Add missing line to clean the ShellStatus on successful operation. If operation has failed, return the error status if available. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vladimir Olovyannikov --- ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c index ba753a279b00..88e3988a554e 100644 --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c @@ -548,6 +548,8 @@ RunTftp ( goto NextHandle; } + ShellStatus = SHELL_SUCCESS; + NextHandle: CloseProtocolAndDestroyServiceChild ( @@ -575,6 +577,10 @@ RunTftp ( FreePool (Handles); } + if ((ShellStatus != SHELL_SUCCESS) && (EFI_ERROR(Status))) { + ShellStatus = Status & ~MAX_BIT; + } + return ShellStatus; } -- 2.20.1