* [Patch 0/2] Update UEFI supporting TCG spec info
@ 2019-01-25 15:30 Zhang, Chao B
2019-01-25 15:30 ` [Patch 1/2] SecurityPkg/TCG: Upgrade " Zhang, Chao B
2019-01-25 15:30 ` [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: " Zhang, Chao B
0 siblings, 2 replies; 4+ messages in thread
From: Zhang, Chao B @ 2019-01-25 15:30 UTC (permalink / raw)
To: edk2-devel
Update UEFI supporting TCG spec info
Zhang, Chao B (2):
SecurityPkg/TCG: Upgrade UEFI supporting TCG spec info
MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info
MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +++++--
SecurityPkg/SecurityPkg.dec | 2 +-
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 4 +++-
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | 6 ++++--
4 files changed, 13 insertions(+), 6 deletions(-)
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Patch 1/2] SecurityPkg/TCG: Upgrade UEFI supporting TCG spec info
2019-01-25 15:30 [Patch 0/2] Update UEFI supporting TCG spec info Zhang, Chao B
@ 2019-01-25 15:30 ` Zhang, Chao B
2019-01-25 15:30 ` [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: " Zhang, Chao B
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Chao B @ 2019-01-25 15:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Yao Jiewen
Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI Specification 1.2 Revision 8"
https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf
Upgrade TCG PC Client Platform Physical Presence Interface Specification Version 1.3 Revision 0.52" to Errata Version 0.4
https://trustedcomputinggroup.org/wp-content/uploads/Errata-Version-0.4-for-TCG-PC-Client-Platform-Physical-Presence-Interface-Version-1.30-Revision-0.52.pdf
Upgrade "TCG EFI Protocol Specification for Family 2.0 Level 00" to Errata 0.5
https://trustedcomputinggroup.org/wp-content/uploads/EFI-Protocol-Specification-Errata-v.5.pdf
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yao Jiewen <jiewen.yao@intel.com>
Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
---
SecurityPkg/SecurityPkg.dec | 2 +-
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 4 +++-
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | 6 ++++--
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 2708e7953c..7ae42ea150 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -403,11 +403,11 @@
# When it is configured to Dynamic or DynamicEx, it can be set through detection using
# a platform-specific method (e.g. Button pressed) in a actual platform in early boot phase.<BR><BR>
# @Prompt A physical presence user status
gEfiSecurityPkgTokenSpaceGuid.PcdUserPhysicalPresence|FALSE|BOOLEAN|0x00010019
- ## Indicate the TPM2 ACPI table revision. Rev 4 is defined in TCG ACPI Specification Rev 00.37.<BR><BR>
+ ## Indicate the TPM2 ACPI table revision. Rev 4 has been defined since TCG ACPI Specification Rev 00.37.<BR><BR>
# To support configuring from setup page, this PCD can be DynamicHii type and map to a setup option.<BR>
# For example, map to TCG2_VERSION.Tpm2AcpiTableRev to be configured by Tcg2ConfigDxe driver.<BR>
# gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev|L"TCG2_VERSION"|gTcg2ConfigFormSetGuid|0x8|3|NV,BS<BR>
# @Prompt Revision of TPM2 ACPI table.
gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev|3|UINT8|0x0001001A
diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
index 87f0492750..49402d902c 100644
--- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
+++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
@@ -4,19 +4,21 @@
# Spec Compliance Info:
# "TCG PC Client Platform Firmware Profile Specification for TPM Family 2.0 Level 00 Revision 1.03 v51"
# along with
# "Errata for PC Client Specific Platform Firmware Profile Specification Version 1.0 Revision 1.03"
# "TCG EFI Protocol Specification" "Family 2.0" "Level 00 Revision 00.13"
+# along with
+# "Errata Version 0.5 for TCG EFI Protocol Specification"
#
# This module will produce Tcg2 protocol and measure boot environment.
#
# Caution: This module requires additional review when modified.
# This driver will have external input - PE/COFF image.
# This external input must be validated carefully to avoid security issue like
# buffer overflow, integer overflow.
#
-# Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
index 97cec443e4..cc5768294d 100644
--- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
@@ -1,11 +1,13 @@
## @file
# Provides ACPI methods for TPM 2.0 support
#
# Spec Compliance Info:
-# "TCG ACPI Specification Level 00 Revision 00.37"
+# "TCG ACPI Specification Version 1.2 Revision 8"
# "Physical Presence Interface Specification Version 1.30 Revision 00.52"
+# along with
+# "Errata Version 0.4 for TCG PC Client Platform Physical Presence Interface Specification"
# "Platform Reset Attack Mitigation Specification Version 1.00"
# TPM2.0 ACPI device object
# "TCG PC Client Platform Firmware Profile Specification for TPM Family 2.0 Level 00 Revision 1.03 v51"
# along with
# "Errata for PC Client Specific Platform Firmware Profile Specification Version 1.0 Revision 1.03"
@@ -16,11 +18,11 @@
#
# Caution: This module requires additional review when modified.
# This driver will have external input - variable and ACPINvs data in SMM mode.
# This external input must be validated carefully to avoid security issue.
#
-# Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
# http://opensource.org/licenses/bsd-license.php
# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info
2019-01-25 15:30 [Patch 0/2] Update UEFI supporting TCG spec info Zhang, Chao B
2019-01-25 15:30 ` [Patch 1/2] SecurityPkg/TCG: Upgrade " Zhang, Chao B
@ 2019-01-25 15:30 ` Zhang, Chao B
2019-01-25 22:44 ` Yao, Jiewen
1 sibling, 1 reply; 4+ messages in thread
From: Zhang, Chao B @ 2019-01-25 15:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Yao Jiewen
Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI Specification 1.2 Revision 8"
https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yao Jiewen <jiewen.yao@intel.com>
Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
---
MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
index 6b8161e6a6..6bae0a0aa5 100644
--- a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
+++ b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
@@ -1,9 +1,9 @@
/** @file
TPM2 ACPI table definition.
-Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved. <BR>
+Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved. <BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
@@ -29,17 +29,20 @@ typedef struct {
// BIT0~15: PlatformClass This field is only valid for version 4 and above
// BIT16~31: Reserved
UINT32 Flags;
UINT64 AddressOfControlArea;
UINT32 StartMethod;
-//UINT8 PlatformSpecificParameters[];
+//UINT8 PlatformSpecificParameters[]; // size up to 12
+//UINT32 Laml; // Optional
+//UINT32 Lasa; // Optional
} EFI_TPM2_ACPI_TABLE;
#define EFI_TPM2_ACPI_TABLE_START_METHOD_ACPI 2
#define EFI_TPM2_ACPI_TABLE_START_METHOD_TIS 6
#define EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_INTERFACE 7
#define EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_INTERFACE_WITH_ACPI 8
+#define EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_INTERFACE_WITH_SMC 11
typedef struct {
UINT32 Reserved;
UINT32 Error;
UINT32 Cancel;
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info
2019-01-25 15:30 ` [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: " Zhang, Chao B
@ 2019-01-25 22:44 ` Yao, Jiewen
0 siblings, 0 replies; 4+ messages in thread
From: Yao, Jiewen @ 2019-01-25 22:44 UTC (permalink / raw)
To: Zhang, Chao B, edk2-devel@lists.01.org; +Cc: Yao, Jiewen
Hi Chao
Do you think we need provide a way to let a platform fill " PlatformSpecificParameters ", then the core driver can fill laml and lasl ?
Thank you
Yao Jiewen
> -----Original Message-----
> From: Zhang, Chao B
> Sent: Friday, January 25, 2019 11:31 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting
> TCG spec info
>
> Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI
> Specification 1.2 Revision 8"
> https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralS
> pecification_v1.20_r8.pdf
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
> MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> index 6b8161e6a6..6bae0a0aa5 100644
> --- a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> +++ b/MdePkg/Include/IndustryStandard/Tpm2Acpi.h
> @@ -1,9 +1,9 @@
> /** @file
> TPM2 ACPI table definition.
>
> -Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved. <BR>
> +Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved. <BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at
> http://opensource.org/licenses/bsd-license.php
>
> @@ -29,17 +29,20 @@ typedef struct {
> // BIT0~15: PlatformClass This field is only valid for version
> 4 and above
> // BIT16~31: Reserved
> UINT32 Flags;
> UINT64 AddressOfControlArea;
> UINT32 StartMethod;
> -//UINT8 PlatformSpecificParameters[];
> +//UINT8 PlatformSpecificParameters[]; // size
> up to 12
> +//UINT32 Laml;
> // Optional
> +//UINT32 Lasa;
> // Optional
> } EFI_TPM2_ACPI_TABLE;
>
> #define EFI_TPM2_ACPI_TABLE_START_METHOD_ACPI
> 2
> #define EFI_TPM2_ACPI_TABLE_START_METHOD_TIS
> 6
> #define
> EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_
> INTERFACE 7
> #define
> EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_
> INTERFACE_WITH_ACPI 8
> +#define
> EFI_TPM2_ACPI_TABLE_START_METHOD_COMMAND_RESPONSE_BUFFER_
> INTERFACE_WITH_SMC 11
>
> typedef struct {
> UINT32 Reserved;
> UINT32 Error;
> UINT32 Cancel;
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-25 22:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-25 15:30 [Patch 0/2] Update UEFI supporting TCG spec info Zhang, Chao B
2019-01-25 15:30 ` [Patch 1/2] SecurityPkg/TCG: Upgrade " Zhang, Chao B
2019-01-25 15:30 ` [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: " Zhang, Chao B
2019-01-25 22:44 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox