From: Shenglei Zhang <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
Ruiyu Ni <ruiyu.ni@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper
Date: Wed, 30 Jan 2019 14:34:14 +0800 [thread overview]
Message-ID: <20190130063417.11308-5-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20190130063417.11308-1-shenglei.zhang@intel.com>
InternalUnicodeToUpper and InternalAsciiToUpper are internal functions,
so they are substituted by public functions AsciiCharToUpper and CharToUpper.
And their implements are removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../EbcDxe/EbcDebugger/EdbSupportString.c | 39 ++-----------------
1 file changed, 4 insertions(+), 35 deletions(-)
diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
index 02e1876ffa..d34acf892b 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
@@ -307,37 +307,6 @@ AsciiAtoi (
return RetVal;
}
-/**
-
- Convert the character to upper case.
-
- @param Chr the character to be converted.
-
-**/
-STATIC
-CHAR16
-InternalUnicodeToUpper (
- IN CHAR16 Chr
- )
-{
- return (Chr >= L'a' && Chr <= L'z') ? Chr - (L'a' - L'A') : Chr;
-}
-
-/**
-
- Convert the character to upper case.
-
- @param Chr the character to be converted.
-
-**/
-STATIC
-CHAR8
-InternalAsciiToUpper (
- IN CHAR8 Chr
- )
-{
- return (Chr >= 'a' && Chr <= 'z') ? Chr - ('a' - 'A') : Chr;
-}
/**
Compare the Unicode and Ascii string pointed by String to the string pointed by String2.
@@ -390,12 +359,12 @@ StriCmp (
)
{
while ((*String != L'\0') &&
- (InternalUnicodeToUpper (*String) == InternalUnicodeToUpper (*String2))) {
+ (CharToUpper (*String) == CharToUpper (*String2))) {
String++;
String2++;
}
- return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper (*String2);
+ return CharToUpper (*String) - CharToUpper (*String2);
}
/**
@@ -418,12 +387,12 @@ StriCmpUnicodeAndAscii (
)
{
while ((*String != L'\0') &&
- (InternalUnicodeToUpper (*String) == (CHAR16)InternalAsciiToUpper (*String2))) {
+ (CharToUpper (*String) == (CHAR16)AsciiCharToUpper (*String2))) {
String++;
String2++;
}
- return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper (*String2);
+ return CharToUpper (*String) - (CHAR16)AsciiCharToUpper (*String2);
}
/**
--
2.18.0.windows.1
next prev parent reply other threads:[~2019-01-30 6:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 6:34 [PATCH v5 0/7] Introduce two public functions and remove internal ones Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A
2019-01-30 6:34 ` [PATCH v5 2/7] MdePkg/BaseLib: Introduce CharToUpper and AsciiCharToUpper publicly Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 3/7] MdePkg/BaseLib: Remove definitions of two functions Shenglei Zhang
2019-01-30 6:34 ` Shenglei Zhang [this message]
2019-01-30 8:04 ` [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper Wu, Hao A
2019-01-30 6:34 ` [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A
2019-01-30 6:34 ` [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper Shenglei Zhang
2019-01-30 16:13 ` Carsey, Jaben
2019-01-30 6:34 ` [PATCH v5 7/7] ShellPkg/UefiShellLib: " Shenglei Zhang
2019-01-30 16:13 ` Carsey, Jaben
2019-01-30 9:36 ` [PATCH v5 0/7] Introduce two public functions and remove internal ones Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130063417.11308-5-shenglei.zhang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox