From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 004EF211BA461 for ; Tue, 29 Jan 2019 22:35:32 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 22:34:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="316047069" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga005.fm.intel.com with ESMTP; 29 Jan 2019 22:34:29 -0800 From: Shenglei Zhang To: edk2-devel@lists.01.org Cc: Jian J Wang , Hao Wu , Ruiyu Ni , Star Zeng Date: Wed, 30 Jan 2019 14:34:15 +0800 Message-Id: <20190130063417.11308-6-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20190130063417.11308-1-shenglei.zhang@intel.com> References: <20190130063417.11308-1-shenglei.zhang@intel.com> Subject: [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 06:35:33 -0000 Substitute HttpIoCharToUpper with AsciiCharToUpper which is a public function with the same effect. And remove the implement of HttpIoCharToUpper. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Jian J Wang Cc: Hao Wu Cc: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 23 +------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c index 2fc3da8a2d..3884bc8361 100644 --- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c +++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c @@ -898,27 +898,6 @@ typedef struct { UINTN CurrentChunkParsedSize; } HTTP_BODY_PARSER; -/** - - Convert an Ascii char to its uppercase. - - @param[in] Char Ascii character. - - @return Uppercase value of the input Char. - -**/ -CHAR8 -HttpIoCharToUpper ( - IN CHAR8 Char - ) -{ - if (Char >= 'a' && Char <= 'z') { - return Char - ('a' - 'A'); - } - - return Char; -} - /** Convert an hexadecimal char to a value of type UINTN. @@ -936,7 +915,7 @@ HttpIoHexCharToUintn ( return Char - '0'; } - return (10 + HttpIoCharToUpper (Char) - 'A'); + return (10 + AsciiCharToUpper (Char) - 'A'); } /** -- 2.18.0.windows.1