From: Shenglei Zhang <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Jaben Carsey <jaben.carsey@intel.com>
Subject: [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper
Date: Wed, 30 Jan 2019 14:34:16 +0800 [thread overview]
Message-ID: <20190130063417.11308-7-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20190130063417.11308-1-shenglei.zhang@intel.com>
Substitute InternalShellCharToUpper with a public function
CharToUpper which has the same function.
Remove the implement of InternalShellCharToUpper.
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
ShellPkg/Application/Shell/ShellManParser.c | 23 +--------------------
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/ShellPkg/Application/Shell/ShellManParser.c b/ShellPkg/Application/Shell/ShellManParser.c
index b180c6c8f7..2c044dbe4a 100644
--- a/ShellPkg/Application/Shell/ShellManParser.c
+++ b/ShellPkg/Application/Shell/ShellManParser.c
@@ -46,27 +46,6 @@ SHELL_MAN_HII_VENDOR_DEVICE_PATH mShellManHiiDevicePath = {
}
};
-
-/**
- Convert a Unicode character to upper case only if
- it maps to a valid small-case ASCII character.
-
- This internal function only deal with Unicode character
- which maps to a valid small-case ASCII character, i.e.
- L'a' to L'z'. For other Unicode character, the input character
- is returned directly.
-
- @param Char The character to convert.
-
- @retval LowerCharacter If the Char is with range L'a' to L'z'.
- @retval Unchanged Otherwise.
-
-**/
-CHAR16
-InternalShellCharToUpper (
- IN CHAR16 Char
- );
-
/**
Verifies that the filename has .EFI on the end.
@@ -416,7 +395,7 @@ IsTitleHeader(
ReturnFound = TRUE; // This is the desired command's title header line.
State = (BriefDesc == NULL) ? Final : GetBriefDescription;
}
- else if (InternalShellCharToUpper (*Line) != InternalShellCharToUpper (*(Command + CommandIndex++))) {
+ else if (CharToUpper (*Line) != CharToUpper (*(Command + CommandIndex++))) {
State = Final;
}
Line++;
--
2.18.0.windows.1
next prev parent reply other threads:[~2019-01-30 6:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 6:34 [PATCH v5 0/7] Introduce two public functions and remove internal ones Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A
2019-01-30 6:34 ` [PATCH v5 2/7] MdePkg/BaseLib: Introduce CharToUpper and AsciiCharToUpper publicly Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 3/7] MdePkg/BaseLib: Remove definitions of two functions Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A
2019-01-30 6:34 ` [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A
2019-01-30 6:34 ` Shenglei Zhang [this message]
2019-01-30 16:13 ` [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper Carsey, Jaben
2019-01-30 6:34 ` [PATCH v5 7/7] ShellPkg/UefiShellLib: " Shenglei Zhang
2019-01-30 16:13 ` Carsey, Jaben
2019-01-30 9:36 ` [PATCH v5 0/7] Introduce two public functions and remove internal ones Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130063417.11308-7-shenglei.zhang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox