From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3FFE8211BA461 for ; Tue, 29 Jan 2019 22:34:32 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 22:34:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="316047074" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga005.fm.intel.com with ESMTP; 29 Jan 2019 22:34:31 -0800 From: Shenglei Zhang To: edk2-devel@lists.01.org Cc: Ruiyu Ni , Jaben Carsey Date: Wed, 30 Jan 2019 14:34:16 +0800 Message-Id: <20190130063417.11308-7-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20190130063417.11308-1-shenglei.zhang@intel.com> References: <20190130063417.11308-1-shenglei.zhang@intel.com> Subject: [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 06:34:32 -0000 Substitute InternalShellCharToUpper with a public function CharToUpper which has the same function. Remove the implement of InternalShellCharToUpper. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Jaben Carsey Reviewed-by: Liming Gao --- ShellPkg/Application/Shell/ShellManParser.c | 23 +-------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/ShellPkg/Application/Shell/ShellManParser.c b/ShellPkg/Application/Shell/ShellManParser.c index b180c6c8f7..2c044dbe4a 100644 --- a/ShellPkg/Application/Shell/ShellManParser.c +++ b/ShellPkg/Application/Shell/ShellManParser.c @@ -46,27 +46,6 @@ SHELL_MAN_HII_VENDOR_DEVICE_PATH mShellManHiiDevicePath = { } }; - -/** - Convert a Unicode character to upper case only if - it maps to a valid small-case ASCII character. - - This internal function only deal with Unicode character - which maps to a valid small-case ASCII character, i.e. - L'a' to L'z'. For other Unicode character, the input character - is returned directly. - - @param Char The character to convert. - - @retval LowerCharacter If the Char is with range L'a' to L'z'. - @retval Unchanged Otherwise. - -**/ -CHAR16 -InternalShellCharToUpper ( - IN CHAR16 Char - ); - /** Verifies that the filename has .EFI on the end. @@ -416,7 +395,7 @@ IsTitleHeader( ReturnFound = TRUE; // This is the desired command's title header line. State = (BriefDesc == NULL) ? Final : GetBriefDescription; } - else if (InternalShellCharToUpper (*Line) != InternalShellCharToUpper (*(Command + CommandIndex++))) { + else if (CharToUpper (*Line) != CharToUpper (*(Command + CommandIndex++))) { State = Final; } Line++; -- 2.18.0.windows.1