From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C3A77211C3859 for ; Thu, 31 Jan 2019 02:28:03 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id p4so2631803wrt.7 for ; Thu, 31 Jan 2019 02:28:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hmTOYHl0ObjX/pxbTaJtGeAwYu8nMwVUB+rTUjE4JqA=; b=Ybk3Irk3NdKPQEe+3t61q8N33lbF4xQzTp6NMxL/ZQCB3T18NFuQZGCVCNawkhzn07 IayIsw9lnHfC/7BG/jktEfxbrwAswz+yjH0K8ok3mK9TOA/aTjTA/O7CrM1kCIYEspEL 9aQ1F1xoky/yvUt+qIO019J4h2N829yRiqdvs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hmTOYHl0ObjX/pxbTaJtGeAwYu8nMwVUB+rTUjE4JqA=; b=VD+f10JSCTyDZeAvm7v2pIyGf+shdRP6kQIXeENo6vwhaE49FD8trZvBgYhraijicF xpjf/UiK6fzrILhkgBI5LvTz4bDDULd9KLX2QfP4C4Nr6ftbEmYmiubXwNQRna3awWEb tDTbm5t3nn/we3s+0HNcGwW6dEmxh3u1NKOlIkcFIJ6V7g4W5RIVKtUj4GQMd97hFWKN RlUD43m3oCpylXsOZmU4RI1ZKDubh5mX/FcP9oNMxFYgAK7MU4qflk9XpMG8Z4rSb9oM PhBP0856mjC4LldrMjzpcY6Uzlg0XqBaEtoOh0sP9+ZPmh7kbJzaGOSKU6jCXGd0GyuA lsBw== X-Gm-Message-State: AJcUukf04nxjqurFZbF0CI/oPsGkcIeu3qU813acS0HIRAnO7e8lO3/G LmVee4ztN5MA5bkhSt2xR7TLEw== X-Google-Smtp-Source: ALg8bN40ztkA142jNyn6KYGLymfXrNjiq9ngvHn7xLMSoTeL/a0UjZY5XpW8HvuLHisFo+4KOCZKAw== X-Received: by 2002:adf:f550:: with SMTP id j16mr33252012wrp.258.1548930481516; Thu, 31 Jan 2019 02:28:01 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k15sm5178715wru.8.2019.01.31.02.28.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 02:28:00 -0800 (PST) Date: Thu, 31 Jan 2019 10:27:59 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Message-ID: <20190131102759.fsww3vevkktmxse7@bivouac.eciton.net> References: <1548668715-15042-1-git-send-email-mw@semihalf.com> <20190130164737.glko5nprvhfcy7ap@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v3 0/5] Armada7k8k memory handling update X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 10:28:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Jan 31, 2019 at 08:01:08AM +0100, Marcin Wojtas wrote: > Hi Leif, > > Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.h > / ArmPkg/Library/ArmLib/ArmLib.c would be a proper place for it? As good a place as any. While not ARM-architecture specific, I feel it's probably ARM-platform specific. I mean, hopefully we'll some day we'll get a sane reporting mechanism of Secure-reserved regions by ARM-TF and we can drop this juggling in Non-secure firmware. Best Regards, Leif > Best regards, > Marcin > > śr., 30 sty 2019 o 17:47 Leif Lindholm > napisał(a): > > > Thanks for the rework. > > > > (We should probably move that broken-out function to ArmPkg at some point.) > > > > For the series: > > Reviewed-by: Leif Lindholm > > > > Pushed as b0bb325f20..0a7d8e7d93. > > > > On Mon, Jan 28, 2019 at 10:45:10AM +0100, Marcin Wojtas wrote: > > > Hi, > > > > > > The third version of the patchset moves the new common > > > header for Marvell SMC ID's to the IndustryStandard directory. > > > What is more important, now 3 regions (described by new PCDs) > > > are reserved separately. For that purpose a preparation > > > patch was added, which extract existing reservation code > > > into a new subroutine. More details can be found in > > > the changelog below and the commit messages. > > > > > > Patches are available in the github: > > > > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/dram-upstream-r20190128 > > > > > > I'm looking forward to the comments and remarks. > > > > > > Best regards, > > > Marcin > > > > > > Changelog: > > > v2 -> v3 > > > * 1/5 > > > - New patch - extract memory reservation to a separate routine > > > > > > * 2/2 > > > - Add new PCDs and reserve 3 regions (ARM-TF, PEI stack, OP-TEE) > > > separately > > > - Update commit message accordingly > > > > > > * 3/5 > > > - Move MvSmc.h to Include/IndustryStandard > > > > > > * 4,5/5 > > > - Add Leif's RB > > > > > > v1 -> v2: > > > * 1/4 > > > - Improve commit log - mention single area size and new PEI stack base > > > > > > * 2/4 (new patch) > > > - Add common header for Marvell SMC ID's > > > > > > * 3/4 > > > - Add function description comment > > > - Define and use ARMADA7K8K_AP806_INDEX > > > - Change function argument to EFI_PHYSICAL_ADDRESS > > > > > > * 4/4 > > > - Move new SMC ID to MvSmc.h > > > - Include ArmadaSoCDescLib.h directly (instead indirectly via > > BoardDesc.h) > > > - Remove ARMADA7K8K_AP806_INDEX macro > > > > > > Grzegorz Jaszczyk (2): > > > Marvell/Library: ArmadaSoCDescLib: Add North Bridge description > > > Marvell/Armada7k8k: Read DRAM settings from ARM-TF > > > > > > Marcin Wojtas (3): > > > Marvell/Armada7k8k: Refactor reserving memory regions > > > Marvell/Armada7k8k: Shift PEI stack base and extend memory reservation > > > Marvell/Library: Introduce common header for the SMC ID's > > > > > > Silicon/Marvell/Marvell.dec > > | 8 +- > > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > | 16 ++- > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf > > | 3 + > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kMemoryInitPeiLib/Armada7k8kMemoryInitPeiLib.inf > > | 8 +- > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.h > > | 25 ----- > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > > | 6 ++ > > > Silicon/Marvell/Include/IndustryStandard/MvSmc.h > > | 24 +++++ > > > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > > | 28 +++++ > > > Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > > | 8 +- > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.c > > | 60 ++++------- > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kMemoryInitPeiLib/Armada7k8kMemoryInitPeiLib.c > > | 107 +++++++++++++------- > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c > > | 34 +++++++ > > > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c > > | 14 +-- > > > 13 files changed, 220 insertions(+), 121 deletions(-) > > > create mode 100644 Silicon/Marvell/Include/IndustryStandard/MvSmc.h > > > > > > -- > > > 2.7.4 > > > > >