From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.106.49; helo=cam-smtp0.cambridge.arm.com; envelope-from=krzysztof.koch@arm.com; receiver=edk2-devel@lists.01.org Received: from cam-smtp0.cambridge.arm.com (unknown [217.140.106.49]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 334A021B02822 for ; Thu, 31 Jan 2019 05:30:26 -0800 (PST) Received: from E119924.Arm.com (E119924.Arm.com [10.1.199.31]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id x0VDUDsv014160; Thu, 31 Jan 2019 13:30:13 GMT From: Krzysztof Koch To: edk2-devel@lists.01.org Cc: jaben.carsey@intel.com, ray.ni@intel.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, Sami.Mujawar@arm.com, nd@arm.com Date: Thu, 31 Jan 2019 13:30:08 +0000 Message-Id: <20190131133008.14620-1-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 13:30:27 -0000 Removed conditional pre-compiling for ARM CPUs because function ValidateCacheAttributes(..) is based on ACPI PPTT specification. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Krzysztof Koch Reported-by: Zhichao Gao --- The code can be found at: https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1 Notes: v1: - removed conditional precompilation [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c index bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bcc7b791fcf7d70f3 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c @@ -86,11 +86,9 @@ ValidateCacheAttributes ( IN VOID* Context ) { -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) // Reference: Advanced Configuration and Power Interface (ACPI) Specification // Version 6.2 Errata A, September 2017 // Table 5-153: Cache Type Structure - UINT8 Attributes; Attributes = *(UINT8*)Ptr; @@ -102,7 +100,6 @@ ValidateCacheAttributes ( ); return; } -#endif } /** -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'