From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 945BE211BA47C for ; Thu, 31 Jan 2019 10:22:45 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id q18so4378841wrx.9 for ; Thu, 31 Jan 2019 10:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JlqAPMpJZXWSqu1Sd58Xx+uJRLIPt3rAkbxS63kcXRM=; b=NCmq2jRWPs6QB9PyyaU10oa9uEh1MnScLfWqZ80B9Ef0AkIs2Dc3JGRIM9FL2Ftc5l 4vzXdePti9RpHFgOrpEQjNEsN9SJnuMeiZYosvCozlq1bepCl2uNg06pD0mpig1cUwzV JlHlYGE84RUhVAeJqQwYuOE+/rgQOHX1quDTU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JlqAPMpJZXWSqu1Sd58Xx+uJRLIPt3rAkbxS63kcXRM=; b=Q0jOaHGxNNs/XCPCqgQQkYtz9IPHnP3LSoRK8XY6Xb3kbPfn+fik6iCcrVPglVlFPb kH2IYSnCVLWQrpjzooFZf2LDi3mSDh46ruSdtlAGplh4+2KsanGjwwmFPzBh/3rSKJFU TPMn2yCtZEpToROm6k+VzyS+ibUenl1tHOCG+R3waDykdM6SBelp8QMxrdD7xRZjZFAy E9bkR0WXdnvdsgB+mG6+pmlkKCnF3e8oemy4tzoTWsGGKwjAsdui2TmO+5ELj5hoHFOm yMITHYjM7VL4rUeR/Ry4U8M6ha+3BdWpSNkzVtlmHZKCPeSnAZoa7Od5Zsvtnm3oMabF 12kg== X-Gm-Message-State: AJcUukebH+owwaXXJS3p3PEpjjMTIhIEXa4oF+LLBqLLTEi6I8r+JSK3 ch47VWaLLUQ8D3cajLyoeLpesA== X-Google-Smtp-Source: ALg8bN5+EWjnt6744I6Ak5RfYGIySlEr3+KivHnns5JoKQTT0IRCfad8NBNCgknkedkQ/y22PnUXXw== X-Received: by 2002:adf:81c6:: with SMTP id 64mr37073758wra.186.1548958963842; Thu, 31 Jan 2019 10:22:43 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c202sm6332369wmd.40.2019.01.31.10.22.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 10:22:43 -0800 (PST) Date: Thu, 31 Jan 2019 18:22:41 +0000 From: Leif Lindholm To: tzy.way.ooi@intel.com Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, tien.hock.loh@intel.com, chin.liang.see@intel.com Message-ID: <20190131182241.ano4hlyoj2kjcxoe@bivouac.eciton.net> References: <20190131083200.4231-1-tzy.way.ooi@intel.com> MIME-Version: 1.0 In-Reply-To: <20190131083200.4231-1-tzy.way.ooi@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 18:22:45 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Tzy Way, Thank you for this contribution. I do have some high-level comments. First of all, my best guess is that you have used Lan9118Dxe for reference when developing this driver. This is somewhat unfortunate. I am reminded that a) we badly need to migrate that driver (and Lan91xDxe) to edk2-platforms. b) we badly need to convert those drivers to UEFI driver model and NonDiscoverableDeviceRegistrationLib. Those two predate the NonDiscoverable implementation, so have been left as is, but any new drivers really need to implement proper driver model. Additionally, this driver should be submitted to edk2-platforms rather than edk2. Secondly, searching online for "designware emac" does not find unambigously the product this refers to. This is where it would be usful with a proper commit message and explain in a bit more detail what the driver is. On Thu, Jan 31, 2019 at 04:32:00PM +0800, tzy.way.ooi@intel.com wrote: > From: "Ooi, Tzy Way" > > Contributed-under: TianCore Contribution Agreement 1.1 > Signed-off-by: Ooi, Tzy Way > --- > .../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c | 1368 +++++++++++++++++ > .../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.h | 236 +++ > .../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.inf | 69 + > .../Drivers/DwEmacSnpDxe/EmacDxeUtil.c | 676 ++++++++ > .../Drivers/DwEmacSnpDxe/EmacDxeUtil.h | 378 +++++ > EmbeddedPkg/Drivers/DwEmacSnpDxe/PhyDxeUtil.c | 604 ++++++++ > EmbeddedPkg/Drivers/DwEmacSnpDxe/PhyDxeUtil.h | 324 ++++ > EmbeddedPkg/EmbeddedPkg.dec | 4 + > EmbeddedPkg/EmbeddedPkg.dsc | 1 + > 9 files changed, 3660 insertions(+) Thirdly, please generate patches as described in https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 This greatly simplifies review. Best Regards, Leif