From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=maggie.chu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AFA67211C6067 for ; Fri, 1 Feb 2019 02:38:41 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 02:38:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,548,1539673200"; d="scan'208";a="130714815" Received: from chumaggi-mobl.gar.corp.intel.com ([10.5.245.233]) by orsmga002.jf.intel.com with ESMTP; 01 Feb 2019 02:38:39 -0800 From: Maggie Chu To: edk2-devel@lists.01.org Cc: Chao Zhang , Jiewen Yao , Eric Dong Date: Fri, 1 Feb 2019 18:38:28 +0800 Message-Id: <20190201103828.1264-1-maggie.chu@intel.com> X-Mailer: git-send-email 2.14.2.windows.3 Subject: [PATCH] SecurityPkg/OpalPassword: Update strings on Opal Setup page X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 10:38:41 -0000 https://bugzilla.tianocore.org/show_bug.cgi?id=1506 Updated some descriptions on SETUP page to avoid user confusion. Currently it shows "1.0 UEFI Opal Driver", however it may be mislead user to think it is only for Opal drive but not for Pyrite drive. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Maggie Chu Cc: Chao Zhang Cc: Jiewen Yao Cc: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 10 ---------- SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormStrings.uni | 10 ++++++---- SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordForm.vfr | 4 ++-- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c index 4336604d0d..51aa93c2fd 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c @@ -393,7 +393,6 @@ OpalHiiAddPackages( ) { EFI_HANDLE DriverHandle; - CHAR16 *NewString; DriverHandle = HiiGetDriverImageHandleCB(); @@ -416,15 +415,6 @@ OpalHiiAddPackages( return EFI_OUT_OF_RESOURCES; } - // - // Update Version String in main window - // - NewString = HiiGetDriverNameCB (); - if (HiiSetString(gHiiPackageListHandle, STRING_TOKEN(STR_MAIN_OPAL_VERSION), NewString, NULL) == 0) { - DEBUG ((DEBUG_INFO, "OpalHiiAddPackages: HiiSetString( ) failed\n")); - return EFI_OUT_OF_RESOURCES; - } - return EFI_SUCCESS; } diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormStrings.uni b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormStrings.uni index 5f753dfa8c..d818a66bdb 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormStrings.uni +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormStrings.uni @@ -20,14 +20,15 @@ #string STR_NULL #language en-US " " ///////////////////////////////// FORM SET ///////////////////////////////// -#string STR_FORM_SET_HELP #language en-US "Manage Opal disks" +#string STR_FORM_SET_HELP #language en-US "Select to manage" ///////////////////////////////// MULTIPLE FORMS ///////////////////////////////// -#string STR_OPAL #language en-US "Opal" +#string STR_OPAL #language en-US "TCG Drive Management" #string STR_MAIN_OPAL_VERSION #language en-US "Version 00.0.0.0000" ///////////////////////////////// MAIN MENU FORM ///////////////////////////////// #string STR_MAIN_PHY_DISKS_LBL #language en-US "Physical Disks:" +#string STR_MAIN_OPAL_TITLE_LBL #language en-US "Allows user to choose drive to configure drive security. User can also set storage action policy for use of the TCG Block SID authentication feature." #string STR_MAIN_GOTO_DISK_INFO_0 #language en-US " " #string STR_MAIN_GOTO_DISK_INFO_1 #language en-US " " @@ -36,13 +37,14 @@ #string STR_MAIN_GOTO_DISK_INFO_4 #language en-US " " #string STR_MAIN_GOTO_DISK_INFO_5 #language en-US " " -#string STR_MAIN_GOTO_DISK_INFO_HELP #language en-US "Select to see Opal disk actions" +#string STR_MAIN_GOTO_DISK_INFO_HELP #language en-US "Select disk to see actions" #string STR_MAIN_NO_DISKS_PRESENT_LBL #language en-US "No disks connected to system" #string STR_MAIN_NO_DISKS_PRESENT_LBL_HELP #language en-US "The storage needs to be connected before EndOfDxe" ///////////////////////////////// DISK INFO MENU FORM ///////////////////////////////// #string STR_DISK_INFO_SELECTED_DISK_NAME #language en-US " " +#string STR_DISK_INFO_TITLE_LBL #language en-US "Allows user to set and modify password; perform secure erase; and perform revert functions on drive." #string STR_DISK_INFO_LOCK #language en-US "Lock" #string STR_DISK_INFO_UNLOCK #language en-US "Unlock" @@ -69,7 +71,7 @@ #string STR_BLOCKSID_STATUS2 #language en-US "" #string STR_BLOCKSID_STATUS3 #language en-US "" -#string STR_OPAL_REQUESTS_LBL #language en-US "Opal Password Requests:" +#string STR_OPAL_REQUESTS_LBL #language en-US "Options:" #string STR_DISK_INFO_LOCK_HELP #language en-US "Lock the disk" #string STR_DISK_INFO_UNLOCK_HELP #language en-US "Unlock the disk" #string STR_DISK_INFO_SET_ADMIN_PSWD_HELP #language en-US "Set password for the administrator, reset is required for the request to be processed in next boot" diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordForm.vfr b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordForm.vfr index d802ef305d..773d349c2b 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordForm.vfr +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordForm.vfr @@ -45,7 +45,7 @@ form formid = FORMID_VALUE_MAIN_MENU, endnumeric; endif; - subtitle text = STRING_TOKEN(STR_MAIN_OPAL_VERSION); + subtitle text = STRING_TOKEN(STR_MAIN_OPAL_TITLE_LBL); subtitle text = STRING_TOKEN(STR_NULL); @@ -174,7 +174,7 @@ form formid = FORMID_VALUE_DISK_INFO_FORM_MAIN, endcheckbox; endif; - subtitle text = STRING_TOKEN(STR_MAIN_OPAL_VERSION); + subtitle text = STRING_TOKEN(STR_DISK_INFO_TITLE_LBL); subtitle text = STRING_TOKEN(STR_NULL); -- 2.16.2.windows.1