From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED82F211BFCD4 for ; Mon, 4 Feb 2019 04:04:32 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id y139so12812097wmc.5 for ; Mon, 04 Feb 2019 04:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dbZ4KFgXcsPGEznu8nwFPEjqdA34/fi/f6swSlLFnT0=; b=gBNyoEpxrOeg0hhXBJyO007fAHtLSkN/GJWz7XgAuwpvBnCmMeOSykYpM1avP0Z4sg rGvvTk+Z6Dgs916A6plAqLv1XAu7rryR9ZCJeDtIEawTvBRtEsxyo4csTEvvceVvmpvx jnKTN+oLAztN2JLbaUbX7wO3TZXbXCfIvj2gE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dbZ4KFgXcsPGEznu8nwFPEjqdA34/fi/f6swSlLFnT0=; b=R+9heHSzSSyMUZ16QsdUEbijpGbbvrSqVf08lnRa4RgmwoBwSPKQp0MY2nlb/CgyLL ooZEwgWxcy9Xse5CEWD19GhMPbeG6CLcZds7SxIeDGV2D5VLnLXBNbuXmqtalnnruUhV XNECqXJX2LgQ3s35z/ngC9/TRY7kqCPU5M4sKu3kZCJlTF9olRwOkZ51BXNz3ne+8keC +xiSDClg8V6nmd/7nI90jRQ+ooO7taffCTcZU8tNMNEPp33DY8LbRVsavXBDTxhF49X8 IiYpN7T//ajNG6vgCyHRouLWZz1muJzSLEBBgzqh08A8mk7hq2OLV4iDJh6pKIchgfDv QVmg== X-Gm-Message-State: AHQUAuYR4xByG1gIxQFP32VdO4yogJafiWlW0TCDZVGRH9NoZ+NguBlE B/BKuLHZNPnNAfyr6H1Gu1LWZlZkFnDbDw== X-Google-Smtp-Source: AHgI3IZUk3qPSUM7PaN6Wdc9sTs+8u0ChrOr7Rcm8sHr7w2E0eDRcDam5wD6HslEJ9rTqIGBWsLcmg== X-Received: by 2002:a1c:4b01:: with SMTP id y1mr10462727wma.79.1549281870854; Mon, 04 Feb 2019 04:04:30 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g67sm17759734wmd.38.2019.02.04.04.04.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 04:04:30 -0800 (PST) Date: Mon, 4 Feb 2019 12:04:28 +0000 From: Leif Lindholm To: edk2-devel@lists.01.org Cc: "Kinney, Michael D" , Daryl McDaniel , Jaben Carsey Message-ID: <20190204120428.fuvr2hv2ts2yyxrp@bivouac.eciton.net> References: <20181102105015.3609-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181102105015.3609-1-leif.lindholm@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2] AppPkg: fix webserver build for !Ia32/X64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 12:04:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Mike, Daryl, Jaben - any comments on v2? On Fri, Nov 02, 2018 at 10:50:15AM +0000, Leif Lindholm wrote: > The WebServer application is not meant to be Ia32/X64 specific, and would > build for other architectures, if it wasn't for the > #include > in WebServer.h. Move that statement to Mtrr.c instead, which is the only > consumer, and is already being filtered out for other architectures. > > Cc: Daryl McDaniel > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm > --- > > Resending only 1/6, since the others got R-b already. > Looking at PageList.c, the app was clearly intended to be portable, > so updated commit message to reflect this. > > AppPkg/Applications/Sockets/WebServer/WebServer.h | 1 - > AppPkg/Applications/Sockets/WebServer/Mtrr.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/AppPkg/Applications/Sockets/WebServer/WebServer.h b/AppPkg/Applications/Sockets/WebServer/WebServer.h > index 21b07b63df..16c30c8d6d 100644 > --- a/AppPkg/Applications/Sockets/WebServer/WebServer.h > +++ b/AppPkg/Applications/Sockets/WebServer/WebServer.h > @@ -20,7 +20,6 @@ > > #include > > -#include > #include > #include > #include > diff --git a/AppPkg/Applications/Sockets/WebServer/Mtrr.c b/AppPkg/Applications/Sockets/WebServer/Mtrr.c > index 54356bde64..4b8482d4e2 100644 > --- a/AppPkg/Applications/Sockets/WebServer/Mtrr.c > +++ b/AppPkg/Applications/Sockets/WebServer/Mtrr.c > @@ -15,6 +15,7 @@ > > #include > #include > +#include > > #define VARIABLE_MTRR_VALID 0x800 > > -- > 2.11.0 >