From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::32d; helo=mail-wm1-x32d.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01518211B5079 for ; Mon, 4 Feb 2019 10:31:45 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id d15so949945wmb.3 for ; Mon, 04 Feb 2019 10:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=OShhBnTj/X7TV1IMH13c3BNJot56sHsvxj15JTz5xz4=; b=B8oDHtaL2KbGH/aFrZ3ohQolnvP3vKoSz1IqBxQMzqx6qNVzsC4xBhh5HMibvpsAjJ 0lOqtbKyt1EnM4FlTK9VzlDJQjDkmmlCWJVOwjG6DA0xIQXQGR5r4DmCbxI2776CN3mP uabNhWG0PTlratcuIMA+zVQyIrVHFgP+0WRBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=OShhBnTj/X7TV1IMH13c3BNJot56sHsvxj15JTz5xz4=; b=QFXk/OwB/k9+6MJkPsn8dDanVppcDDHjdiIzfMD0QluhPGDERVTlA8jvIcvKnkxB1q Nxz7+/FN4Sh0yV52LCpVqIA8J2lHw7Ci1UpXdLOj8ikz7J28p8ZqkvJKwGvyCukuh3nv 9Rkir4CnKyWeT7d5ct4ty2Zb7FjD+nzZKy4CktkDuXo2X/5CgE2mXHKy9k23/MRfZSeU dL2xqxu3d6tRsuMT0jUCwOrBtwQ8g1DtzYWF+0K5fajAVWKsduKHB7u7WNatJHpQy7sy NWnmCCn4LrMepchl5l7WnVMd28Xi15H3G0g6dkP68srvAf6gn+OA6XAuWOVHH0+U/sUz WNdQ== X-Gm-Message-State: AHQUAub4mzClvdzD+0AYgUks7cQM8bx3rJpEtJelKM3ED3IW7NJAwXIs ocgcWCe3TczMVvoyrmIvYuqN5WLSPhM= X-Google-Smtp-Source: AHgI3IZf512fXVNp1TlLZcsvLr787pu9aSL3+n9qUoowG3VGEPzOpxVljwkN5OUguzaLyqVk3fPuIQ== X-Received: by 2002:a1c:8095:: with SMTP id b143mr511928wmd.63.1549305104148; Mon, 04 Feb 2019 10:31:44 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c202sm27201874wmd.40.2019.02.04.10.31.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 10:31:43 -0800 (PST) Date: Mon, 4 Feb 2019 18:31:41 +0000 From: Leif Lindholm To: edk2-devel@lists.01.org Cc: Bob Feng , Liming Gao Message-ID: <20190204183141.bv2z5u4w7cuyo77b@bivouac.eciton.net> MIME-Version: 1.0 User-Agent: NeoMutt/20170113 (1.7.2) Subject: BaseTools: handling of $(ARCH) in .dsc/.fdf when multiple -a specified X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 18:31:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Bob, Liming, So, I've been playing around with merging the .dsc/.fdf files in OvmfPkg. Merging IA32 and X64 is simple enough, since you can test on !if $(ARCH) == "X64" However, from what I can tell, when trying to merge in the OvmfPkgIa32X64 platform - what you actually end up with in $(ARCH) when specifying multiple -a is a python list rather than a single string. To explain the problem in code, tryin to build the platform described by --- [Defines] PLATFORM_NAME = Ovmf PLATFORM_GUID = 5a9e7754-d81b-49ea-85ad-69eaa7b1539b PLATFORM_VERSION = 0.1 DSC_SPECIFICATION = 0x00010005 SUPPORTED_ARCHITECTURES = IA32|X64 BUILD_TARGETS = DEBUG|NOOPT|RELEASE !if "$(ARCH)" == "IA32 X64" or "$(ARCH)" == "X64 IA32" OUTPUT_DIRECTORY = Build/OvmfDummy !else OUTPUT_DIRECTORY = Build/Ovmf$(ARCH)Real !endif --- using the command line 'build -t GCC5 -a IA32 -a X64 -b DEBUG -p Test.dsc' inevitably results in an output like --- Build environment: Linux-4.9.0-3-amd64-x86_64-with-debian-9.7 Build start time: 18:21:33, Feb.04 2019 WORKSPACE = /work/git/edk2 EDK_TOOLS_PATH = /work/git/edk2/BaseTools CONF_PATH = /work/git/edk2/Conf PYTHON_COMMAND = /usr/bin/python3.5 build.py... /work/git/edk2/Test.dsc(11): error 3001: No space is allowed in OUTPUT_DIRECTORY Build/OvmfIA32 X64Real - Failed - --- Now, the Ia32X64 target is very much of a special case, which I don't necessarily see as usefully supported by the current .dsc specification. But I believe we need to do one of - banning (simultaneous) multi-architecture platforms - treating them the same as multi-target (-b) builds (build them separately) - have a defined way of handling them So, am I missing something, or does this require a change in BaseTools? Best Regards, Leif