From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel@lists.01.org
Subject: [PATCH 13/14] ArmVirtPkg/ArmVirtXen: don't set PcdTurnOffUsbLegacySupport
Date: Wed, 6 Feb 2019 13:11:08 +0100 [thread overview]
Message-ID: <20190206121109.8776-14-lersek@redhat.com> (raw)
In-Reply-To: <20190206121109.8776-1-lersek@redhat.com>
According to the
PCDs not used by modules or in conditional directives
sections of all the build reports for
{AARCH64,ARM} x {Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1}
(12 builds in total), the PCD is not used in any of those builds. Restrict
the setting to the ArmVirtQemu and ArmVirtQemuKernel platforms.
("feat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D
SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".)
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Julien Grall <julien.grall@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ArmVirtPkg/ArmVirt.dsc.inc | 2 --
ArmVirtPkg/ArmVirtQemu.dsc | 2 ++
ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 59d66102bfb7..f7c51e3c160f 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -272,8 +272,6 @@ [PcdsFeatureFlag.common]
gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|TRUE
- gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
-
[PcdsFeatureFlag.AARCH64]
#
# Activate AcpiSdtProtocol
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index f4aac11ee4ef..83c8af0258b2 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -87,6 +87,8 @@ [PcdsFeatureFlag.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
+
[PcdsFixedAtBuild.common]
!if $(ARCH) == AARCH64
gArmTokenSpaceGuid.PcdVFPEnabled|1
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index 5fa75b8fd5e3..46d8bac3ef4d 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -93,6 +93,8 @@ [PcdsFeatureFlag.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
+ gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
+
[PcdsFixedAtBuild.common]
!if $(ARCH) == AARCH64
gArmTokenSpaceGuid.PcdVFPEnabled|1
--
2.19.1.3.g30247aa5d201
next prev parent reply other threads:[~2019-02-06 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 12:10 [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs Laszlo Ersek
2019-02-06 12:10 ` [PATCH 01/14] ArmVirtPkg/ArmVirtQemuKernel: don't set PcdCPUCoresStackBase Laszlo Ersek
2019-02-06 12:10 ` [PATCH 02/14] ArmVirtPkg: don't set PcdRelocateVectorTable Laszlo Ersek
2019-02-06 12:10 ` [PATCH 03/14] ArmVirtPkg/{ArmVirtQemu, ArmVirtQemuKernel}: don't set PcdTrustzoneSupport Laszlo Ersek
2019-02-06 12:10 ` [PATCH 04/14] ArmVirtPkg: don't set PcdPostCodePropertyMask Laszlo Ersek
2019-02-06 12:11 ` [PATCH 05/14] ArmVirtPkg: clean up PcdSetNxForStack setting (applies to ArmVirtQemu only) Laszlo Ersek
2019-02-06 12:11 ` [PATCH 06/14] ArmVirtPkg/PrePi: drop wrong PcdCoreCount dependency Laszlo Ersek
2019-02-06 12:11 ` [PATCH 07/14] ArmVirtPkg: don't set PcdCoreCount Laszlo Ersek
2019-02-06 12:11 ` [PATCH 08/14] ArmVirtPkg: don't set PcdDebugClearMemoryValue Laszlo Ersek
2019-02-06 12:11 ` [PATCH 09/14] ArmVirtPkg: don't set PcdDebugPrintErrorLevel in RELEASE builds Laszlo Ersek
2019-02-06 12:11 ` [PATCH 10/14] ArmVirtPkg/ArmVirtXen: don't set PcdPL031RtcBase Laszlo Ersek
2019-02-06 12:11 ` [PATCH 11/14] ArmVirtPkg/ArmVirtXen: don't set PcdTerminalTypeGuidBuffer Laszlo Ersek
2019-02-06 12:11 ` [PATCH 12/14] ArmVirtPkg/ArmVirtXen: don't set PcdShellFile Laszlo Ersek
2019-02-06 12:11 ` Laszlo Ersek [this message]
2019-02-06 12:11 ` [PATCH 14/14] ArmVirtPkg/ArmVirtXen: don't set Pcd*ImageVerificationPolicy Laszlo Ersek
2019-02-06 15:46 ` [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs Ard Biesheuvel
2019-02-06 15:54 ` Laszlo Ersek
2019-02-13 6:13 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206121109.8776-14-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox