public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel@lists.01.org
Subject: [PATCH 08/14] ArmVirtPkg: don't set PcdDebugClearMemoryValue
Date: Wed,  6 Feb 2019 13:11:03 +0100	[thread overview]
Message-ID: <20190206121109.8776-9-lersek@redhat.com> (raw)
In-Reply-To: <20190206121109.8776-1-lersek@redhat.com>

According to the

  PCDs not used by modules or in conditional directives

sections of all the build reports for

  {AARCH64,ARM} x {Qemu,QemuKernel,Xen} x {RELEASE} x {feat-0,feat-1}

(12 builds in total), the PCD is not used in any of those builds.

Rather than just restrict the PCD setting to ($(TARGET) != RELEASE),
remove the setting completely. The current value is identical to the 0xAF
default in "MdePkg/MdePkg.dec", which recognizes Andrew Fish, and so it's
unlikely to ever change.

("feat-1" stands for "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D
SECURE_BOOT_ENABLE -D TTY_TERMINAL", while "feat-0" stands for "".)

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Julien Grall <julien.grall@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 ArmVirtPkg/ArmVirt.dsc.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 980cfa839027..0e4bcf728a4f 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -286,7 +286,6 @@ [PcdsFixedAtBuild.common]
   gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
   gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|1000000
   gEfiMdePkgTokenSpaceGuid.PcdSpinLockTimeout|10000000
-  gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue|0xAF
   gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|320
 
   # DEBUG_ASSERT_ENABLED       0x01
-- 
2.19.1.3.g30247aa5d201




  parent reply	other threads:[~2019-02-06 12:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06 12:10 [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs Laszlo Ersek
2019-02-06 12:10 ` [PATCH 01/14] ArmVirtPkg/ArmVirtQemuKernel: don't set PcdCPUCoresStackBase Laszlo Ersek
2019-02-06 12:10 ` [PATCH 02/14] ArmVirtPkg: don't set PcdRelocateVectorTable Laszlo Ersek
2019-02-06 12:10 ` [PATCH 03/14] ArmVirtPkg/{ArmVirtQemu, ArmVirtQemuKernel}: don't set PcdTrustzoneSupport Laszlo Ersek
2019-02-06 12:10 ` [PATCH 04/14] ArmVirtPkg: don't set PcdPostCodePropertyMask Laszlo Ersek
2019-02-06 12:11 ` [PATCH 05/14] ArmVirtPkg: clean up PcdSetNxForStack setting (applies to ArmVirtQemu only) Laszlo Ersek
2019-02-06 12:11 ` [PATCH 06/14] ArmVirtPkg/PrePi: drop wrong PcdCoreCount dependency Laszlo Ersek
2019-02-06 12:11 ` [PATCH 07/14] ArmVirtPkg: don't set PcdCoreCount Laszlo Ersek
2019-02-06 12:11 ` Laszlo Ersek [this message]
2019-02-06 12:11 ` [PATCH 09/14] ArmVirtPkg: don't set PcdDebugPrintErrorLevel in RELEASE builds Laszlo Ersek
2019-02-06 12:11 ` [PATCH 10/14] ArmVirtPkg/ArmVirtXen: don't set PcdPL031RtcBase Laszlo Ersek
2019-02-06 12:11 ` [PATCH 11/14] ArmVirtPkg/ArmVirtXen: don't set PcdTerminalTypeGuidBuffer Laszlo Ersek
2019-02-06 12:11 ` [PATCH 12/14] ArmVirtPkg/ArmVirtXen: don't set PcdShellFile Laszlo Ersek
2019-02-06 12:11 ` [PATCH 13/14] ArmVirtPkg/ArmVirtXen: don't set PcdTurnOffUsbLegacySupport Laszlo Ersek
2019-02-06 12:11 ` [PATCH 14/14] ArmVirtPkg/ArmVirtXen: don't set Pcd*ImageVerificationPolicy Laszlo Ersek
2019-02-06 15:46 ` [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs Ard Biesheuvel
2019-02-06 15:54   ` Laszlo Ersek
2019-02-13  6:13 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190206121109.8776-9-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox