[PATCH edk2-non-osi v1 0/7] Upload D0x binary modules

[PATCH edk2-non-osi v1 0/7] Upload D0x binary modules

[Ming Huang]

Main Changes :
1 Fix numa node wrong issue;
2 Use new flash layout;
3 Update RAS binary;
4 Rename StartupAp() function;
5 Optimize SAS driver for reducing boot time;

Code can also be found in github:
https://github.com/hisilicon/OpenPlatformPkg.git
branch: 1902-non-osi-v1


Ming Huang (7):
  Hisilicon/D06: Optimize SAS driver for reducing boot time
  Hisilicon/D0x: Rename StartupAp() function
  Hisilicon/D06: Update Mbigen and gic RAS register
  Hisilicon/D06: Support PCIe local RAS
  Hisilicon/D06: Use new flash layout
  Hisilicon/D06: Fix numa node wrong issue
  Hisilicon/D06: Add Setup Item "Support DPC"

 Platform/Hisilicon/D06/CustomData.Fv                                                   | Bin 0 -> 65536 bytes
 Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi                                 | Bin 232832 -> 226784 bytes
 Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi                       | Bin 21248 -> 22048 bytes
 Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi                               | Bin 17984 -> 18720 bytes
 Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex                                  | Bin 216 -> 36 bytes
 Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi                                    | Bin 221312 -> 220640 bytes
 Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib                   | Bin 61892 -> 31696 bytes
 Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi                                    | Bin 297696 -> 358656 bytes
 Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv                                               | Bin 1048576 -> 1048576 bytes
 Platform/Hisilicon/D06/bl1.bin                                                         | Bin 12432 -> 12432 bytes
 Platform/Hisilicon/D06/fip.bin                                                         | Bin 113450 -> 121866 bytes
 Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes
 Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes
 Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes
 14 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 Platform/Hisilicon/D06/CustomData.Fv

-- 
2.9.5

[PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time

[Ming Huang]

SAS controller is always existed, so accessing SAS register don't
depend on PciBusDxe (pci enumeration). Modify SAS driver remove the
dependence on pci enumeration.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
 Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex | Bin 216 -> 36 bytes
 Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi   | Bin 221312 -> 220640 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex
index 1a5bc1e..e076777 100644
Binary files a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex and b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex differ
diff --git a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi
index ac6bae7..4a29e8c 100644
Binary files a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi and b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi differ
-- 
2.9.5

Re: [PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time

[Leif Lindholm]

Change the subject line to:
Hisilicon/D06: remove PCI enumeration dependency from SAS driver

On Fri, Feb 01, 2019 at 10:25:01PM +0800, Ming Huang wrote:
> SAS controller is always existed, so accessing SAS register don't
> depend on PciBusDxe (pci enumeration). Modify SAS driver remove the
> dependence on pci enumeration.

And mention here that this is done to improve boot times.

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> ---
>  Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex | Bin 216 -> 36 bytes

What are the remaining depexes?
Do we have the opportunity to get rid of this .depex?

/
    Leif

>  Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi   | Bin 221312 -> 220640 bytes
>  2 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex
> index 1a5bc1e..e076777 100644
> Binary files a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex and b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex differ
> diff --git a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi
> index ac6bae7..4a29e8c 100644
> Binary files a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi and b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi differ
> -- 
> 2.9.5
> 

Re: [PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time

[Ming Huang]

On 2/12/2019 11:20 PM, Leif Lindholm wrote:
> Change the subject line to:
> Hisilicon/D06: remove PCI enumeration dependency from SAS driver
> 
> On Fri, Feb 01, 2019 at 10:25:01PM +0800, Ming Huang wrote:
>> SAS controller is always existed, so accessing SAS register don't
>> depend on PciBusDxe (pci enumeration). Modify SAS driver remove the
>> dependence on pci enumeration.
> 
> And mention here that this is done to improve boot times.
> 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> ---
>>  Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex | Bin 216 -> 36 bytes
> 
> What are the remaining depexes?
> Do we have the opportunity to get rid of this .depex?

SAS driver is depended on IoInitDxe, IoInitDxe use the variable server, so add
variable dependence to let SAS driver run after IoInitDxe.

> 
> /
>     Leif
> 
>>  Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi   | Bin 221312 -> 220640 bytes
>>  2 files changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex
>> index 1a5bc1e..e076777 100644
>> Binary files a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex and b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.depex differ
>> diff --git a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi
>> index ac6bae7..4a29e8c 100644
>> Binary files a/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi and b/Platform/Hisilicon/D06/Drivers/Sas/SasDriverDxe.efi differ
>> -- 
>> 2.9.5
>>

[PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

[Ming Huang]

As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
context. PI specifies 'BSP' for Boot-strap Processor, as the one
executing all of the EDK2 code. It then uses 'AP' to refer to
Additional Processors, which can be assigned tasks using the
EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be
'BSP'. So, Rename StartupAp() to StartUpBSP.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
 Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes
 Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes
 Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib
index 68be770..4c63a26 100644
Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ
diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib
index b3cc88e..cb2c652 100644
Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ
diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib
index 50d453a..d643f7b 100644
Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ
-- 
2.9.5

Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

[Leif Lindholm]

On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote:
> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
> context. PI specifies 'BSP' for Boot-strap Processor, as the one
> executing all of the EDK2 code. It then uses 'AP' to refer to
> Additional Processors, which can be assigned tasks using the
> EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be
> 'BSP'. So, Rename StartupAp() to StartUpBSP.

Please add a comment somewhere that this applies to D0x
PlatformSysCtrlLib.

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> ---
>  Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes
>  Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes
>  Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes
>  3 files changed, 0 insertions(+), 0 deletions(-)

These are substantial changes in image size from only changing the
name of a function. So I'll have a little look around.

1610 version appears to have switched from building with GCC49_RELEASE
to GCC48_RELEASE.
1616 and 1620 versions seem to have used GCC48_RELEASE all along.

I definitely see additional renamed functions in these libraries too.

Please have an inventory and determine what may be affecting image sizes.

Also, I *beg* you - please upgrade from "GNU C 4.8.3 20131202 (prerelease)".

/
    Leif

> 
> diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib
> index 68be770..4c63a26 100644
> Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ
> diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib
> index b3cc88e..cb2c652 100644
> Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ
> diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib
> index 50d453a..d643f7b 100644
> Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ
> -- 
> 2.9.5
> 

Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

[Ming Huang]

On 2/12/2019 5:36 AM, Leif Lindholm wrote:
> On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote:
>> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
>> context. PI specifies 'BSP' for Boot-strap Processor, as the one
>> executing all of the EDK2 code. It then uses 'AP' to refer to
>> Additional Processors, which can be assigned tasks using the
>> EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be
>> 'BSP'. So, Rename StartupAp() to StartUpBSP.
> 
> Please add a comment somewhere that this applies to D0x
> PlatformSysCtrlLib.

ok

> 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> ---
>>  Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes
>>  Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes
>>  Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes
>>  3 files changed, 0 insertions(+), 0 deletions(-)
> 
> These are substantial changes in image size from only changing the
> name of a function. So I'll have a little look around.
> 
> 1610 version appears to have switched from building with GCC49_RELEASE
> to GCC48_RELEASE.
> 1616 and 1620 versions seem to have used GCC48_RELEASE all along.
> 
> I definitely see additional renamed functions in these libraries too.
> 
> Please have an inventory and determine what may be affecting image sizes.
> 
> Also, I *beg* you - please upgrade from "GNU C 4.8.3 20131202 (prerelease)".

We have plan to upgrage gcc to 7.3, but our build server is share for all ARM
project, so need discuss with other project groups, it may be not enough time
for 19.02.

For D05/D03 libraries, just remove 2 functions from OemMiscLib which used
by PlatformSysCtrlLib. Does edk2 version effect the libraries size?
old edk2 base on: 2017-0904
now edk2 base on: 2018-0801

For D06 library, we use the same source code to support all Hi1620 projects,
include product projects,so there are some modify for this, like support
3 sockets, 4 sockets and remove some useless functions.

Thanks.

> 
> /
>     Leif
> 
>>
>> diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib
>> index 68be770..4c63a26 100644
>> Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ
>> diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib
>> index b3cc88e..cb2c652 100644
>> Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ
>> diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib
>> index 50d453a..d643f7b 100644
>> Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ
>> -- 
>> 2.9.5
>>

Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

[Leif Lindholm]

On Tue, Feb 12, 2019 at 04:05:50PM +0800, Ming Huang wrote:
> On 2/12/2019 5:36 AM, Leif Lindholm wrote:
> > On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote:
> >> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
> >> context. PI specifies 'BSP' for Boot-strap Processor, as the one
> >> executing all of the EDK2 code. It then uses 'AP' to refer to
> >> Additional Processors, which can be assigned tasks using the
> >> EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be
> >> 'BSP'. So, Rename StartupAp() to StartUpBSP.
> > 
> > Please add a comment somewhere that this applies to D0x
> > PlatformSysCtrlLib.
> 
> ok
> 
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> >> ---
> >>  Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes
> >>  Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes
> >>  Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes
> >>  3 files changed, 0 insertions(+), 0 deletions(-)
> > 
> > These are substantial changes in image size from only changing the
> > name of a function. So I'll have a little look around.
> > 
> > 1610 version appears to have switched from building with GCC49_RELEASE
> > to GCC48_RELEASE.
> > 1616 and 1620 versions seem to have used GCC48_RELEASE all along.
> > 
> > I definitely see additional renamed functions in these libraries too.
> > 
> > Please have an inventory and determine what may be affecting image sizes.
> > 
> > Also, I *beg* you - please upgrade from "GNU C 4.8.3 20131202 (prerelease)".
> 
> We have plan to upgrage gcc to 7.3, but our build server is share for all ARM
> project, so need discuss with other project groups, it may be not enough time
> for 19.02.

Oh, we're too late in the game to change for this release.
But you are using ancient toolchains with poor code generation and
quite likely known bugs.
And this has been the state for quite some time.
If that can change for 19.06, that's good enough.

> For D05/D03 libraries, just remove 2 functions from OemMiscLib which used
> by PlatformSysCtrlLib. Does edk2 version effect the libraries size?
> old edk2 base on: 2017-0904
> now edk2 base on: 2018-0801

Well, changing edk2 version will mean that command line options to
compiler and linker may change. So certainly some change can be seen.
But when the changes are this big, I suspect something else has been
going on.

> For D06 library, we use the same source code to support all Hi1620 projects,
> include product projects,so there are some modify for this, like support
> 3 sockets, 4 sockets and remove some useless functions.

So please reword the subject line of this commit to explain it is an
overall update of PlatformSysCtrlLib - including which bits are dropped.

And I think this makes a good argument for moving the header files for
binary-only libraries from edk2-platforms to edk2-non-osi.
If you do that in a separate patch before this one, you won't need to
include as much detail in the commit message as you will otherwise.

Regards,

Leif

> Thanks.
> 
> > 
> > /
> >     Leif
> > 
> >>
> >> diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib
> >> index 68be770..4c63a26 100644
> >> Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ
> >> diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib
> >> index b3cc88e..cb2c652 100644
> >> Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ
> >> diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib
> >> index 50d453a..d643f7b 100644
> >> Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ
> >> -- 
> >> 2.9.5
> >>

Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

[Ming Huang]

On 2/12/2019 6:44 PM, Leif Lindholm wrote:
> On Tue, Feb 12, 2019 at 04:05:50PM +0800, Ming Huang wrote:
>> On 2/12/2019 5:36 AM, Leif Lindholm wrote:
>>> On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote:
>>>> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
>>>> context. PI specifies 'BSP' for Boot-strap Processor, as the one
>>>> executing all of the EDK2 code. It then uses 'AP' to refer to
>>>> Additional Processors, which can be assigned tasks using the
>>>> EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be
>>>> 'BSP'. So, Rename StartupAp() to StartUpBSP.
>>>
>>> Please add a comment somewhere that this applies to D0x
>>> PlatformSysCtrlLib.
>>
>> ok
>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>>>> ---
>>>>  Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes
>>>>  Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes
>>>>  Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes
>>>>  3 files changed, 0 insertions(+), 0 deletions(-)
>>>
>>> These are substantial changes in image size from only changing the
>>> name of a function. So I'll have a little look around.
>>>
>>> 1610 version appears to have switched from building with GCC49_RELEASE
>>> to GCC48_RELEASE.
>>> 1616 and 1620 versions seem to have used GCC48_RELEASE all along.
>>>
>>> I definitely see additional renamed functions in these libraries too.
>>>
>>> Please have an inventory and determine what may be affecting image sizes.
>>>
>>> Also, I *beg* you - please upgrade from "GNU C 4.8.3 20131202 (prerelease)".
>>
>> We have plan to upgrage gcc to 7.3, but our build server is share for all ARM
>> project, so need discuss with other project groups, it may be not enough time
>> for 19.02.
> 
> Oh, we're too late in the game to change for this release.
> But you are using ancient toolchains with poor code generation and
> quite likely known bugs.
> And this has been the state for quite some time.
> If that can change for 19.06, that's good enough.

Ok, I will upgrade gcc from 4.8 for 19.06.

> 
>> For D05/D03 libraries, just remove 2 functions from OemMiscLib which used
>> by PlatformSysCtrlLib. Does edk2 version effect the libraries size?
>> old edk2 base on: 2017-0904
>> now edk2 base on: 2018-0801
> 
> Well, changing edk2 version will mean that command line options to
> compiler and linker may change. So certainly some change can be seen.
> But when the changes are this big, I suspect something else has been
> going on.

I also think it is strange for big size change.

> 
>> For D06 library, we use the same source code to support all Hi1620 projects,
>> include product projects,so there are some modify for this, like support
>> 3 sockets, 4 sockets and remove some useless functions.
> 
> So please reword the subject line of this commit to explain it is an
> overall update of PlatformSysCtrlLib - including which bits are dropped.
> 
> And I think this makes a good argument for moving the header files for
> binary-only libraries from edk2-platforms to edk2-non-osi.
> If you do that in a separate patch before this one, you won't need to
> include as much detail in the commit message as you will otherwise.

Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to edk2-non-osi?

> 
> Regards,
> 
> Leif
> 
>> Thanks.
>>
>>>
>>> /
>>>     Leif
>>>
>>>>
>>>> diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib
>>>> index 68be770..4c63a26 100644
>>>> Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ
>>>> diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib
>>>> index b3cc88e..cb2c652 100644
>>>> Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ
>>>> diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib
>>>> index 50d453a..d643f7b 100644
>>>> Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ
>>>> -- 
>>>> 2.9.5
>>>>

Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

[Leif Lindholm]

On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote:
> >> For D06 library, we use the same source code to support all Hi1620 projects,
> >> include product projects,so there are some modify for this, like support
> >> 3 sockets, 4 sockets and remove some useless functions.
> > 
> > So please reword the subject line of this commit to explain it is an
> > overall update of PlatformSysCtrlLib - including which bits are dropped.
> > 
> > And I think this makes a good argument for moving the header files for
> > binary-only libraries from edk2-platforms to edk2-non-osi.
> > If you do that in a separate patch before this one, you won't need to
> > include as much detail in the commit message as you will otherwise.
> 
> Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to edk2-non-osi?

Yes.

Any interfaces exposed _only_ by implementations in edk2-non-osi.
If there are any interfaces _also_ exposed by implementations in
edk2-platforms, then I would prefer for them to remain in
edk2-platforms.

Ideally, this would also include (the multiple) SerdesLib.h,
IpmiCmdLib.h, and possibly others.

Regards,

Leif

Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

[Ming Huang]

On 2/12/2019 8:17 PM, Leif Lindholm wrote:
> On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote:
>>>> For D06 library, we use the same source code to support all Hi1620 projects,
>>>> include product projects,so there are some modify for this, like support
>>>> 3 sockets, 4 sockets and remove some useless functions.
>>>
>>> So please reword the subject line of this commit to explain it is an
>>> overall update of PlatformSysCtrlLib - including which bits are dropped.
>>>
>>> And I think this makes a good argument for moving the header files for
>>> binary-only libraries from edk2-platforms to edk2-non-osi.
>>> If you do that in a separate patch before this one, you won't need to
>>> include as much detail in the commit message as you will otherwise.
>>
>> Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to edk2-non-osi?
> 
> Yes.
> 
> Any interfaces exposed _only_ by implementations in edk2-non-osi.
> If there are any interfaces _also_ exposed by implementations in
> edk2-platforms, then I would prefer for them to remain in
> edk2-platforms.
> 
> Ideally, this would also include (the multiple) SerdesLib.h,
> IpmiCmdLib.h, and possibly others.

Ok, I will do that in v2.

Thanks

> 
> Regards,
> 
> Leif
> 

[PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

[Ming Huang]

As chip group suggestions, update Mbigen and gic RAS configuration
flow.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
 Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi | Bin 17984 -> 18720 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi
index 19adbc9..9ea21e9 100644
Binary files a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi differ
-- 
2.9.5

Re: [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

[Leif Lindholm]

On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote:
> As chip group suggestions, update Mbigen and gic RAS configuration
> flow.

Update how?

/
    Leif

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> ---
>  Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi | Bin 17984 -> 18720 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi
> index 19adbc9..9ea21e9 100644
> Binary files a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi differ
> -- 
> 2.9.5
> 

Re: [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

[Ming Huang]

On 2/12/2019 5:38 AM, Leif Lindholm wrote:
> On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote:
>> As chip group suggestions, update Mbigen and gic RAS configuration
>> flow.
> 
> Update how?

Add below flow:
1 Reset Mbigen;
2 Disable Mbigen clock;
3 Deassert reset Mbigen;
4 Enable Mbigen clock;

Thanks.

> 
> /
>     Leif
> 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> ---
>>  Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi | Bin 17984 -> 18720 bytes
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi
>> index 19adbc9..9ea21e9 100644
>> Binary files a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi differ
>> -- 
>> 2.9.5
>>

Re: [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

[Leif Lindholm]

On Tue, Feb 12, 2019 at 07:42:55PM +0800, Ming Huang wrote:
> 
> 
> On 2/12/2019 5:38 AM, Leif Lindholm wrote:
> > On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote:
> >> As chip group suggestions, update Mbigen and gic RAS configuration
> >> flow.
> > 
> > Update how?
> 
> Add below flow:
> 1 Reset Mbigen;
> 2 Disable Mbigen clock;
> 3 Deassert reset Mbigen;
> 4 Enable Mbigen clock;

If you add that to commit message, that's good enough for me.

Regards,

Leif

> Thanks.
> 
> > 
> > /
> >     Leif
> > 
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> >> ---
> >>  Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi | Bin 17984 -> 18720 bytes
> >>  1 file changed, 0 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi
> >> index 19adbc9..9ea21e9 100644
> >> Binary files a/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi differ
> >> -- 
> >> 2.9.5
> >>

[PATCH edk2-non-osi v1 4/7] Hisilicon/D06: Support PCIe local RAS

[Ming Huang]

Add some registers configuration in PcieRasInitDxe and add PCIe
local RAS interrupt handle in trusted firmware to support PCIe
local RAS.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
 Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi | Bin 21248 -> 22048 bytes
 Platform/Hisilicon/D06/bl1.bin                                   | Bin 12432 -> 12432 bytes
 Platform/Hisilicon/D06/fip.bin                                   | Bin 113450 -> 121866 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi b/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi
index 0e22237..f9ceff2 100644
Binary files a/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi differ
diff --git a/Platform/Hisilicon/D06/bl1.bin b/Platform/Hisilicon/D06/bl1.bin
index 416535f..d0970e5 100644
Binary files a/Platform/Hisilicon/D06/bl1.bin and b/Platform/Hisilicon/D06/bl1.bin differ
diff --git a/Platform/Hisilicon/D06/fip.bin b/Platform/Hisilicon/D06/fip.bin
index c9b7ca0..795cfb5 100644
Binary files a/Platform/Hisilicon/D06/fip.bin and b/Platform/Hisilicon/D06/fip.bin differ
-- 
2.9.5

Re: [PATCH edk2-non-osi v1 4/7] Hisilicon/D06: Support PCIe local RAS

[Leif Lindholm]

On Fri, Feb 01, 2019 at 10:25:04PM +0800, Ming Huang wrote:
> Add some registers configuration in PcieRasInitDxe and add PCIe
> local RAS interrupt handle in trusted firmware to support PCIe
> local RAS.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi | Bin 21248 -> 22048 bytes
>  Platform/Hisilicon/D06/bl1.bin                                   | Bin 12432 -> 12432 bytes
>  Platform/Hisilicon/D06/fip.bin                                   | Bin 113450 -> 121866 bytes
>  3 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi b/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi
> index 0e22237..f9ceff2 100644
> Binary files a/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi differ
> diff --git a/Platform/Hisilicon/D06/bl1.bin b/Platform/Hisilicon/D06/bl1.bin
> index 416535f..d0970e5 100644
> Binary files a/Platform/Hisilicon/D06/bl1.bin and b/Platform/Hisilicon/D06/bl1.bin differ
> diff --git a/Platform/Hisilicon/D06/fip.bin b/Platform/Hisilicon/D06/fip.bin
> index c9b7ca0..795cfb5 100644
> Binary files a/Platform/Hisilicon/D06/fip.bin and b/Platform/Hisilicon/D06/fip.bin differ
> -- 
> 2.9.5
> 

[PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout

[Ming Huang]

In new flash layout, BIOS fd change from offset 1M to 8M in 16M
spi flash.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
 Platform/Hisilicon/D06/CustomData.Fv                                 | Bin 0 -> 65536 bytes
 Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib | Bin 61892 -> 31696 bytes
 Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv                             | Bin 1048576 -> 1048576 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D06/CustomData.Fv b/Platform/Hisilicon/D06/CustomData.Fv
new file mode 100644
index 0000000..22ef62b
Binary files /dev/null and b/Platform/Hisilicon/D06/CustomData.Fv differ
diff --git a/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib b/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib
index 7e1f6b2..851c2c3 100644
Binary files a/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib and b/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib differ
diff --git a/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv b/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv
index 247e44e..7f75bc6 100644
Binary files a/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv and b/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv differ
-- 
2.9.5

Re: [PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout

[Leif Lindholm]

On Fri, Feb 01, 2019 at 10:25:05PM +0800, Ming Huang wrote:
> In new flash layout, BIOS fd change from offset 1M to 8M in 16M
> spi flash.

I think I covered all of the layout questions in the corresponding
edk2-platforms patch.

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> ---
>  Platform/Hisilicon/D06/CustomData.Fv                                 | Bin 0 -> 65536 bytes
>  Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib | Bin 61892 -> 31696 bytes

But can you explain why the size of this lib is _halved_?

/
    Leif

>  Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv                             | Bin 1048576 -> 1048576 bytes
>  3 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D06/CustomData.Fv b/Platform/Hisilicon/D06/CustomData.Fv
> new file mode 100644
> index 0000000..22ef62b
> Binary files /dev/null and b/Platform/Hisilicon/D06/CustomData.Fv differ
> diff --git a/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib b/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib
> index 7e1f6b2..851c2c3 100644
> Binary files a/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib and b/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib differ
> diff --git a/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv b/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv
> index 247e44e..7f75bc6 100644
> Binary files a/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv and b/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv differ
> -- 
> 2.9.5
> 

Re: [PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout

[Ming Huang]

On 2/12/2019 11:26 PM, Leif Lindholm wrote:
> On Fri, Feb 01, 2019 at 10:25:05PM +0800, Ming Huang wrote:
>> In new flash layout, BIOS fd change from offset 1M to 8M in 16M
>> spi flash.
> 
> I think I covered all of the layout questions in the corresponding
> edk2-platforms patch.
> 
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> ---
>>  Platform/Hisilicon/D06/CustomData.Fv                                 | Bin 0 -> 65536 bytes
>>  Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib | Bin 61892 -> 31696 bytes
> 
> But can you explain why the size of this lib is _halved_?

This library had delete some useless functions and global variables.

Thanks

> 
> /
>     Leif
> 
>>  Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv                             | Bin 1048576 -> 1048576 bytes
>>  3 files changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/Platform/Hisilicon/D06/CustomData.Fv b/Platform/Hisilicon/D06/CustomData.Fv
>> new file mode 100644
>> index 0000000..22ef62b
>> Binary files /dev/null and b/Platform/Hisilicon/D06/CustomData.Fv differ
>> diff --git a/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib b/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib
>> index 7e1f6b2..851c2c3 100644
>> Binary files a/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib and b/Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.lib differ
>> diff --git a/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv b/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv
>> index 247e44e..7f75bc6 100644
>> Binary files a/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv and b/Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv differ
>> -- 
>> 2.9.5
>>

[PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue

[Ming Huang]

Numa informations are acquired from HOB that build from memory
initialization module. Correct numa informations to match booting
from TA(Totem A or super cpu cluster A).

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
 Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi | Bin 297696 -> 358656 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi
index 5fba353..fea1475 100644
Binary files a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi differ
-- 
2.9.5

Re: [PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue

[Leif Lindholm]

*bangs head on desk*

That question I just asked as a reply to
("Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot")
was meant to be a comment on this patch.

So - was this change one that was meant to happen together with
edk2-platforms "Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot"?

What is the user visible behaviour that this change addresses?

/
    Leif

On Fri, Feb 01, 2019 at 10:25:06PM +0800, Ming Huang wrote:
> Numa informations are acquired from HOB that build from memory
> initialization module. Correct numa informations to match booting
> from TA(Totem A or super cpu cluster A).
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> ---
>  Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi | Bin 297696 -> 358656 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi
> index 5fba353..fea1475 100644
> Binary files a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi differ
> -- 
> 2.9.5
> 

Re: [PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue

[Ming Huang]

On 2/11/2019 10:48 PM, Leif Lindholm wrote:
> *bangs head on desk*
> 
> That question I just asked as a reply to
> ("Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot")
> was meant to be a comment on this patch.
> 
> So - was this change one that was meant to happen together with
> edk2-platforms "Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot"?

Yes, it is better to happen together with that patch.

> 
> What is the user visible behaviour that this change addresses?

Numa info of kernel boot is different:
Use old MemoryInit.efi:
[    0.000000] ACPI: SRAT: Node 1 PXM 0 [mem 0x2080000000-0x23ffffffff]
[    0.000000] ACPI: SRAT: Node 1 PXM 0 [mem 0x00000000-0x7fffffff]
[    0.000000] ACPI: SRAT: Node 3 PXM 2 [mem 0xa2000000000-0xa23ffffffff]
Use new MemoryInit.efi:
[    0.000000] ACPI: SRAT: Node 1 PXM 1 [mem 0x2080000000-0x23ffffffff]
[    0.000000] ACPI: SRAT: Node 1 PXM 1 [mem 0x00000000-0x7fffffff]
[    0.000000] ACPI: SRAT: Node 3 PXM 3 [mem 0xa2000000000-0xa23ffffffff]o

Thanks.

> 
> /
>     Leif
> 
> On Fri, Feb 01, 2019 at 10:25:06PM +0800, Ming Huang wrote:
>> Numa informations are acquired from HOB that build from memory
>> initialization module. Correct numa informations to match booting
>> from TA(Totem A or super cpu cluster A).
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> ---
>>  Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi | Bin 297696 -> 358656 bytes
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi
>> index 5fba353..fea1475 100644
>> Binary files a/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D06/MemoryInitPei/MemoryInit.efi differ
>> -- 
>> 2.9.5
>>

[PATCH edk2-non-osi v1 7/7] Hisilicon/D06: Add Setup Item "Support DPC"

[Ming Huang]

Add setup item "Support DPC" to enable or disable PCIe DPC
(Downstream Port Containment).

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>
---
 Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi | Bin 232832 -> 226784 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi b/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi
index e32c056..4511f6b 100644
Binary files a/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi differ
-- 
2.9.5

Re: [PATCH edk2-non-osi v1 7/7] Hisilicon/D06: Add Setup Item "Support DPC"

[Leif Lindholm]

On Fri, Feb 01, 2019 at 10:25:07PM +0800, Ming Huang wrote:
> Add setup item "Support DPC" to enable or disable PCIe DPC
> (Downstream Port Containment).
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi | Bin 232832 -> 226784 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi b/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi
> index e32c056..4511f6b 100644
> Binary files a/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi and b/Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi differ
> -- 
> 2.9.5
>