From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 11664208F60FC for ; Mon, 11 Feb 2019 06:54:39 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id l9so4979480wrt.13 for ; Mon, 11 Feb 2019 06:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oa87JAABav+YoVh+D7qanphWUF9L/MI69M6q9phcfmw=; b=JNQ9ldE/Z2WO81YFB2KbquYngh0MJAzk4DGhM4uePBpjUj5dQ31F5uJcoGbzt+8nuh BMkxBMuLXUMfId2AIX69b+CNTcQmjtvGxuB9Lj5rqb5JerX69ghS4JUesk2/am2wUsG3 2bnLdgM4WbwhVe9yjLdwCRujt4KHqxKB7sovN+wFoH2iv2//m2nQgNe70b6WhrCqMNzG C+LCu+034TdN7zISvY1gFJONKF9kdBP61GCBgy+LOTmHkJ+dmy6gNiBJDKPqePzDrtZR UH/9OXq3sEyR1bWEC/7tkZYzf7+2iAzdV39UtPEvito18eZBn28HHy0e4Jrvn5lEFgsQ APVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oa87JAABav+YoVh+D7qanphWUF9L/MI69M6q9phcfmw=; b=D+Qc4nV/zoNzBVssFBuaOijeqQaGAKKGCGyvEUz4ww0dymq/5XVGsSo3HEV4zZMxQ/ PDftMbm7Y+ltncTWMGqfJu55UN68/LpGdLDnDZ1JWp17M9TSKffzt0YLNwIzbLjHEp5k zsfF6boHr9vMH/igOftB9jH6kw4Lwvm5uz78u8n4d6iTp/DAu3zS1ENQU4VDACPPLnqJ E5O1K3MqmycMViZCdBDdDO4tKIekezF6ELqy8KsFnopt9NLNkqNF7tQhKmDyOc9rK4K1 Q8OVvb3mc/sPeLLu0Y0mpAPk8a788QzzhMP9NHR/Ri53GhU66HSp61ldWbSk4SUDttE5 9f1g== X-Gm-Message-State: AHQUAuav4L/jj7oGXeTBAjMkabTZ6D9VNzLUcOpi/6GWUEvPIYXCdOZ2 AlbYnpwl8zb9nXC7iajdA5vDzg== X-Google-Smtp-Source: AHgI3IYlQ51F3Vp/6ddS1EfYoXEaRIRdDYlgRjW9lkYmSrIDnQPhdv7PJYOObxMQby9UNX1ffv9rmw== X-Received: by 2002:adf:e949:: with SMTP id m9mr12820305wrn.1.1549896878374; Mon, 11 Feb 2019 06:54:38 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e27sm22018712wra.67.2019.02.11.06.54.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 06:54:37 -0800 (PST) Date: Mon, 11 Feb 2019 14:54:36 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190211145436.arcms5iqpu6vah7f@bivouac.eciton.net> References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-13-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190201133436.10500-13-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 12/16] Hisilicon/D06: Use new flash layout X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 14:54:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 01, 2019 at 09:34:32PM +0800, Ming Huang wrote: > In new flash layout, BIOS fd change from offset 1M to 8M in 16M > spi flash. This bit > Use the new CustomData.Fv which indicate the offset > of fd and which flash area can be updated for BMC. is of critical importance. Should be its own paragraph. How does this change affect variable storage? Will the server maintain state after a firmware upgrade, or will the operator need to rescue it manually via the BMC? / Leif > > This patch is relative with patch "Use new flash layout" in > edk2-non-osi. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.fdf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf > index d495ad7f264c..f72b513352fb 100644 > --- a/Platform/Hisilicon/D06/D06.fdf > +++ b/Platform/Hisilicon/D06/D06.fdf > @@ -29,7 +29,7 @@ [DEFINES] > ################################################################################ > [FD.D06] > > -BaseAddress = 0x204100000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base address of the Firmware in NOR Flash. > +BaseAddress = 0x204800000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base address of the Firmware in NOR Flash. > > Size = 0x00400000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the FLASH Device > ErasePolarity = 1 > @@ -124,7 +124,7 @@ [FD.D06] > 0x003E0000|0x00010000 > > 0x003F0000|0x00010000 > -FILE = Platform/Hisilicon/D0x-CustomData.Fv > +FILE = Platform/Hisilicon/D06/CustomData.Fv > > ################################################################################ > # > -- > 2.9.5 >