From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F3F96208F60FC for ; Mon, 11 Feb 2019 07:05:09 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id x10so5063138wrs.8 for ; Mon, 11 Feb 2019 07:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vkPC8TdJJ0JhDlM4mpnQ6qVcGR5I7zUl3VRxr1g16I8=; b=MB3zimTH7JmuRrvKTlPnF9Bl/moIkrdRMoygJbKF2aeGHH6Rq/TKbWKjLpJdBgIs2G ZVmzPHW1tH8H42rA0odshjSsGkISR51VO6APa+M7VU2nvtmiFVXuvSqrGJth1cwZR4XC n3RkIBV76URnU0bBjN9Y89K5mDkcstpbN5rGLXxrRoyqQ2THhEFN5m4zuNgZYhovKvZO wRclWsXa4hZhwxmmqkgewo3Xyif2NaqfCz5OPMoBAaBheyNmlGmHtvBaw9hI3Opz7w77 N3Ht65rFqP2dUbnMvph3r1E1vkuMpUOTcYddYdz5l4JKjvMR7NlojdDql2LesDMWFi5T PjEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vkPC8TdJJ0JhDlM4mpnQ6qVcGR5I7zUl3VRxr1g16I8=; b=PoEgLJ9mqhCW8ZnV6pqBEJFWan/CH0TSDsZ/T7hXdtM/nVMjNr0GFKvdc/gPl2k/XK aoWM4Q45iw7lLduKoql8KyeMVp7MV7d8zisb0hhdnOw54iujsMcihgXm5BE52E2YYdP8 HokJg8MqcNQjpbL9Y0dxuNvALAy2FuaEhaJm4ir5Rr1YzbUr+MnGdhQECMINE7+YtVi4 KBfbr2QkECuFPSNDcB5lnPeqFav04fR4miwK07lqXEjsao1wgVhkfAOOPyGmudwPLZjG yiS+auHz1VZ/2y3No8ktIJ9+YnoVQX/m5lZ5z3fOk3jSrBk2G3gEKxh0aCd6uSIQyyZE zbFA== X-Gm-Message-State: AHQUAualB4SNdjsDlVx44YP7CHCmnI0iWjVonxA96EWX38aF32uUg7hj jYzl6t0+btt7jFrlFMlQ1mm38g== X-Google-Smtp-Source: AHgI3IZRQt963ElL12SeZN7AOk13M1lvsRPyPD/mGm4p/m5nPCi5R5Q3tW3eyzHsnKKxhPsiYiz+iQ== X-Received: by 2002:adf:ef4a:: with SMTP id c10mr414564wrp.180.1549897508045; Mon, 11 Feb 2019 07:05:08 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y1sm13818889wru.4.2019.02.11.07.05.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 07:05:07 -0800 (PST) Date: Mon, 11 Feb 2019 15:05:05 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190211150505.h7itd4fqvrfazeqs@bivouac.eciton.net> References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-2-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190201133436.10500-2-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 15:05:11 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 01, 2019 at 09:34:21PM +0800, Ming Huang wrote: > SerdesLib is useless for SmbiosMiscDxe and D06, so remove it. Should it not then also delete #include from Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c ? Meanwhile, Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c and Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c both include this header, but Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf and Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.inf do not declare the dependency. Can you investigate and submit an updated patch addressing all of the unnecessary references? Best Regards, Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.dsc | 2 -- > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index 396bd03c9d24..cbbd99e4a659 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -64,8 +64,6 @@ [LibraryClasses.common] > > CpldIoLib|Silicon/Hisilicon/Library/CpldIoLib/CpldIoLib.inf > > - SerdesLib|Silicon/Hisilicon/Hi1620/Library/Hi1620Serdes/Hi1620SerdesLib.inf > - > TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > RealTimeClockLib|Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf > OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf > diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > index 61cead7779b9..8e5c56fa41fd 100644 > --- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > +++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > @@ -77,7 +77,6 @@ [LibraryClasses] > > IpmiCmdLib > > - SerdesLib > > [Protocols] > gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED > -- > 2.9.5 >