* [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h
@ 2019-02-11 18:02 Leif Lindholm
2019-02-11 18:03 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2019-02-11 18:02 UTC (permalink / raw)
To: edk2-devel
Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
.vfr rather than local definitions.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
.../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
index 8a395eac68..25b7b49a3d 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
@@ -15,14 +15,7 @@
#include <Guid/HiiPlatformSetupFormset.h>
#include <Guid/SynQuacerPlatformFormSet.h>
#include <Platform/VarStore.h>
-
-//
-// EFI Variable attributes
-//
-#define EFI_VARIABLE_NON_VOLATILE 0x00000001
-#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002
-#define EFI_VARIABLE_RUNTIME_ACCESS 0x00000004
-#define EFI_VARIABLE_READ_ONLY 0x00000008
+#include <Uefi/UefiMultiPhase.h>
formset
guid = SYNQUACER_PLATFORM_FORMSET_GUID,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h
2019-02-11 18:02 [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h Leif Lindholm
@ 2019-02-11 18:03 ` Ard Biesheuvel
2019-02-11 19:06 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2019-02-11 18:03 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On Mon, 11 Feb 2019 at 19:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
> .vfr rather than local definitions.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> index 8a395eac68..25b7b49a3d 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> @@ -15,14 +15,7 @@
> #include <Guid/HiiPlatformSetupFormset.h>
> #include <Guid/SynQuacerPlatformFormSet.h>
> #include <Platform/VarStore.h>
> -
> -//
> -// EFI Variable attributes
> -//
> -#define EFI_VARIABLE_NON_VOLATILE 0x00000001
> -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002
> -#define EFI_VARIABLE_RUNTIME_ACCESS 0x00000004
> -#define EFI_VARIABLE_READ_ONLY 0x00000008
> +#include <Uefi/UefiMultiPhase.h>
>
> formset
> guid = SYNQUACER_PLATFORM_FORMSET_GUID,
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h
2019-02-11 18:03 ` Ard Biesheuvel
@ 2019-02-11 19:06 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2019-02-11 19:06 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Mon, Feb 11, 2019 at 07:03:09PM +0100, Ard Biesheuvel wrote:
> On Mon, 11 Feb 2019 at 19:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
> > .vfr rather than local definitions.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks, pushed as d7b29975f8.
> > ---
> > .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> > index 8a395eac68..25b7b49a3d 100644
> > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> > @@ -15,14 +15,7 @@
> > #include <Guid/HiiPlatformSetupFormset.h>
> > #include <Guid/SynQuacerPlatformFormSet.h>
> > #include <Platform/VarStore.h>
> > -
> > -//
> > -// EFI Variable attributes
> > -//
> > -#define EFI_VARIABLE_NON_VOLATILE 0x00000001
> > -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002
> > -#define EFI_VARIABLE_RUNTIME_ACCESS 0x00000004
> > -#define EFI_VARIABLE_READ_ONLY 0x00000008
> > +#include <Uefi/UefiMultiPhase.h>
> >
> > formset
> > guid = SYNQUACER_PLATFORM_FORMSET_GUID,
> > --
> > 2.11.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-11 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-11 18:02 [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h Leif Lindholm
2019-02-11 18:03 ` Ard Biesheuvel
2019-02-11 19:06 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox