From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 21AFB2194D3AE for ; Mon, 11 Feb 2019 10:04:47 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id r17so156731wmh.5 for ; Mon, 11 Feb 2019 10:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DUlrS0LHn3jL0RCmpIu3iq0nohm+FASM6d/jyMn0Qpc=; b=pxebNw6BSBe0Nsvu3XrntKyIpY3jE2VHAhNEknxNjDCkG8abGqkqEPwiFf//KZwUU5 Z0CmaAdl+wJOe3u9xJYoCssIoygBzHk7RM4WbZvD8c7epXTiqa+/s22E8Dgagp3/tZcV bGslOQNNskY8pAnfrfHHswPsu1w2KeiYabv4a7KWH/Xoo0CQz5dxejS7fDsquy8c14r1 WlWATt4P+QgSzFBNkDhNDidoeA29Up62fOE88h7c7UCTQx/VPLDO2TLzggliEpC2oTpu 8n2Zbu2N0T4hnf/uuwIfKdVJR+cFzLfwUHnbe/rUHYJpU38Zy/CR8w6sDzwwGPuh1NRb gp3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DUlrS0LHn3jL0RCmpIu3iq0nohm+FASM6d/jyMn0Qpc=; b=C9/Kgkbc6iYUbpSAJtbrcMQmi1+UMPlvHyrYhqm9aeC9+revlX6N5z4P2u6ANZ2KbV moAi8OHpN4bL6bOXWdAxe7u1fRTSmVTxvMhZAAAHunnXtTvCLh9Do6bXPt7Gj/vmPOiK qocVyXifu6hsBsjxmOYPMWbQqnwFzK8gA+NG3qD6UdfXQxuC6nWt6ZTFkRgxJxfVeFDK ZwNAckOYSEtjK8C9A/fhSdxlfIaEiahbX5TId6K3YJUIzRW+IL7zmaQY1FOPfh8M+BlP pMer7ZO8ESzK2Xtv6IXJAxdwc8kVGHVut4fhp4psf64g79MA3PGmtgDV2pIqFVAJcTMa I9+g== X-Gm-Message-State: AHQUAuYPVW7o1Mccixs7OFIgugdcnNULP7Dw6kXKv3AemV3UCtU/rw5Y SrMW+wwiBiOiaUcrznDc4ARkuw== X-Google-Smtp-Source: AHgI3IY23gHfW2xcPSonqi1Zm9P5h88VilUzdSI6huTRQPrpVrbbGPbDiUACAwJFCr4kZPNn0OfEJw== X-Received: by 2002:a1c:8088:: with SMTP id b130mr550590wmd.96.1549908286274; Mon, 11 Feb 2019 10:04:46 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e9sm22113821wrc.56.2019.02.11.10.04.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 10:04:45 -0800 (PST) Date: Mon, 11 Feb 2019 18:04:43 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190211180443.4tdlwlz3hx6wlmtz@bivouac.eciton.net> References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-8-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190201133436.10500-8-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 07/16] Hisilicon/D0x: Rename StartupAp() function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 18:04:48 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 01, 2019 at 09:34:27PM +0800, Ming Huang wrote: > As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 > context. PI specifies 'BSP' for Boot-strap Processor, as the one > executing all of the EDK2 code. It then uses 'AP' to refer to > Additional Processors, which can be assigned tasks using the > EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be 'BSP'. > So, Rename StartupAp() to StartUpBSP. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm Thanks! > --- > Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h | 2 +- > Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.c | 2 +- > Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c | 2 +- > Platform/Hisilicon/D05/EarlyConfigPeim/EarlyConfigPeimD05.c | 2 +- > Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.c | 3 ++- > Platform/Hisilicon/D06/EarlyConfigPeim/EarlyConfigPeimD06.c | 2 +- > 6 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > index a232e52ed719..712b77c44fc8 100644 > --- a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > +++ b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > @@ -76,7 +76,7 @@ VOID MN_CONFIG (VOID); > VOID SmmuConfigForOS (VOID); > VOID SmmuConfigForBios (VOID); > > -VOID StartupAp (VOID); > +VOID StartUpBSP (VOID); > > VOID LlcCleanInvalidate (VOID); > > diff --git a/Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.c b/Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.c > index 97cf6b8d8757..dacd9e871faf 100644 > --- a/Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.c > +++ b/Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.c > @@ -83,7 +83,7 @@ void QResetAp(VOID) > //SCCL A > if (!PcdGet64 (PcdTrustedFirmwareEnable)) > { > - StartupAp(); > + StartUpBSP (); > } > } > > diff --git a/Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c b/Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c > index b57fdfa68e45..c8a9da73bbca 100644 > --- a/Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c > +++ b/Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c > @@ -133,7 +133,7 @@ VOID CoreSelectBoot(VOID) > { > if (!PcdGet64 (PcdTrustedFirmwareEnable)) > { > - StartupAp (); > + StartUpBSP (); > } > > return; > diff --git a/Platform/Hisilicon/D05/EarlyConfigPeim/EarlyConfigPeimD05.c b/Platform/Hisilicon/D05/EarlyConfigPeim/EarlyConfigPeimD05.c > index 76a055cbe980..b374347e5c4d 100644 > --- a/Platform/Hisilicon/D05/EarlyConfigPeim/EarlyConfigPeimD05.c > +++ b/Platform/Hisilicon/D05/EarlyConfigPeim/EarlyConfigPeimD05.c > @@ -35,7 +35,7 @@ QResetAp ( > (VOID)WriteBackInvalidateDataCacheRange((VOID *) FixedPcdGet64(PcdMailBoxAddress), 8); > > if (!PcdGet64 (PcdTrustedFirmwareEnable)) { > - StartupAp(); > + StartUpBSP (); > } > } > > diff --git a/Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.c b/Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.c > index 4c4c944dbead..a1458da7f0a3 100644 > --- a/Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.c > +++ b/Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.c > @@ -96,7 +96,7 @@ UINTN OemGetDimmSlot(UINTN Socket, UINTN Channel) > VOID CoreSelectBoot(VOID) > { > if (!PcdGet64 (PcdTrustedFirmwareEnable)) { > - StartupAp (); > + StartUpBSP (); > } > > return; > @@ -128,3 +128,4 @@ BOOLEAN OemIsNeedDisableExpanderBuffer(VOID) > { > return TRUE; > } > + > diff --git a/Platform/Hisilicon/D06/EarlyConfigPeim/EarlyConfigPeimD06.c b/Platform/Hisilicon/D06/EarlyConfigPeim/EarlyConfigPeimD06.c > index 0790f7941ae7..a8261d370626 100644 > --- a/Platform/Hisilicon/D06/EarlyConfigPeim/EarlyConfigPeimD06.c > +++ b/Platform/Hisilicon/D06/EarlyConfigPeim/EarlyConfigPeimD06.c > @@ -78,7 +78,7 @@ QResetAp ( > > //SCCL A > if (!PcdGet64 (PcdTrustedFirmwareEnable)) { > - StartupAp (); > + StartUpBSP (); > } > } > > -- > 2.9.5 >