From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D83EA208D6137 for ; Mon, 11 Feb 2019 11:06:50 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id f14so21540wrg.1 for ; Mon, 11 Feb 2019 11:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6obHrufZKBuaDlTaWAyXkc/6IrKvrTz64LMrYbCyXIQ=; b=BldkKtpi9fXGcJurSyn72k/tLQ3uuBJ9Wyw/Z7SsdKs57kUuv0wx/1okvmetu7DRb5 9ud+KQoDuSgXnN2Gb7AVMFIErsfKkRvF/+lZ8kC+pOYqDQ0y5vg+CyIsVWlIp9o1sVfu eO8ZO+LLyxdLXVOvcd7alDPFPaCz3/n/1nRaMzksJci5cVT6rw4QCq6tR4g4wN+HqQN5 52f+n1JvCKYbXJNono08tC4XwbcLhmkdUWgHAjgiccJA06/pO3sxqP/6HJxF/gmOoNtx crOk0Mf0Q28PvQiLN6xeDUy9u3kx+fo/CDXATrWk5Ze8JXPjM0VM2Px+QNE9DluQa0r+ zE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6obHrufZKBuaDlTaWAyXkc/6IrKvrTz64LMrYbCyXIQ=; b=jj4JFcrXp7haq9MW3+rzljIm7bS4ajQ4K0jX8o4dGlNaxq4On9Chrlvb+7qG8jAfqt ZWusfV55WmEmBHFomB1Yob6I/Uv3bEOAclx95oPZgyR/fa5OOrJo6HMzAbwepi9MEbpz xQx2fIKvmbOu9jRkos5ettaPPWSVl2PYAhheywHEB5OVTpHUM3Vs0oER871hhJVkIVh/ yP/cTB/T5ST59J87BTEZ5FZRRVSIlNuizWWTsuzzpcGHpSpTAqomYs8AbKBLwiH0wIpQ 0YRYpLmg4rsjyGDuYG9aXS3m775KE/R3nelUS9mpMRfZjuzRC05tUTNorZLyAClPoQTf wH8Q== X-Gm-Message-State: AHQUAuZe+DznYoCClsdn2UxhdIRHYab75uRE7iElGMoFLhqFqA0uMtpj XnQGWLlbUnJSveEkNpaD85BQg5ER4EA= X-Google-Smtp-Source: AHgI3IY85ysCzkforQKo/n3TyBOQ63cWyUFAdP5NBCdqqQL5cWJAi9zXt+RGXW4X8zMfoTBkwTfVOg== X-Received: by 2002:a5d:6850:: with SMTP id o16mr29450356wrw.123.1549912008822; Mon, 11 Feb 2019 11:06:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id i16sm2537205wru.16.2019.02.11.11.06.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 11:06:47 -0800 (PST) Date: Mon, 11 Feb 2019 19:06:41 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20190211190641.o24nax34adyvvict@bivouac.eciton.net> References: <20190211180202.991-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 19:06:51 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 11, 2019 at 07:03:09PM +0100, Ard Biesheuvel wrote: > On Mon, 11 Feb 2019 at 19:02, Leif Lindholm wrote: > > > > Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe > > .vfr rather than local definitions. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Thanks, pushed as d7b29975f8. > > --- > > .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 9 +-------- > > 1 file changed, 1 insertion(+), 8 deletions(-) > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > > index 8a395eac68..25b7b49a3d 100644 > > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > > @@ -15,14 +15,7 @@ > > #include > > #include > > #include > > - > > -// > > -// EFI Variable attributes > > -// > > -#define EFI_VARIABLE_NON_VOLATILE 0x00000001 > > -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002 > > -#define EFI_VARIABLE_RUNTIME_ACCESS 0x00000004 > > -#define EFI_VARIABLE_READ_ONLY 0x00000008 > > +#include > > > > formset > > guid = SYNQUACER_PLATFORM_FORMSET_GUID, > > -- > > 2.11.0 > >