public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacer/Stage2Tables: fix build for cross compile from x86
Date: Mon, 11 Feb 2019 19:07:29 +0000	[thread overview]
Message-ID: <20190211190729.6nwdyqzeuom5fgvm@bivouac.eciton.net> (raw)
In-Reply-To: <20190211183322.23133-1-ard.biesheuvel@linaro.org>

On Mon, Feb 11, 2019 at 07:33:22PM +0100, Ard Biesheuvel wrote:
> AArch64 binutils support AArch32 seamlessly when running natively,
> which allowed us to drop the -I objcopy argument specifying that
> the input format is elf64-little, which is no longer accurate now
> that the module can be built in 32-bit mode as well (which makes no
> difference whatsoever given that the resulting binary image is only
> a set of stage2 page tables)
> 
> The same does not apply to binutils hosted on x86, so add back the
> appropriate input format depending on the target type.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Acked-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf b/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf
> index f845015b9002..3e7039d586e1 100644
> --- a/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf
> +++ b/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf
> @@ -26,6 +26,8 @@ [Sources]
>  [BuildOptions]
>    *_*_*_OBJCOPY_PATH == objcopy
>    *_*_*_OBJCOPY_FLAGS == -O binary -j .rodata
> +  *_*_AARCH64_OBJCOPY_FLAGS = -I elf64-little
> +  *_*_ARM_OBJCOPY_FLAGS = -I elf32-little
>    *_*_*_ASM_FLAGS == -nostdlib -Wl,-e,0x81f8000,--section-start=.rodata=0x81f8000
>    *_CLANG35_*_ASM_FLAGS = -no-integrated-as
>    *_CLANG38_*_ASM_FLAGS = -no-integrated-as
> -- 
> 2.20.1
> 


  reply	other threads:[~2019-02-11 19:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 18:33 [PATCH edk2-platforms] Silicon/SynQuacer/Stage2Tables: fix build for cross compile from x86 Ard Biesheuvel
2019-02-11 19:07 ` Leif Lindholm [this message]
2019-02-15 10:49   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211190729.6nwdyqzeuom5fgvm@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox