From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E954B208AE9B6 for ; Mon, 11 Feb 2019 11:07:32 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id q18so5955271wrx.9 for ; Mon, 11 Feb 2019 11:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uLqFevdRKdX3fFADjGlDweftzD11V/LJgrH1Eo1lgTk=; b=hztmb0OSdRvcdrukL7FPqEVR05CsazjlVx+F1PiOIUTxFQCXAl1uiW5VxBXBlgENuP SEuBoiLbJMKgYVRVk2RwEzvjjln09D+cb1ju36KVXgxmJKbmfgm75ZmHcr/rOWMFRzZ5 xd1EprwP9jNdZ37Aw6aI1UCG6yKSUp+PyiNfSERpuFE69vxthuu1GLVp+HiBuW+NJ076 fjOu68hQkd4HLS0g7XHN0Fa+y97U+VufK6EMH/E/4Ym0DzNOELNN3HiL7NFxiSgIMRXL s4/pzay/xUKOe9szsE0tNsHNttFap2q+yR8Rg6kILOT5kASj66TnMRR6s6xXPaNPP7Pz PNJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uLqFevdRKdX3fFADjGlDweftzD11V/LJgrH1Eo1lgTk=; b=kkc3MGXLZumaC/GxsH9KOcfEsvrZDOWSXkYDoNcJPwzTmUvV7MqXFeUoS4iUwAZ5dR vPYW4A+i1cL7TMXtLMsHs1IQlNdA0nvEyIQTSk9QYJBGXL41LXH0aq9Lv8140ob1EMtC kd9MXQW1crQKWRyx7IVTUZunoQU//DmozDVMcj2Qurgp9x9zEmhUBpJHVjswxo5rky5P 5Wyz7zJPy4PBiOOGn76Y6jr1DKBpcnpEixSeFefodd1+TH9DLoYrqLklSIM78K3oX5SS 6XX5L9uVa2FwXZ7E67YNEuMiHfWKduvJjifAU8RfYHZLoEf/+m7Z0/gEGJhK9E30ePCO GUvA== X-Gm-Message-State: AHQUAuawrxIZkcNOt6ozULgK4Vf8m0/vB/kLQVpqvK8fdJyfX5W5fjLy nWBLrbo0UX5EG4lgiSC0zj6tSg== X-Google-Smtp-Source: AHgI3IZZz0avQYzpq2udsUkDwxxHYxaxQEPTeBXCoyA+O2uQr22/j3yPxq7+Q56biovHnYpK6sMBzw== X-Received: by 2002:a5d:4d46:: with SMTP id a6mr28780973wru.28.1549912051501; Mon, 11 Feb 2019 11:07:31 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 2sm27320947wrg.89.2019.02.11.11.07.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 11:07:30 -0800 (PST) Date: Mon, 11 Feb 2019 19:07:29 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20190211190729.6nwdyqzeuom5fgvm@bivouac.eciton.net> References: <20190211183322.23133-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190211183322.23133-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacer/Stage2Tables: fix build for cross compile from x86 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 19:07:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 11, 2019 at 07:33:22PM +0100, Ard Biesheuvel wrote: > AArch64 binutils support AArch32 seamlessly when running natively, > which allowed us to drop the -I objcopy argument specifying that > the input format is elf64-little, which is no longer accurate now > that the module can be built in 32-bit mode as well (which makes no > difference whatsoever given that the resulting binary image is only > a set of stage2 page tables) > > The same does not apply to binutils hosted on x86, so add back the > appropriate input format depending on the target type. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Acked-by: Leif Lindholm Tested-by: Leif Lindholm > --- > Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf b/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf > index f845015b9002..3e7039d586e1 100644 > --- a/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf > +++ b/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf > @@ -26,6 +26,8 @@ [Sources] > [BuildOptions] > *_*_*_OBJCOPY_PATH == objcopy > *_*_*_OBJCOPY_FLAGS == -O binary -j .rodata > + *_*_AARCH64_OBJCOPY_FLAGS = -I elf64-little > + *_*_ARM_OBJCOPY_FLAGS = -I elf32-little > *_*_*_ASM_FLAGS == -nostdlib -Wl,-e,0x81f8000,--section-start=.rodata=0x81f8000 > *_CLANG35_*_ASM_FLAGS = -no-integrated-as > *_CLANG38_*_ASM_FLAGS = -no-integrated-as > -- > 2.20.1 >