From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 50E95208AE9B6 for ; Mon, 11 Feb 2019 13:36:13 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id m1so783923wml.2 for ; Mon, 11 Feb 2019 13:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2aFNI1WzoFFuRudwdnpAC7VCHfwIsNk8+Es87ouclcU=; b=baAtDqZbL5bNrOWViPPNjGibgbR/w07m4GPqU9GCw2O2XowfRmKnaxCr6zwi9nBlMi 1/W96A22vPsfo8fX3lB8a614tyJiUJRfPBK46LTaIob/KXy2E7x3zJyrNpYB8kckylN+ TuKTen3R1kYWick7DHlg0OkRxA0gX5tvj0PvdUsSlmaBhIY7dkGRayaujXhtn7D/BBz0 l+ml2dL2luyX6oSLK8CML8t3s8AYVO8kXCjQFvd0Waz1GWHvRapVNRvmRyyyQwF5kQ+8 K0OoOKTSTQ4BLBOW8zBjBxodNiWxkiB0MkV7P6VmX8lK7XnXF2sezkWoyCJKz3IysjTj eLQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2aFNI1WzoFFuRudwdnpAC7VCHfwIsNk8+Es87ouclcU=; b=Ist6H1xVPTZJXuHmUBuF4POQ5vjf9pAeD5NRr2gNTxdZ9SaAdCRXFXc96LjMurpC50 oD+rYMaCKWHHLYH+D6E7q00VcgHN/8HpTxPVM7C0dCmSuHyWBcPqucg6FOgN3KzKFxsD IWnbHm/GW7n4uWH+ut7lRBTTq7reY7dUsrdoFZt3O58pEc8kLGMO/sDm2G0Tk8bIONAl v0S54i3p6gTrlkGRQgtXtsZoXQBWfm6kg3gQPpi1hqbPtGt7TJMgFhYIHDU1OmHXERlS Ahbhx7so7gNEZBUEgPOwWWKbJn6mxb9BF/CZX3RaLFdzRUMOmJVsz238mCdtQUO7qKyT K/XA== X-Gm-Message-State: AHQUAuZ7RrEH5tUMJYYMpvxr+dfjAh23vnN0JNLldI36hger0ooxx3+B HvMI1eFwcsKByD51aTWpbm2Y+A== X-Google-Smtp-Source: AHgI3Ib46XR06IzxOOOzv1B4UlZKB/G1BZQl2VDCu+psgvn1JCeP9boLfVYqbj03aLKj9LxLvzoP+A== X-Received: by 2002:a7b:cf30:: with SMTP id m16mr265760wmg.22.1549920971634; Mon, 11 Feb 2019 13:36:11 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k2sm283158wmj.45.2019.02.11.13.36.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 13:36:10 -0800 (PST) Date: Mon, 11 Feb 2019 21:36:08 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190211213608.w7zqyap6vws4lam5@bivouac.eciton.net> References: <20190201142507.30454-1-ming.huang@linaro.org> <20190201142507.30454-3-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190201142507.30454-3-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 21:36:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: > As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 > context. PI specifies 'BSP' for Boot-strap Processor, as the one > executing all of the EDK2 code. It then uses 'AP' to refer to > Additional Processors, which can be assigned tasks using the > EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be > 'BSP'. So, Rename StartupAp() to StartUpBSP. Please add a comment somewhere that this applies to D0x PlatformSysCtrlLib. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes > Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes > Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes > 3 files changed, 0 insertions(+), 0 deletions(-) These are substantial changes in image size from only changing the name of a function. So I'll have a little look around. 1610 version appears to have switched from building with GCC49_RELEASE to GCC48_RELEASE. 1616 and 1620 versions seem to have used GCC48_RELEASE all along. I definitely see additional renamed functions in these libraries too. Please have an inventory and determine what may be affecting image sizes. Also, I *beg* you - please upgrade from "GNU C 4.8.3 20131202 (prerelease)". / Leif > > diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib > index 68be770..4c63a26 100644 > Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ > diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib > index b3cc88e..cb2c652 100644 > Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ > diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib > index 50d453a..d643f7b 100644 > Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ > -- > 2.9.5 >