From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D27CE201B0416 for ; Tue, 12 Feb 2019 04:17:36 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id f14so2471641wrg.1 for ; Tue, 12 Feb 2019 04:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uVtnojfO2/664r6jBK1BxU+gWBjFRwa9EQhZwC6O8uI=; b=edQxoY11LEWxhS3pFbi/sorrucpr1GIquZ2iXjihMRI3x/c5L6td+97k4/QtQ0860d oYBPxjIl/6eDkare5xViLVoTk1xHCi30kTqpoUGLNZbV5Glqn3HwJzPZQzME5yvjR1L6 pEefXHFHlFmd8Z068OO6UiOeuvMdedpFA87n6jMEXZqxtvPbOBpXWcWds88hiJloz8+E h80/OjwmTqAM23eYF47I6QYbn6vPgeO2Ap9a2sUNsgRT4PRGSl8SoR13zoxPuyWTySfc RpPxSSmDL009Gu/FQQTtiMlIyKhzhhPc7ZDY1wmIDSDoH8sPuqA4h/8JN5DMESWl9VtV GSwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uVtnojfO2/664r6jBK1BxU+gWBjFRwa9EQhZwC6O8uI=; b=dXbR4kP2p4LG6V72DqA8TLPpsX9rBYd7KuJd94sDOQ04aOkuyOL6OHham5T+4vpqXa m83gfewEsiZ1su3flUGlEtEk2wO08dPHSbjgnv++xQIDrS/Tj/KiZ7JyMl/K1gEmC2f9 VcZXIIgm5m5e3gnEgPiqsgGWYVW3h5Kffl+ai/NfuQ9Lcn6DEy2ZodyCvMM5gXS1hmec 8QoRpp5IX81gBf4WXotPDY9zhpJ+4sRxz7HFzpbVWaBPk+vrVTswrJUwoVmjpIR6pBNd syM8ZcxHkaNUmS7RACI/jf4P4t/uOlLZkJRJsye7QcbZFpvusByWMooeZaOGwqUeBzPe agpA== X-Gm-Message-State: AHQUAuaZAY17HFu9SsKY3/gFlYjd5/Q5CbFjj3U3uK8qgLAZiZKn4DhI 2EHHQnsAffmKFGMUOLO2V39EWA== X-Google-Smtp-Source: AHgI3IZfgNPPC4K2THt9HrRjiEBNgsoqunOAsd4litQjdFoeBg3KCkz1rfWGJ/6lSPzXIrGsw1JEOg== X-Received: by 2002:a5d:4303:: with SMTP id h3mr2694286wrq.273.1549973855197; Tue, 12 Feb 2019 04:17:35 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r12sm15437509wrt.76.2019.02.12.04.17.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 04:17:34 -0800 (PST) Date: Tue, 12 Feb 2019 12:17:32 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190212121732.mdnutpj4x4v645zo@bivouac.eciton.net> References: <20190201142507.30454-1-ming.huang@linaro.org> <20190201142507.30454-3-ming.huang@linaro.org> <20190211213608.w7zqyap6vws4lam5@bivouac.eciton.net> <9c8d26cd-b0bb-e573-8a12-20259271c40e@linaro.org> <20190212104459.lifteascit2anj6h@bivouac.eciton.net> <51a23852-cfb8-a6c0-9a0d-21c39143d506@linaro.org> MIME-Version: 1.0 In-Reply-To: <51a23852-cfb8-a6c0-9a0d-21c39143d506@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 12:17:37 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 12, 2019 at 08:07:52PM +0800, Ming Huang wrote: > >> For D06 library, we use the same source code to support all Hi1620 projects, > >> include product projects,so there are some modify for this, like support > >> 3 sockets, 4 sockets and remove some useless functions. > > > > So please reword the subject line of this commit to explain it is an > > overall update of PlatformSysCtrlLib - including which bits are dropped. > > > > And I think this makes a good argument for moving the header files for > > binary-only libraries from edk2-platforms to edk2-non-osi. > > If you do that in a separate patch before this one, you won't need to > > include as much detail in the commit message as you will otherwise. > > Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to edk2-non-osi? Yes. Any interfaces exposed _only_ by implementations in edk2-non-osi. If there are any interfaces _also_ exposed by implementations in edk2-platforms, then I would prefer for them to remain in edk2-platforms. Ideally, this would also include (the multiple) SerdesLib.h, IpmiCmdLib.h, and possibly others. Regards, Leif