From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79D7E21962301 for ; Tue, 12 Feb 2019 07:12:43 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id b11so3364455wmj.1 for ; Tue, 12 Feb 2019 07:12:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=N+qM48DV+8K6VfV49VUqfV9UYvGXsFiOfadGiaty++E=; b=HnvP395r55Mg8E7z+lJIoErR3GsP0L16u1RxF6w7+oqZ9eYendNhdguOq3v5izciUr O9fR8HpmkThsQRoHCnE/gN3vazw9Vy3I/YbfqalnN/ItOVIg/qu7Ga2WMVED9rqL/42t spfuAP+vWSNeir0AXzKIEhIiRNc/WBaLP9IqafNTzztfraJK/jEHbvNJpieXqfcDY2Ub NwQsimc/AYgUyfXqJUDjrlqRUXYRuPw+mFXkgbnMaUdZzTOlBkLmCtewXcy9uD7tWDcS Fy70W4WP8JSaiDkjaSE8yZ7tv5eUmSRI7ApNK2SrRjOJA06BH4sVmT06s7eBqCj1vh5t 3pZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=N+qM48DV+8K6VfV49VUqfV9UYvGXsFiOfadGiaty++E=; b=rbZTnpVhyKhPg+8+L626uhkxorK49JWZXtGLZaGsk78jix91/ULE4mRn6a7CYtZido SxCCBIOfR8dek5KRys6WdHatWWrT4HOXM1cuIZl5qCwpJtw4/g1YlKEbejORXoBYCrae G0+3mQ2y0TUga7X7Zh0ND90sCTBwqAxcvWAc4K+FT1cNgjrk90/d/NcNDa7YDGv70SVP HwMMORNYmXltjX3noBngl/8+t/5Vu7obvhbtpMtBV0ZEDhCRcd8f4QpIvFdfahnVOA4P ObVju+dfIV2cgOmJWz1sDQegeeW6yKjqYaTAgIlC4sXqobOKXu4BZetrsouNGgXu722g BlrA== X-Gm-Message-State: AHQUAuYgTNVa79fTi+DTHbz9lVfXX9yeKYzoP/UQPGwcQyvwCufm0iog 4VBjbDzwkc6HIVik6NE59l3MiQ== X-Google-Smtp-Source: AHgI3IYG9m+qr8+NP9IniVEGi3jH0qNZbuekqZc77+5KQR4gDCRY/zxD78Vy+MPb6IWnB/CO0+Lr3g== X-Received: by 2002:a7b:c08f:: with SMTP id r15mr3371428wmh.118.1549984361779; Tue, 12 Feb 2019 07:12:41 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h17sm2186640wmb.29.2019.02.12.07.12.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 07:12:40 -0800 (PST) Date: Tue, 12 Feb 2019 15:12:38 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190212151238.hudsqbg2qiqp7qwa@bivouac.eciton.net> References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-4-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190201133436.10500-4-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 03/16] Hisilicon/D06: Optimize SAS driver for reducing boot time X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 15:12:43 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 01, 2019 at 09:34:23PM +0800, Ming Huang wrote: > SAS controller is always existed, so accessing SAS register don't > depend on PciBusDxe (pci enumeration). > Move the SAS module early in D06.fdf for dispatching SAS driver > early. This can avoid wait in BDS normally and reduce boot time. > > This patch is relative with SasDriverDxe in edk2-non-osi. I think you are saying that this change is only valid after the update to SasDriverDxe in edk2-non-osi has been applied? Or does it mean that it only improves performance after that edk2-non-osi patch has been applied? Please be more explicit in the commit message. Other than that. I'm OK with this patch. / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.fdf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf > index a937660a09e2..d495ad7f264c 100644 > --- a/Platform/Hisilicon/D06/D06.fdf > +++ b/Platform/Hisilicon/D06/D06.fdf > @@ -165,6 +165,7 @@ [FV.FvMain] > INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > INF Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.inf > + INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf > # > # PI DXE Drivers producing Architectural Protocols (EFI Services) > # > @@ -296,7 +297,6 @@ [FV.FvMain] > # > INF Platform/Hisilicon/D06/Drivers/Sm750Dxe/UefiSmi.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > - INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf > INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > -- > 2.9.5 >