From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF30E201B0424 for ; Tue, 12 Feb 2019 07:17:07 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id t27so3085232wra.6 for ; Tue, 12 Feb 2019 07:17:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+MgvE6OahmOK0j/OHH+gkfidNAKpvooYsIKoDoe4xHw=; b=M8LrXeXTsDtW4kRtPO1wt8L0bULkYhyNoQ5pnt9g4fanbqh+HhAnNPfyaklYkaqjvI xszXrCSbdjb00kWSKAaQuc0fiAPWW367XVQ4DbGSb8xzowWDa0rWu4jvoF7AyDtHsrdj 415uhfnAfYonAhW+gvH1pX2lqfqR/FAWailD31XGQmTDVkOdjfrFTHSA7xul9wU1Rm+H ljwJtlCdkILuliKO+12GjRZLkwRNiUgvAYMBnmJUmbwJF3nK9HtWYNEimIKkwat7g4jo B8dYqWviPPvrc5StK6n8OzDUM1GL0ryAVoJCPnwDkYfgPafIsPaOkH/PdgcQu3bZMnAo u5tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+MgvE6OahmOK0j/OHH+gkfidNAKpvooYsIKoDoe4xHw=; b=AtJOEqbplpmODAh2Ql0+HQQieKxA9mCHD7hjHiP5CKv5/b+oZMDezQwT3eLwa5L079 0kEmrB6K/FKO3AH9WABlLLH3VYMxMgTNtg7HXZATki9Sa0SvWbpzPnA1WXobN2MzNr9S 4nQK1U4Dfz/w3YuqMYV28uL+/ySDsKw+u9NxRkjX1domHtQlfwy+bam0v+kd3zROZ/uS 1sf6Q5ovXxoMGMCF0N0zuN7+RONPE+4U5lskc8HGURd7bVk7a1LuE1TXRrLnKrsmR6Rh PFzPU6AV2mWy38S09+zlD46y9B+2eJFM3+tPAr3wuPFBumKMSeMK7jUM3RbnVl+l+D9o nhbA== X-Gm-Message-State: AHQUAuYsLY/pgzoI8f4LNQQijdmK+R1RB8Kx1VpViwEXJmoJIu6xYtmW GjbP20Lpca0QkeEIwzf5rvdXTw== X-Google-Smtp-Source: AHgI3IYOW97IQI30LYJ8M6aLUnTLMupk2EG03IMIWp63MqGhgEC4r8u8EZEESgIY1+JEGTJgG6ATWg== X-Received: by 2002:a5d:438a:: with SMTP id i10mr3201503wrq.111.1549984626383; Tue, 12 Feb 2019 07:17:06 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a6sm3416637wmh.10.2019.02.12.07.17.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 07:17:05 -0800 (PST) Date: Tue, 12 Feb 2019 15:17:03 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190212151703.zf4dwnavu4jo2fut@bivouac.eciton.net> References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-5-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190201133436.10500-5-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 04/16] Hisilicon/D06: Fix access variable fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 15:17:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 01, 2019 at 09:34:24PM +0800, Ming Huang wrote: > From: Jason Zhang > > BmcWdtEnable is a field of OemConfigData structure, need have > runtime service attribution if use it during exit boot service This sounds like a very shady thing to do. Which module is seeing issues, and what issues are it seeing, during ExitBootServices? / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr | 2 +- > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > index 470e9ace3dcf..08236704fbfe 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr > @@ -23,7 +23,7 @@ formset > help = STRING_TOKEN(STR_OEM_CONFIG), > classguid = gEfiIfrFrontPageGuid, // for MdeModule Bds. > efivarstore OEM_CONFIG_DATA, > - attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE, > + attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS, > name = OemConfig, > guid = gOemConfigGuid; > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > index 012d45bc0214..6668103af027 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > @@ -316,7 +316,7 @@ OemConfigUiLibConstructor ( > Status = gRT->SetVariable ( > OEM_CONFIG_NAME, > &gOemConfigGuid, > - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, > + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, > sizeof (OEM_CONFIG_DATA), > &Configuration > ); > -- > 2.9.5 >