* [PATCH 1/3] MdePkg: Change structure parameter types
2019-02-13 6:51 [PATCH 0/3] Change parameters' type in MdePkg and MdeModulePkg Shenglei Zhang
@ 2019-02-13 6:51 ` Shenglei Zhang
2019-02-14 0:06 ` Gao, Liming
2019-02-13 6:51 ` [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function " Shenglei Zhang
2019-02-13 6:51 ` [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: " Shenglei Zhang
2 siblings, 1 reply; 7+ messages in thread
From: Shenglei Zhang @ 2019-02-13 6:51 UTC (permalink / raw)
To: edk2-devel; +Cc: Michael D Kinney, Liming Gao
Change parameter Opcode from UINT16 to UINTN
in EFI_S3_SAVE_STATE_WRITE and EFI_S3_SAVE_STATE_INSERT.
https://bugzilla.tianocore.org/show_bug.cgi?id=1517
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdePkg/Include/Protocol/S3SaveState.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Protocol/S3SaveState.h b/MdePkg/Include/Protocol/S3SaveState.h
index 9e7b4050f6..1563527148 100644
--- a/MdePkg/Include/Protocol/S3SaveState.h
+++ b/MdePkg/Include/Protocol/S3SaveState.h
@@ -52,7 +52,7 @@ typedef
EFI_STATUS
(EFIAPI *EFI_S3_SAVE_STATE_WRITE)(
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
);
@@ -98,7 +98,7 @@ EFI_STATUS
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
IN BOOLEAN BeforeOrAfter,
IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
);
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] MdePkg: Change structure parameter types
2019-02-13 6:51 ` [PATCH 1/3] MdePkg: Change structure parameter types Shenglei Zhang
@ 2019-02-14 0:06 ` Gao, Liming
0 siblings, 0 replies; 7+ messages in thread
From: Gao, Liming @ 2019-02-14 0:06 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Kinney, Michael D
The change is good. Please update header comments to describe the change in PI 1.7.
With this change, Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zhang, Shenglei
>Sent: Wednesday, February 13, 2019 2:52 PM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [PATCH 1/3] MdePkg: Change structure parameter types
>
>Change parameter Opcode from UINT16 to UINTN
>in EFI_S3_SAVE_STATE_WRITE and EFI_S3_SAVE_STATE_INSERT.
>https://bugzilla.tianocore.org/show_bug.cgi?id=1517
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> MdePkg/Include/Protocol/S3SaveState.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/MdePkg/Include/Protocol/S3SaveState.h
>b/MdePkg/Include/Protocol/S3SaveState.h
>index 9e7b4050f6..1563527148 100644
>--- a/MdePkg/Include/Protocol/S3SaveState.h
>+++ b/MdePkg/Include/Protocol/S3SaveState.h
>@@ -52,7 +52,7 @@ typedef
> EFI_STATUS
> (EFIAPI *EFI_S3_SAVE_STATE_WRITE)(
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
>
>@@ -98,7 +98,7 @@ EFI_STATUS
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
> IN BOOLEAN BeforeOrAfter,
> IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
>
>--
>2.18.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types
2019-02-13 6:51 [PATCH 0/3] Change parameters' type in MdePkg and MdeModulePkg Shenglei Zhang
2019-02-13 6:51 ` [PATCH 1/3] MdePkg: Change structure parameter types Shenglei Zhang
@ 2019-02-13 6:51 ` Shenglei Zhang
2019-02-14 0:06 ` Gao, Liming
2019-02-13 6:51 ` [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: " Shenglei Zhang
2 siblings, 1 reply; 7+ messages in thread
From: Shenglei Zhang @ 2019-02-13 6:51 UTC (permalink / raw)
To: edk2-devel; +Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng
Change parameter Opcode from UINT16 to UINTN in
BootScriptWrite and BootScriptInsert.
https://bugzilla.tianocore.org/show_bug.cgi?id=1517
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h | 4 ++--
MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
index 19600085f1..b710919881 100644
--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
@@ -75,7 +75,7 @@ EFI_STATUS
EFIAPI
BootScriptWrite (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
);
/**
@@ -112,7 +112,7 @@ BootScriptInsert (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
IN BOOLEAN BeforeOrAfter,
IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
);
/**
diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
index 274f3be12c..5913078d69 100644
--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
@@ -542,7 +542,7 @@ EFI_STATUS
EFIAPI
BootScriptWrite (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
)
{
@@ -697,7 +697,7 @@ BootScriptInsert (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
IN BOOLEAN BeforeOrAfter,
IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
)
{
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types
2019-02-13 6:51 ` [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function " Shenglei Zhang
@ 2019-02-14 0:06 ` Gao, Liming
0 siblings, 0 replies; 7+ messages in thread
From: Gao, Liming @ 2019-02-14 0:06 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Wu, Hao A, Zeng, Star
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Shenglei Zhang
>Sent: Wednesday, February 13, 2019 2:52 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change
>function parameter types
>
>Change parameter Opcode from UINT16 to UINTN in
>BootScriptWrite and BootScriptInsert.
>https://bugzilla.tianocore.org/show_bug.cgi?id=1517
>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h | 4 ++--
> MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git
>a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>index 19600085f1..b710919881 100644
>--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>+++
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>@@ -75,7 +75,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
> /**
>@@ -112,7 +112,7 @@ BootScriptInsert (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
> IN BOOLEAN BeforeOrAfter,
> IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
> /**
>diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>index 274f3be12c..5913078d69 100644
>--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>@@ -542,7 +542,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> )
> {
>@@ -697,7 +697,7 @@ BootScriptInsert (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
> IN BOOLEAN BeforeOrAfter,
> IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> )
> {
>--
>2.18.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: Change function parameter types
2019-02-13 6:51 [PATCH 0/3] Change parameters' type in MdePkg and MdeModulePkg Shenglei Zhang
2019-02-13 6:51 ` [PATCH 1/3] MdePkg: Change structure parameter types Shenglei Zhang
2019-02-13 6:51 ` [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function " Shenglei Zhang
@ 2019-02-13 6:51 ` Shenglei Zhang
2019-02-14 0:06 ` Gao, Liming
2 siblings, 1 reply; 7+ messages in thread
From: Shenglei Zhang @ 2019-02-13 6:51 UTC (permalink / raw)
To: edk2-devel; +Cc: Jian J Wang, Hao Wu, Ray Ni, Star Zeng
Change parameter Opcode from UINT16 to UINTN in
BootScriptWrite and BootScriptInsert.
https://bugzilla.tianocore.org/show_bug.cgi?id=1517
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.h | 4 ++--
MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.h b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.h
index 51cf9db4aa..440f43defe 100644
--- a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.h
+++ b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.h
@@ -58,7 +58,7 @@ EFI_STATUS
EFIAPI
BootScriptWrite (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
);
/**
@@ -95,7 +95,7 @@ BootScriptInsert (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
IN BOOLEAN BeforeOrAfter,
IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
);
/**
diff --git a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
index c1d29b5d3a..bd43011b79 100644
--- a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
+++ b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
@@ -540,7 +540,7 @@ EFI_STATUS
EFIAPI
BootScriptWrite (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
)
{
@@ -695,7 +695,7 @@ BootScriptInsert (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
IN BOOLEAN BeforeOrAfter,
IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
- IN UINT16 OpCode,
+ IN UINTN OpCode,
...
)
{
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: Change function parameter types
2019-02-13 6:51 ` [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: " Shenglei Zhang
@ 2019-02-14 0:06 ` Gao, Liming
0 siblings, 0 replies; 7+ messages in thread
From: Gao, Liming @ 2019-02-14 0:06 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Wu, Hao A, Zeng, Star
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Shenglei Zhang
>Sent: Wednesday, February 13, 2019 2:52 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH 3/3] MdeModulePkg/SmmS3SaveStateDxe: Change
>function parameter types
>
>Change parameter Opcode from UINT16 to UINTN in
>BootScriptWrite and BootScriptInsert.
>https://bugzilla.tianocore.org/show_bug.cgi?id=1517
>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.h | 4 ++--
> MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c | 4
>++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git
>a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.
>h
>b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.
>h
>index 51cf9db4aa..440f43defe 100644
>---
>a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.
>h
>+++
>b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/InternalSmmSaveState.
>h
>@@ -58,7 +58,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
> /**
>@@ -95,7 +95,7 @@ BootScriptInsert (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
> IN BOOLEAN BeforeOrAfter,
> IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> );
> /**
>diff --git
>a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
>b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
>index c1d29b5d3a..bd43011b79 100644
>--- a/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
>+++ b/MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c
>@@ -540,7 +540,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> )
> {
>@@ -695,7 +695,7 @@ BootScriptInsert (
> IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
> IN BOOLEAN BeforeOrAfter,
> IN OUT EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>- IN UINT16 OpCode,
>+ IN UINTN OpCode,
> ...
> )
> {
>--
>2.18.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread