From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 73A07202E53B6 for ; Wed, 13 Feb 2019 01:08:58 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id v13so1572841wrw.5 for ; Wed, 13 Feb 2019 01:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MOEGClFvGGL5ug1VMz8n9O5rfhkQk0RkbjheNBSdP6w=; b=LM95F8pi5IbuSLfRUSCVGLVlogoy0XRpbbEUTKDuef9HXkb7AYBP0vRytb5QwL3+5Q dSxie+o7akvATU1LPXfX01JxIQCPftLaZfCOtucoxTbjbjJPBY5+Q2I9vL/rpr8ESkMy Iu4qzq5xyW4IJeFRHA4Pu5vFH50I/yQSPMrLfADZMFkxpPCHFC+3Eu5o/AnAHdVkWuMz B3cjLdklUuHdHe8dskLSFpzUHvsqSqXyehzhYZY6hzk4AhKtd1qMOPfky+fLVqFxysJZ +sYeed6/i8nBvMtBDkmj41cYc6ZwwJ9xcac1y+pDv/TEsz755bLT8kHqla9IVOfZ6nj3 kdNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MOEGClFvGGL5ug1VMz8n9O5rfhkQk0RkbjheNBSdP6w=; b=Ck5cDCBisIfGpsn82hUWze0CG15cp2faLiG3k16I7ogJKwxF1X4MZNYTqnOh4cHgQM wj3odOk1HVHsDt80SJHY5cx5fh33qqP2Y83wkJupHGjZuui8pZ5bmDP+IqGGFZjhm2rZ Dsc9bfjs7Hl3p6+mWlN0POglmqo626ezISqsMAUWELkwGJlXyYd9TPUKGxSOfawzT1be V9ENTPWePGBc70RVfIFMgND5Wmc9lbpoaVGOz36/eBOcvvv1pKTIBF9SqI7AfxW+LRxw A4xHQpcpSM72bVO/f3BoPaPzIB+ouvX00XKuQ2bhn8jrr70sEhFCIN91fFw+e7WbbqtA sTTA== X-Gm-Message-State: AHQUAuYsyjMiaqXpQRjtLkXyAn6tZIBPdxj3FHtWh6vHQAU+SeQSC/r7 lK7H4Eww4/WYCU88zcxxswCUIw== X-Google-Smtp-Source: AHgI3Ia4HI1eUMmq13bP/7pJdJBlWB52HcvaQ8jO4b1RPhaN/8ACTmu6iwf4mYBta3fW2jp+C31d0Q== X-Received: by 2002:a5d:4711:: with SMTP id y17mr6535425wrq.141.1550048936437; Wed, 13 Feb 2019 01:08:56 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a14sm12736757wrr.13.2019.02.13.01.08.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 01:08:55 -0800 (PST) Date: Wed, 13 Feb 2019 09:08:53 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190213090852.jbcwc7reifl4l24n@bivouac.eciton.net> References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-10-ming.huang@linaro.org> <20190211185140.6vn7swtqtiencdak@bivouac.eciton.net> <71d90497-0095-5709-9938-3ac31212bb8d@linaro.org> MIME-Version: 1.0 In-Reply-To: <71d90497-0095-5709-9938-3ac31212bb8d@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 09/16] Hisilicon/D06: Add PCI_OSC_SUPPORT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 09:08:58 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 13, 2019 at 10:59:17AM +0800, Ming Huang wrote: > On 2/12/2019 2:51 AM, Leif Lindholm wrote: > > On Fri, Feb 01, 2019 at 09:34:29PM +0800, Ming Huang wrote: > >> Add PCI_OSC_SUPPORT for remaining host bridges to remove fail > >> output in kernel: > >> [ 103.478893] acpi PNP0A08:01: _OSC failed (AE_NOT_FOUND); > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ming Huang > >> --- > >> Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 64 ++++++++++++++++++++ > >> 1 file changed, 64 insertions(+) > >> > >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl > >> index 4d9d9d95be68..86d8728b82f2 100644 > >> --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl > >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl > >> @@ -17,6 +17,50 @@ > >> **/ > >> > >> //#include "ArmPlatform.h" > >> + > >> +/* > >> + See ACPI 6.1 Spec, 6.2.11, PCI Firmware Spec 3.0, 4.5 > >> +*/ > >> +#define PCI_OSC_SUPPORT() \ > > > > PCI0 and PCI6 already have _OSC entries. > > This macro ends up being used for 1-5 and 7-B. > > So calling it PCI_OSC_SUPPORT seems somewhat misleading. > > > > Then again, there is a lot of similarities between this macro and the > > existing entries. Could the same macro be used for 0 and 6? Or could > > the macro be split up into multiple parts and reused? > > When I make this patch, I try to rewrite PCI0/6 with the same macro, but > the macro don't support parameter. For spliting up multiple parts, if modify > something in future, the parts need to split up to smaller parts. So, if > need to rewrite PCI0/6 with macro, is it applicable to add another macro > PCI_OSC_SUPPORT_HOTPLUG? Yes, that sounds like a good solution to me. Regards, Leif