From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F9D5202E53C0 for ; Wed, 13 Feb 2019 01:42:26 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id i12so1725604wrw.0 for ; Wed, 13 Feb 2019 01:42:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mu5mQ0xnUVTiul1Ub9QmWeLGQ7Helu6aKxwtFgPeyCQ=; b=xeM7C0ERQpDEk4H1ylm11oyXiR4xhjJ59rXdUZ/uTdcTImwHKmiXc8pefJzTZusK0b yNnOMYaHzXHaC7U0hf2YWdxjguHyR+5YpAL9FCsr2RQpFMXckopbx1lBwJI8M/+j9OY8 C3oiUflw+HFBjgV/gtt3I3/8MlYefqz4NLEEtn8rw44rSzwZPL9DodIV3EZJEwaV+Moz X+IImFP3zMSBP5g5gwXVC/TVvEaH51VdlUSfZG/GfxJh/Y6Fi5inBNqhp+VBXfq1kSpN wx+CDAVCOt/kcjSHhMW/94YYeRcp/AsIZICtsCrQ5US1V/SRfk4PeWYKciZssccc33Az 6PRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mu5mQ0xnUVTiul1Ub9QmWeLGQ7Helu6aKxwtFgPeyCQ=; b=Am9ODkLa5KZ58XpKYa/tufcAbCPvx/nkjPRz58naEbkdickPT981wM3aJh3kqjsJWM BHkNeMpBdjbSmJuwMSxlB1Nv7o20Z5ICQ+oU2H45UT1MnENZAS5vfIJYg7IlONHmQEiF UDHrU5GDzSBKfRxTGUnIRTwVOm23w3+jnSw0K/D2WThFpAnCc8dFVfFZtd1th8wDI2A0 4LwOvwK6XmMZWJ9/oY8VePnWIbJbsKKwzJ8cITGoReNS8OaHnQ/6or0nzjcnQ6ZZdxgn 1NOpxS/jsJDV0TaHfC6tNBB0UYcwLKXnimIEjpnmW4CLlb3hFaZLtgNbejNB7WJydwZi JhPQ== X-Gm-Message-State: AHQUAubLxHFX/MGoyoflB7bS2M+Q5B32HUch87runstnhyaq906uLLoZ h/oCV7zVgEGD2QXeC9ftkNNn/Q== X-Google-Smtp-Source: AHgI3IbzU5ODJE1Ngw9b6pPFsxl7dCJ5dQxgAfZDpySswGdyklLN8MAhV0RYaHfviXJc6EKi3Nom9Q== X-Received: by 2002:adf:e747:: with SMTP id c7mr6107441wrn.176.1550050944441; Wed, 13 Feb 2019 01:42:24 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o5sm5099806wrh.34.2019.02.13.01.42.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 01:42:23 -0800 (PST) Date: Wed, 13 Feb 2019 09:42:22 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20190213094222.4w64s3wnrc7fikv2@bivouac.eciton.net> References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-2-ming.huang@linaro.org> <20190211150505.h7itd4fqvrfazeqs@bivouac.eciton.net> <49ffdca4-332a-2678-145a-50fb2be4d000@linaro.org> MIME-Version: 1.0 In-Reply-To: <49ffdca4-332a-2678-145a-50fb2be4d000@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 09:42:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 13, 2019 at 02:36:11PM +0800, Ming Huang wrote: > > Should it not then also delete #include from > > Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, > > Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c > > ? > > > > Meanwhile, > > Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c > > and > > Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c > > both include this header, but > > Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf > > and > > Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.inf > > do not declare the dependency. > > OemMiscLibD06.c can remove the SerdesLib.h. As using the definitions in > SerdesLib.h, other .c files can not remove the header file. If they are using definitions from the library header, but not the library itself, there is something suspicious about the code structuring. But in the meantime, if they are referencing library header files, they need to list those libraryclasses in their .inf. > > Can you investigate and submit an updated patch addressing all of the > > unnecessary references? > > This may takes a lot of time, as Hi1620(D06) is our important project, > maybe we should focus on D06. Feel free to submit deletions for all and any platforms you are unwilling to maintain. Best Regards, Leif > Thanks > > > > > Best Regards, > > > > Leif > > > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ming Huang > >> --- > >> Platform/Hisilicon/D06/D06.dsc | 2 -- > >> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 - > >> 2 files changed, 3 deletions(-) > >> > >> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > >> index 396bd03c9d24..cbbd99e4a659 100644 > >> --- a/Platform/Hisilicon/D06/D06.dsc > >> +++ b/Platform/Hisilicon/D06/D06.dsc > >> @@ -64,8 +64,6 @@ [LibraryClasses.common] > >> > >> CpldIoLib|Silicon/Hisilicon/Library/CpldIoLib/CpldIoLib.inf > >> > >> - SerdesLib|Silicon/Hisilicon/Hi1620/Library/Hi1620Serdes/Hi1620SerdesLib.inf > >> - > >> TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > >> RealTimeClockLib|Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf > >> OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf > >> diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > >> index 61cead7779b9..8e5c56fa41fd 100644 > >> --- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > >> +++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > >> @@ -77,7 +77,6 @@ [LibraryClasses] > >> > >> IpmiCmdLib > >> > >> - SerdesLib > >> > >> [Protocols] > >> gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED > >> -- > >> 2.9.5 > >>