* [PATCH] OvmfPkg/build.sh: Enable flash for qemu 3 or later
@ 2019-02-16 8:18 Jordan Justen
2019-02-18 11:45 ` Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Jordan Justen @ 2019-02-16 8:18 UTC (permalink / raw)
To: edk2-devel
Cc: Jordan Justen, Laszlo Ersek, Ard Biesheuvel, Anthony Perard,
Julien Grall
The check for 1.[1-9][0-9].* was removed since qemu jumped to 2.0
after 1.7.
Changed 2.*.* to [2-9].*.* to match major releases 3 - 9.
Added [1-9][0-9]*.*.* to match major releses >= 10.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien.grall@linaro.org>
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 6821742e7a..97863b09f2 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -215,7 +215,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
grep -o -E 'version [0-9]+\.[0-9]+\.[0-9]+' | \
awk '{print $2}')
case $qemu_version in
- 1.[6-9].*|1.[1-9][0-9].*|2.*.*)
+ 1.[6-9].*|[2-9].*.*|[1-9][0-9]*.*.*)
ENABLE_FLASH=yes
;;
esac
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OvmfPkg/build.sh: Enable flash for qemu 3 or later
2019-02-16 8:18 [PATCH] OvmfPkg/build.sh: Enable flash for qemu 3 or later Jordan Justen
@ 2019-02-18 11:45 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2019-02-18 11:45 UTC (permalink / raw)
To: Jordan Justen, edk2-devel; +Cc: Ard Biesheuvel, Anthony Perard, Julien Grall
On 02/16/19 09:18, Jordan Justen wrote:
> The check for 1.[1-9][0-9].* was removed since qemu jumped to 2.0
> after 1.7.
>
> Changed 2.*.* to [2-9].*.* to match major releases 3 - 9.
>
> Added [1-9][0-9]*.*.* to match major releses >= 10.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 6821742e7a..97863b09f2 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -215,7 +215,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
> grep -o -E 'version [0-9]+\.[0-9]+\.[0-9]+' | \
> awk '{print $2}')
> case $qemu_version in
> - 1.[6-9].*|1.[1-9][0-9].*|2.*.*)
> + 1.[6-9].*|[2-9].*.*|[1-9][0-9]*.*.*)
> ENABLE_FLASH=yes
> ;;
> esac
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-18 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-16 8:18 [PATCH] OvmfPkg/build.sh: Enable flash for qemu 3 or later Jordan Justen
2019-02-18 11:45 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox