public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function
@ 2019-02-16 14:54 Feng, Bob C
  2019-02-19  9:07 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Feng, Bob C @ 2019-02-16 14:54 UTC (permalink / raw)
  To: edk2-devel; +Cc: Bob Feng, Liming Gao

MaxSizeUserSet is missing in Pcd deepcopy function.
This patch is to add it back to Pcd deepcopy function.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/Python/Workspace/BuildClassObject.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/Workspace/BuildClassObject.py b/BaseTools/Source/Python/Workspace/BuildClassObject.py
index 1df042f41c..d7ca9e8cf1 100644
--- a/BaseTools/Source/Python/Workspace/BuildClassObject.py
+++ b/BaseTools/Source/Python/Workspace/BuildClassObject.py
@@ -220,10 +220,11 @@ class PcdClassObject(object):
         new_pcd.Type = self.Type
         new_pcd.DatumType = self.DatumType
         new_pcd.DefaultValue = self.DefaultValue
         new_pcd.TokenValue = self.TokenValue
         new_pcd.MaxDatumSize = self.MaxDatumSize
+        new_pcd.MaxSizeUserSet = self.MaxSizeUserSet
 
         new_pcd.Phase = self.Phase
         new_pcd.Pending = self.Pending
         new_pcd.IsOverrided = self.IsOverrided
         new_pcd.IsFromBinaryInf = self.IsFromBinaryInf
-- 
2.18.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function
  2019-02-16 14:54 [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function Feng, Bob C
@ 2019-02-19  9:07 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2019-02-19  9:07 UTC (permalink / raw)
  To: Feng, Bob C, edk2-devel@lists.01.org

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Saturday, February 16, 2019 10:55 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function
>
>MaxSizeUserSet is missing in Pcd deepcopy function.
>This patch is to add it back to Pcd deepcopy function.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> BaseTools/Source/Python/Workspace/BuildClassObject.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/Workspace/BuildClassObject.py
>b/BaseTools/Source/Python/Workspace/BuildClassObject.py
>index 1df042f41c..d7ca9e8cf1 100644
>--- a/BaseTools/Source/Python/Workspace/BuildClassObject.py
>+++ b/BaseTools/Source/Python/Workspace/BuildClassObject.py
>@@ -220,10 +220,11 @@ class PcdClassObject(object):
>         new_pcd.Type = self.Type
>         new_pcd.DatumType = self.DatumType
>         new_pcd.DefaultValue = self.DefaultValue
>         new_pcd.TokenValue = self.TokenValue
>         new_pcd.MaxDatumSize = self.MaxDatumSize
>+        new_pcd.MaxSizeUserSet = self.MaxSizeUserSet
>
>         new_pcd.Phase = self.Phase
>         new_pcd.Pending = self.Pending
>         new_pcd.IsOverrided = self.IsOverrided
>         new_pcd.IsFromBinaryInf = self.IsFromBinaryInf
>--
>2.18.0.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-19  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-16 14:54 [Patch] BaseTools: Add MaxSizeUserSet to Pcd deepcopy function Feng, Bob C
2019-02-19  9:07 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox